From patchwork Fri May 3 11:18:21 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1094825 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44wV9x5NWVz9s7T for ; Fri, 3 May 2019 21:23:17 +1000 (AEST) Received: from localhost ([127.0.0.1]:38365 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWHW-0002BU-HA for incoming@patchwork.ozlabs.org; Fri, 03 May 2019 07:23:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59430) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWDw-00087B-M2 for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWDv-0001CA-Qs for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:28 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:58607) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWDt-00018e-LB; Fri, 03 May 2019 07:19:25 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1My6xz-1gXsbu3vP5-00zWCY; Fri, 03 May 2019 13:18:58 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:18:21 +0200 Message-Id: <20190503111832.30316-2-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503111832.30316-1-laurent@vivier.eu> References: <20190503111832.30316-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:0QU5eNHOBHQ37BR4B1E92mAHxrTiY4zvXiPU0hADaB4iQHXA5Sq h5sMHrvos8z0p1koLJgZvY2tWviBHmb5SW/oHK0UhoaXD2jGKfGG9jjfgsZ3XK/UqFPZpXI Cd+hK8P0WOxNt3dMABVm1W4lmURetT0gupaxVN7SF56eOEXu8Os9g3lY4IVhzMgXGAcGwEk DYMEj1G77xshBWiWOe5zA== X-UI-Out-Filterresults: notjunk:1; V03:K0:0ncdUtw6OE8=:uj5jldxlgdU53qEM3jkdLO rzTpLd0dmXC50Nku4aEYxYsSS5fRWu48VNFKC0XRPqMYfzw5kJegh8LA7j6iQdbGAhtcmN+Zn kJwSDvWze0miT1GQ/dRn7RrxZW+k3cc0ygOBOzOesJM7rbLQM9XsIi38eX3iO2GAKq2EmzuJo IG8U68jBtmNiFygjGtVCs57AuvdyHp99+bjv/j4zaCnkel2CE3jlOj5yS08RVZ4iu+4B1+iXS ZbQqVxkxc297DjBReYpPDbSE/eJxHtpK3Q5RvNHpNg2S6NcrfqAidFuc0mL+AuvOzq5ZQYogV 5ESI+Wg1HdfEINdb7uUn5M7GVortHobiwdbvXlIKnFV5cUGaC+gDBb/lPfkpby8W6YaV5wkn+ lKVdpid5/H8JaK+W8cTYxxzPtCvuiibKlfrDSk4tNhTwAwmw43xYY0vmtT4zT95RaYNQD+wl2 89whLqbZZIpYA+7DUXvdx9JME/eYjdEZ3CGgzqu4RvPZ7AG3lFCZ3uecNzjGB/7gKhbCfzk3Z TZheb+t4FRT4xlAeEYOkrzRDsL5wsdyru5c4/qrhPSzAUczNuhcXNV/xR7ycYSPsDO2FkcE2m Iu5Mx3n9MFgVXOnZy9cpjNSxr1I1yDOThPAxautNo6viqhvwTi2WM9/wFxi3T3d+34eI9wKXC zd8l6lWAvvk8wPh3C61eJ0/saUIvy0p3BpWW7WfX5nBtj64U+/4t+s3xIko0P8+mWY/ES5zpG fwbeatyzhu7jKRvLxlU3gCDTbPd26c4j+h+CwdRMk0O5+ieOH1InDOy2T+4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.187 Subject: [Qemu-devel] [PULL v2 01/12] hw/net/pcnet: Use qemu_log_mask(GUEST_ERROR) instead of printf X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Gerd Hoffmann , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= , =?utf-8?q?Andreas_F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Philippe Mathieu-Daudé Avoid to clutter stdout until explicitly requested (with -d guest_errors): $ qemu-system-mips -M malta -m 512 -kernel vmlinux-3.2.0-4-4kc-malta Bad SWSTYLE=0x04 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Message-Id: <20190311102712.8572-1-philmd@redhat.com> Signed-off-by: Laurent Vivier --- hw/net/pcnet.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c index d9ba04bdfc62..16683091c939 100644 --- a/hw/net/pcnet.c +++ b/hw/net/pcnet.c @@ -36,6 +36,7 @@ */ #include "qemu/osdep.h" +#include "qemu/log.h" #include "hw/qdev.h" #include "net/net.h" #include "net/eth.h" @@ -1501,7 +1502,8 @@ static void pcnet_bcr_writew(PCNetState *s, uint32_t rap, uint32_t val) val |= 0x0300; break; default: - printf("Bad SWSTYLE=0x%02x\n", val & 0xff); + qemu_log_mask(LOG_GUEST_ERROR, "pcnet: Bad SWSTYLE=0x%02x\n", + val & 0xff); val = 0x0200; break; } From patchwork Fri May 3 11:18:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1094820 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44wV6k0GYNz9s9N for ; Fri, 3 May 2019 21:20:30 +1000 (AEST) Received: from localhost ([127.0.0.1]:38294 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWEt-00088F-U8 for incoming@patchwork.ozlabs.org; Fri, 03 May 2019 07:20:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWDv-00085e-8h for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWDu-0001AX-CI for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:27 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:35825) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWDs-00016N-3p; Fri, 03 May 2019 07:19:24 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MmyzH-1gvwtI32mN-00k80g; Fri, 03 May 2019 13:18:59 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:18:22 +0200 Message-Id: <20190503111832.30316-3-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503111832.30316-1-laurent@vivier.eu> References: <20190503111832.30316-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:YZFnRmL1uAf+BVo5uQl59oP3wQVC+h9qdTXynIc+JHl4Ea/oGtH pkFj8BCrKy8Pxn0Q/FUKynxvnUnvZLD7NdjP5NdiuZazfWHK1Kuu3+u3DwadF0m1tIydvOF ThWtcKfebQXpbw+KNDEZLmawkANecvLH5TYaDxtCClxD/Kyow6CkffI5n7dh/u6cM8flmvE 1DIuNi6U9+ROC0zyuzAAQ== X-UI-Out-Filterresults: notjunk:1; V03:K0:xpfLY+SdAms=:O8IAWir5NvTSlUDoXRpgr+ en6y5E06+Fu/l/K65sJ8Lwp2hcOFJhIGMZBluQ+DfLdfIkq+GYxjnbtsBAekJyLq3uHZOAT9O XL7P+nWR/OZny1ToU5u/SX6k/x9aMU62Hk2PsSXxQoy2Mq9fk6rDsajFf+gZJNS31MwshO0Bv pu7BQtoK/XJxoY35vqM5cWgeavkcaPTRa4kt571ffNL92hiuOWSUw86MTzJeBOPiJThgDFARV NAGpHQK+FuH53E4XrDOMDh92u/5d7FO9LzEwVbuWLWR2W3/CwWTXOzVwQJBmG2oIL4Hx0U52W KjGz9ceezipZ6B9pKHkFzEZVhvV9hbokB7UTN57aIfLJZHSpWnk2gm1m0AJ8lG2JAd0Kr6/mH K3YVHTpsua0nwaFq7YikKRHET89eXILHvEAtEvqgH6q6JA6P9OUU/1YHuvHp8DG4abxADfwB2 NJKRM1dU1OL5PB9z0TJuOm3gMb9C/6mghYpiXwu/+4MXzLqz4yrNdxhLzR+Dcps6LSYi2AQXn /RtdlS4/UiJwr0SfDLakxEgUGTrqEqxm1uMT0Z3TFFxtiQLnggPt+Wj8fG+bBld0fIS3jyN56 7z0gIh60Q+4RTkqvUkJoUfGH5adApcPVJpdJFupc384bNW8LARIRKsgCHdEAOpApq4XqEgJ+e SylsbZK505U5WWNIOLdSKetGJ0rRIuxAnb2TphQETmEhtGLxZWXiSoX1YMnz5yfzgxGdKCB5y MKvKJ0kq0jQQBsfatV+ZKyXLBvWNVemUcuNZqA== X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.187 Subject: [Qemu-devel] [PULL v2 02/12] CODING_STYLE: specify the indent rule for multiline code X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Wei Yang , Gerd Hoffmann , Igor Mammedov , Paolo Bonzini , Stefano Garzarella , =?utf-8?q?Andreas_F=C3=A4rb?= =?utf-8?q?er?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Wei Yang We didn't specify the indent rule for multiline code here, which may mislead users. And in current code, the code use various styles. Add this rule in CODING_STYLE to make sure this is clear to every one. Signed-off-by: Wei Yang Suggested-by: Igor Mammedov Reviewed-by: Igor Mammedov Reviewed-by: Stefano Garzarella Message-Id: <20190304071631.27567-2-richardw.yang@linux.intel.com> Signed-off-by: Laurent Vivier --- CODING_STYLE | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/CODING_STYLE b/CODING_STYLE index ec075dedc4a8..90321e9c2821 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -29,6 +29,45 @@ Spaces of course are superior to tabs because: Do not leave whitespace dangling off the ends of lines. +1.1 Multiline Indent + +There are several places where indent is necessary: + + - if/else + - while/for + - function definition & call + +When breaking up a long line to fit within line width, we need a proper indent +for the following lines. + +In case of if/else, while/for, align the secondary lines just after the +opening parenthesis of the first. + +For example: + + if (a == 1 && + b == 2) { + + while (a == 1 && + b == 2) { + +In case of function, there are several variants: + + * 4 spaces indent from the beginning + * align the secondary lines just after the opening parenthesis of the + first + +For example: + + do_something(x, y, + z); + + do_something(x, y, + z); + + do_something(x, do_another(y, + z)); + 2. Line width Lines should be 80 characters; try not to make them longer. From patchwork Fri May 3 11:18:23 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1094823 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44wV7W1lgJz9s4V for ; Fri, 3 May 2019 21:21:11 +1000 (AEST) Received: from localhost ([127.0.0.1]:38323 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWFZ-0000Ff-3k for incoming@patchwork.ozlabs.org; Fri, 03 May 2019 07:21:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWDv-00085r-FK for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWDu-0001Am-Ht for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:27 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:40219) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWDu-00019Q-8x; Fri, 03 May 2019 07:19:26 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1M8C8J-1hRl140LeF-005LgM; Fri, 03 May 2019 13:19:01 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:18:23 +0200 Message-Id: <20190503111832.30316-4-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503111832.30316-1-laurent@vivier.eu> References: <20190503111832.30316-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:r+Vs6CZi8JNSFr8YokVIJ911RTcHv7fk6gLBqkk4BiIkk0vPIv/ mYR7ejTgx0HvCDNHZ+QwH5uUenYpyzUk8DtnaewHB4MSr2V9IcoeHNtCUnOnpodFIDnpAcX NOErDHKNHS5kGTl7YcQc82uqj+P58pF5Ok4TfqQ1a2tom9fuNTAWuUZLA5AmWAV9CdiR6uJ OxjczUFGJFB7Nhd801n8A== X-UI-Out-Filterresults: notjunk:1; V03:K0:zM+h+jotzoA=:ajt76nf5ZJpNMR5fH3HiEy 020n9ugWQ2TVITlQpm37Wy68gDZ1wsQ7fxxd7KgDKa7ocrXrlIkfrHT/CCZyJEWS8WrqoOx69 DFGJRgmywtED+JfUaa4v3F7xOgRI6Ef+5RVesr1rhysfQKbG6IboI43m/oxjFiay4oheKxcA4 3wZdYnVGrNj6ycAZFXBdK82eDXkV4A3tYQdBNTHOyoBQSPcDA0m0XWUxfGhUYTxDSVwfLTHE7 nDVYYdcuEWsagw30aAMQwcbscq4TMm6JpRIClAtl+F1jvZdEMQc0640ra/7OqzeYQwLWIzr55 zrcI5v3ILsRbomqOSD/aumnqbdjhwWeB7bGXbyikhqRgfDtMxqT+E6L0XyTV+oSxJAzhMBaZ9 vRkYeEvBzq/1JKMN5na5DxLpAjS9x8H3mDpV7jrfwALJsQD8m9gG/Sys2Ct/QaxkBsbwbrtuA Y863va83QAHQt85IWBUpQQGPGjz1F5EhRWs5IkyUcB9R/pPn6s7BzqcqaWGlbOXJsTV4GWZUj Ou3Gx7ETeofKzgQNyAvJVmHm8rzju082XYxciHth/XAlzCC6TnK8uJPTSBiOFsGZYULXhxqBU Xs0tohtHA/ieXf4ck2xJ1zq6fqpBij9CTBGaktP9pANhnfOCNyl2lW0nfGmnTmvWPPxEO/1az A8zI9icavVfpq8awdrX8jaZEREbIUD8vorunmsE3palp0eqLi4ssYVT0fszRbi8sqtuqVGXkq U85BeS3qqR3kEDQxInraYa8sof3AOMyNsvr4+NqvbtFB2QPFVwJJIiP0OUQ= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.134 Subject: [Qemu-devel] [PULL v2 03/12] CODING_STYLE: indent example code as all others X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Wei Yang , Gerd Hoffmann , Igor Mammedov , Paolo Bonzini , Stefano Garzarella , =?utf-8?q?Andreas_F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Wei Yang All the example code are indented with four spaces except this one. Fix this by adding four spaces here. Signed-off-by: Wei Yang Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov Reviewed-by: Stefano Garzarella Message-Id: <20190304071631.27567-3-richardw.yang@linux.intel.com> Signed-off-by: Laurent Vivier --- CODING_STYLE | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index 90321e9c2821..cb8edcbb3692 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -147,10 +147,10 @@ block to a separate function altogether. When comparing a variable for (in)equality with a constant, list the constant on the right, as in: -if (a == 1) { - /* Reads like: "If a equals 1" */ - do_something(); -} + if (a == 1) { + /* Reads like: "If a equals 1" */ + do_something(); + } Rationale: Yoda conditions (as in 'if (1 == a)') are awkward to read. Besides, good compilers already warn users when '==' is mis-typed as '=', From patchwork Fri May 3 11:18:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1094829 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44wVFL68k8z9s3Z for ; Fri, 3 May 2019 21:26:14 +1000 (AEST) Received: from localhost ([127.0.0.1]:38430 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWKS-0005ca-Pw for incoming@patchwork.ozlabs.org; Fri, 03 May 2019 07:26:12 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59534) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWE7-0008Ew-1W for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWE5-0001Mi-Qq for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:39 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:33711) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWE5-0001LU-I0; Fri, 03 May 2019 07:19:37 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MpTpc-1gxLwI16Zo-00pvpR; Fri, 03 May 2019 13:19:02 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:18:24 +0200 Message-Id: <20190503111832.30316-5-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503111832.30316-1-laurent@vivier.eu> References: <20190503111832.30316-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:kQidRAwX+nEUtN5LjRA4H/Hdt+9usEawtxJdIRgViv3F0CKj1JB vinfpS7A4P8c5DOIBbh+rV8G2cTP4J74P20+DzcLmOB09QcB39PBFKzO4vtTkuGGiEEznVD kgwVQnJwZfy1/U8W7xam9XP/RvRyE6zUYql1VkT9wcxG9F5GsTd3iELYSCkx++Dcddq37uD gdDfGFOw64p6he8fssirg== X-UI-Out-Filterresults: notjunk:1; V03:K0:X9nH/tQuPGs=:C1LL8LnFT8MkNILgqiwUXN W7DNYRebgYdCDJtGQS11r5vOSdk3sukkOiuDcKuCBV213lZPuqWUDxP5n0oGO849Zq5QwlbD5 rtxUzxCznqARyLegKq3TBP6s1CZm3kMGNCJhpJr9hGh2rpsMUgWAjoq2LcHUCLckqTY1XvhEN I9TDg7L7XiWAVWuIl5SxLSn2k2DNIUWyZL/tHgBsP3rDPeWpTVm6XMiycgSFvoo11bhlwsDi3 9/tiCYtWD/yHAxPOMxzKfE6ngOz0sJaSffd2UWw2i/jTu4i+A7d2HvTKdd1f95nA0gPGE2JWl mgTNk0HR49U/PSQHVqnq2JYhdrMSwkPz8oxAj46qeyZJwHy5P7E6sfOZF64670L5UPRA23Bs9 jdjsy5QpI3fffl7DifYYr+AhyCwBpSVqwVr/Ev2rZIWhlDTDiuEhH7f6b98FspJP2JFPT0Pn/ 8AOcBSaoN9IBRbv4bu+fIA/ZWr350VUOf3ZoHiERadZ0CnRpR6rTCFJ18N+DLpFKFM69v5tDd 2U0ADVjXNXvCakCS6hXrgp1/SNcINwyC/d3jMt46l8LaXeLELsRy9EDXnuyQ/itcf3x2rdQir cqUgcnE+LPZFodISnNpGlbx554adys6RUUTIak96vR+NMmtVfjXwp0SqeomIVCH7cVyig57xn ZjArBDwEfQM7NWRwFByIjvmugW+AMyoP4FhA+LAYVR9ZCyntxSwHqa7kC2w8LeDqbMXa5IZ1Z Gp8Ni2XjGbscEBW72U5r3o+77CxVkMkMam5q9HTbnWzILsCpVx+kw2jiask= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.130 Subject: [Qemu-devel] [PULL v2 04/12] doc: fix the configuration path X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Gerd Hoffmann , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= , =?utf-8?q?Andreas_F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Marc-André Lureau Use a CONFDIR variable to show the configured sysconf path in the generated documentations (html, man pages etc). Related to: https://bugzilla.redhat.com/show_bug.cgi?id=1644985 Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20181126105125.30973-1-marcandre.lureau@redhat.com> Signed-off-by: Laurent Vivier --- qemu-ga.texi | 4 ++-- Makefile | 9 ++++++--- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/qemu-ga.texi b/qemu-ga.texi index 4c7a8fd16329..f00ad830f283 100644 --- a/qemu-ga.texi +++ b/qemu-ga.texi @@ -30,7 +30,7 @@ set user's password @end itemize qemu-ga will read a system configuration file on startup (located at -@file{/etc/qemu/qemu-ga.conf} by default), then parse remaining +@file{@value{CONFDIR}/qemu-ga.conf} by default), then parse remaining configuration options on the command line. For the same key, the last option wins, but the lists accumulate (see below for configuration file format). @@ -58,7 +58,7 @@ file format). Enable fsfreeze hook. Accepts an optional argument that specifies script to run on freeze/thaw. Script will be called with 'freeze'/'thaw' arguments accordingly (default is - @samp{/etc/qemu/fsfreeze-hook}). If using -F with an argument, do + @samp{@value{CONFDIR}/fsfreeze-hook}). If using -F with an argument, do not follow -F with a space (for example: @samp{-F/var/run/fsfreezehook.sh}). diff --git a/Makefile b/Makefile index 1211e78c91ed..43a7a047b452 100644 --- a/Makefile +++ b/Makefile @@ -899,11 +899,14 @@ ui/shader.o: $(SRC_PATH)/ui/shader.c \ MAKEINFO=makeinfo MAKEINFOINCLUDES= -I docs -I $( $@,"GEN","$@") +docs/version.texi: $(SRC_PATH)/VERSION config-host.mak + $(call quiet-command,(\ + echo "@set VERSION $(VERSION)" && \ + echo "@set CONFDIR $(qemu_confdir)" \ + )> $@,"GEN","$@") %.html: %.texi docs/version.texi $(call quiet-command,LC_ALL=C $(MAKEINFO) $(MAKEINFOFLAGS) --no-headers \ From patchwork Fri May 3 11:18:25 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1094828 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44wVDz41DDz9s3Z for ; Fri, 3 May 2019 21:25:55 +1000 (AEST) Received: from localhost ([127.0.0.1]:38413 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWK9-0005CQ-GU for incoming@patchwork.ozlabs.org; Fri, 03 May 2019 07:25:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59483) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWE4-0008EK-67 for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWE3-0001Jg-2l for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:36 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:49809) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWE2-0001Io-QV; Fri, 03 May 2019 07:19:35 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mo6WJ-1gzGoe21BT-00peqc; Fri, 03 May 2019 13:19:03 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:18:25 +0200 Message-Id: <20190503111832.30316-6-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503111832.30316-1-laurent@vivier.eu> References: <20190503111832.30316-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:iGmdPUQUTj8h+34X1/avXpDnQRJt+Kp/Kcvqoqjl7pymBOJ2KBw 5E03V0Op9rjfnlXg/BQ2pbnhwsrcyTf6HvDyWhoL7nGhTcpBVYnE5hktPEJOfa/X6XLCMmP v0Uw8HiZ7cXrsxWtq7e0//eI6RrqXyEk95SD0H+xQTM/NIHUqjt5jqL4VPdQtCq7Kqjf8a7 DnJ9QQxh6rWB40VaLtjmQ== X-UI-Out-Filterresults: notjunk:1; V03:K0:zB4Bfg6m6ZM=:G6RQtJFn911Gq0JKSi+ZjK r3GcKMlQEa+nBdCyGryBsA0DmGQOF7kOK+AD4ywP/MB8CdBTYwm0Vf7lFL8jjv36FaJavCYks IgpIGZxPmDvCPcMHEhO/VZC2s+ckC5vWH8Gd0Da79ufDmst5L5YzeZaEdWrHy53RD20RGCe4J ej52s/UK/dMceQhUJvJ/RKZ0/ZRCSekClAZhUFeXcYoZmZIx79B+WRSma8UNyMmBdJlWEXLVz a79b7OG1qit1X//kxyNR/F15IvwzU8mSxf5PU08ENlHw2foqFBHDbgUm76pSmfCUfW8gmN5wK Owz+td7ZYbg5lrHAUeJvMaxh5VlFfugnJcUfliryVsvqtq41cIm3Qa3amVQyYonsjyaRkFTyR hTlRgTNXsk7ykKS17Bgf4lNprJamTlYeZqaI6H/ULijcJEJHNChIAUTB5PYg0WiJIuf+tEoby o1/5S8nkZDE+GjLEdsNOBZeNYig5X16ByQN8Xabokoz19MpiBHe1Q2zK1/Ej6TO1iEzdTL+R4 a7tDdA2F53G7WoEzT2X/oEI2W+uzBM032tJFQl+Yns5cCoxYpFBHJS8U0505f0rdgN2LLDkjt +LRaT+Iy+DMMnHaGYwg1w+PmSlDKXku/4YokMT+gmGu1R7tsDumCkHWiD31WeQY+tWFmb97Kg vO3LIYYoRZPdxmvdQLogmwm7eoWsJsCZH1P8LS3m5M5mycnHck4DsotWyB/Q0SptSS7MnkR6R 0UbBDDTpQFjlqSZesHdZySCfqsPOWCz4rOy+tGkVOFpjSa3xZ2dA4WEpUI4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.135 Subject: [Qemu-devel] [PULL v2 05/12] qom: use object_new_with_type in object_new_with_propv X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Wei Yang , Gerd Hoffmann , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , Stefano Garzarella , =?utf-8?q?Andreas_F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Wei Yang Function object_new_with_propv already get the Type of the object, so we could leverage object_new_with_type here. Signed-off-by: Wei Yang Reviewed-by: Marc-André Lureau Reviewed-by: Stefano Garzarella Message-Id: <20190311083234.20841-1-richardw.yang@linux.intel.com> Signed-off-by: Laurent Vivier --- qom/object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qom/object.c b/qom/object.c index e3206d6799ee..d3412e7fdca6 100644 --- a/qom/object.c +++ b/qom/object.c @@ -679,7 +679,7 @@ Object *object_new_with_propv(const char *typename, error_setg(errp, "object type '%s' is abstract", typename); return NULL; } - obj = object_new(typename); + obj = object_new_with_type(klass->type); if (object_set_propv(obj, &local_err, vargs) < 0) { goto error; From patchwork Fri May 3 11:18:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1094827 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44wVBk13fqz9s7T for ; Fri, 3 May 2019 21:23:58 +1000 (AEST) Received: from localhost ([127.0.0.1]:38376 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWIF-0002nT-VL for incoming@patchwork.ozlabs.org; Fri, 03 May 2019 07:23:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWE6-0008Ef-Ny for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWE5-0001MQ-J1 for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:38 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:44665) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWE5-0001L8-9E; Fri, 03 May 2019 07:19:37 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1Mt8cD-1gU0if2kXZ-00tSSq; Fri, 03 May 2019 13:19:04 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:18:26 +0200 Message-Id: <20190503111832.30316-7-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503111832.30316-1-laurent@vivier.eu> References: <20190503111832.30316-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:/giShaB3q6BMKEIJ47bzB6xzi03fHl0BlHkOGMzhH0r9PGQ47hB XnPw3K4OJdg1QGaxH8z8ziqKVpRfIF8y6zfR3iFN7UVhWX1ZQyTsmKvgyEjqNP7lp4UpPtp gSXUDRJYbuWLk7Edy2mRwSOcXAMOO0wWrYK0nAUNkjwr9hLr573VQiT9EBDIW7I7F9H6RMX Ue7/klX2cvd1aEg+++w+Q== X-UI-Out-Filterresults: notjunk:1; V03:K0:TCZFDqBeCW0=:dyIoieh8JqKGlJq1fyQLx8 jvt63rayJMaP7KZqO45jAogpix+6BCkFy7b0WwyCx2EBGsTmw++4IHdGCLDXVrB9Afqix5+3R ou+Yiye42IqyXow1o2gBWWGyfhaAy8qppG7q/0DQpJ8TuoBfOB7eA45+q/ztWrH+1BFeg+Obu kP4Cr85vDimXT3UdnCfcbx0501XPm8b2nUWWaw3ddao9YF9Q2NojNFYtcdx52a7hSaEcE7iZ3 gOJ/CRmj6tIk+0DfGCXfXo76GiHz1mjulMEUmzQkGMFsz2+mkhk9QZqkZ269p+D96fxotLVOX wdJRM4arWtRHBqgNN0Ax1bzW/QulLAozw7z0AH5xTFZGC32uCd971Jrq+hWSdXCIpw9iy6nV7 s7cRE3sT+1G6POe1D24t/yywhUW5DH5aQNysWIEdqT1k/ZS+dncoWq61Ep6SjU1od6PydfzEn Gc5Y1ba79B9VOt7xAt8KMsaDfZq8Nd/DSrtNW1HKb7D+3pgglGQFbwt1GqKdMXH5sNf8ZjBIO ojGtrGG+ub8bpp5zE01pBo8eE8xX6OaTlirZjduceZPgwETsI+sDrwF8Rc0myXHTv6UWlfCyR 7j52CWVjQZ6xCSoMk4JlHoHZ47c0P9pt5W+DFeick0bPEJlvqmNjygmmoY/yzj3SYjs1nebEM 6hjsFOeo8BUwP7HtGoiiPpXmP904jqt/5g2MLTT8v2lnz2DXpSIutdXZO4KUIUYfm5nzRTVxd uyWl76ZQWBtSKgr8N4BNCXL8SDapKFnC9ZaIW/MzJTQV+ta1KvDrOM3XR50= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.133 Subject: [Qemu-devel] [PULL v2 06/12] configure: fix pam test warning X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Dr. David Alan Gilbert" , qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Gerd Hoffmann , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= , =?utf-8?q?Andreas_F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: "Dr. David Alan Gilbert" The pam test generates a warning on Fedora 29 with -O3 compilation because the headers declare that the pam_conversation pointer to pam_start must be non-NULL. Change it to use the same 0 initialised structure as we actually use in qauthz. Signed-off-by: Dr. David Alan Gilbert Acked-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190404091725.20595-1-dgilbert@redhat.com> Signed-off-by: Laurent Vivier --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 60719ddcc5b0..a2607afb3408 100755 --- a/configure +++ b/configure @@ -2940,9 +2940,9 @@ if test "$auth_pam" != "no"; then int main(void) { const char *service_name = "qemu"; const char *user = "frank"; - const struct pam_conv *pam_conv = NULL; + const struct pam_conv pam_conv = { 0 }; pam_handle_t *pamh = NULL; - pam_start(service_name, user, pam_conv, &pamh); + pam_start(service_name, user, &pam_conv, &pamh); return 0; } EOF From patchwork Fri May 3 11:18:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Vivier X-Patchwork-Id: 1094826 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=vivier.eu Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44wVB20Cjzz9s7T for ; Fri, 3 May 2019 21:23:22 +1000 (AEST) Received: from localhost ([127.0.0.1]:38369 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWHf-0002Jr-Qt for incoming@patchwork.ozlabs.org; Fri, 03 May 2019 07:23:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hMWE6-0008EN-EL for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hMWE5-0001MW-Jb for qemu-devel@nongnu.org; Fri, 03 May 2019 07:19:38 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:60817) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hMWE5-0001LK-AE; Fri, 03 May 2019 07:19:37 -0400 Received: from localhost.localdomain ([78.238.229.36]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.167]) with ESMTPSA (Nemesis) id 1MZjQl-1hHtfC3vi3-00Wjt4; Fri, 03 May 2019 13:19:06 +0200 From: Laurent Vivier To: qemu-devel@nongnu.org Date: Fri, 3 May 2019 13:18:27 +0200 Message-Id: <20190503111832.30316-8-laurent@vivier.eu> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190503111832.30316-1-laurent@vivier.eu> References: <20190503111832.30316-1-laurent@vivier.eu> MIME-Version: 1.0 X-Provags-ID: V03:K1:jE/Twybj5oWwxyCk6VfpUuQg9Q+gLYWpj8WFHjv/HsSDnH6mW3N Ij7iieZi3ecMeIbxeFxi9+Dr+eborEwIJBvQhUpWyei/ZNwMt8RLK+ZJHSrlhnfa27Mvl9X qfLCUjkSgJcts/4CyfyfaufCLm9b6FFDEssENWtaZBrK43PH/byaid5o7+EGOuQqESBjeEy VTHrGdVsQvE8csyHLZIYw== X-UI-Out-Filterresults: notjunk:1; V03:K0:3h4rEd7zUG4=://NE6e3tqs19ubXB/McQ6t FNf9YKU6l93EEaour5jCBPs2r6WXpCnv9CGqs6dmDvBfkTCmBjBGyKv5/hf9nvTxSNqIypzk9 zd1F5UXv7pLdRsMwA9AX89uWX9YcZmIeDDHS1oCyB7DqkuAy3HkG4TE9AamHvgQz98/DcrZEy 9HeKNDGyp/T8YZ6OaL73U/uyVMAMS6JWuy03SfEjfLQ52XFqZQnfLN0dic/rbviB/tSTaWtd6 9tdhqW1DSoet5b3S53CxDLaaAqKKSzKi2ihsDfSS2pcUX9J5eSfH5xquJrSvLvpOhSVw2k/DJ Uoy0t4PCLuQ+lA7fTTnryElwKPD0+kyRm3LMVSESW4GPNjiFB/BmhV8BrXNlFpYN3biAMdUXs HMlfsyIq/PeShrbEBcMPdzhtYNoTaAAGHuim0Kh61lz3ynSGSeMAEmkUnxX+UU2doWGH4s27H Lp1Kin3fI8wA97YJCXa7PcwubttxC6wwpygEGjAhUZAkHm9BHSsnR9ivrZIsOfuge9RG2TJWL 1bn1FjY+FBsAGX4kNJdxVUljWHmcM3TWhqFShi5gCMX8J/+wYbkL1e0t/vbAQvuykNyTJ5fko LIHNdO9Pf9GWjwTTc6kJogX88GVTiDGsqMLQk3X0u+MmuJjJHR1ni9JmY80K+MoBCOBwOqmrG qIj4ikd8EVzPBwnZyN7w/ua4SHjm9sGBwrRz9/66+luKp8rnNnbnakRgB4sbk9kWXwFh0IkM8 oNDgsb0DU5fTL4y9rndMHx0ozuFlWrVtrMOyoalsvyF+4NvZXIPS3uk9GHY= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.126.187 Subject: [Qemu-devel] [PULL v2 07/12] Update configure X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mammedov , qemu-trivial@nongnu.org, Mark Cave-Ayland , Jason Wang , Michael Tokarev , Laurent Vivier , Fabien Chouteau , Michael Roth , Gerd Hoffmann , Stefan Weil , Paolo Bonzini , =?utf-8?q?Philippe_Mathieu-Daud?= =?utf-8?b?w6k=?= , =?utf-8?q?Andreas_F=C3=A4rber?= , Artyom Tarasenko , Richard Henderson Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Stefan Weil The last *.aml file was removed in commit 13b1881aacc7e5018773bd545bbaf8d5476699ee. Signed-off-by: Stefan Weil Reviewed-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20190409053320.14612-1-sw@weilnetz.de> Signed-off-by: Laurent Vivier --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index a2607afb3408..14f02452f9d4 100755 --- a/configure +++ b/configure @@ -7880,7 +7880,6 @@ LINKS="$LINKS python" for bios_file in \ $source_path/pc-bios/*.bin \ $source_path/pc-bios/*.lid \ - $source_path/pc-bios/*.aml \ $source_path/pc-bios/*.rom \ $source_path/pc-bios/*.dtb \ $source_path/pc-bios/*.img \