From patchwork Thu Oct 24 19:22:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: David Thompson X-Patchwork-Id: 2001910 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4XZG5j36Y0z1xw8 for ; Fri, 25 Oct 2024 06:22:49 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1t43Pu-00059g-7o; Thu, 24 Oct 2024 19:22:42 +0000 Received: from mail-mw2nam10on2074.outbound.protection.outlook.com ([40.107.94.74] helo=NAM10-MW2-obe.outbound.protection.outlook.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1t43Pr-00056M-Pt for kernel-team@lists.ubuntu.com; Thu, 24 Oct 2024 19:22:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FGFJ5J5JvKRPQfC7E9jB2Wr7HYtkNLzaltIEfGCxYm2c21krkXqHveYc/nDZHqk+aDIbjZYQDwejHZvOIzP9WnppNOhhAaaFglDpIgOWA9a6OiEv4KbPv1xhBqSyshpktjvCxf3GUMrSzWx/YxwpTm481z3cfQWixdqcCBoXWLq4lyATj2XQTm/gziIIUNVgTVcq8TIgVn4UHLW/Dyen7PVvo05BgNuZWydo/noHwI7e3UVRZUjx3D2iDFBFd/UDRyncPCBDFikxHQVF7ldXl78i5YrJuAXY6pq6tftNFWAxhJEkvk8HIC/WMJzkLYOHTRNTChrSJRZSL7GpIfNx2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7s1VqdKC8/voDmh9dlkEcavaZHC6s7kOYudY9a/amEg=; b=t4iGk6JRBsALIXZnCTUhcWmXO8ENs6Kvi2lQRUbzSvbnNnmih2+lmZW3EeCqK1YL9DU0uI8KUHuTpQECHey8qh/3EVx7/THXRzPVj3q6pFAkMxvZUd9ur+RIUkAvoNaoaDbaqPodYFdzdqn7s56sR8T0ibQeO6WsbKAL3PmkfBcijpSrTLPcdf2l9jTDQIwcG89Xl9uSMVZBmrtw4IclUcz7X76S2eQYtqdTLu2NwUGBU57Sgz1n0+L2ZJXxHHqUd5wSKK9chpz0NyuNS+YXAG0GompZ556dn12PaVzIMoOaFH3Ex/mktnZ+fl6AaayMEQk3MMesGW8woHj3pgN8qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=lists.ubuntu.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) Received: from CH2PR18CA0044.namprd18.prod.outlook.com (2603:10b6:610:55::24) by IA1PR12MB7567.namprd12.prod.outlook.com (2603:10b6:208:42d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.28; Thu, 24 Oct 2024 19:22:34 +0000 Received: from CH1PEPF0000AD83.namprd04.prod.outlook.com (2603:10b6:610:55:cafe::82) by CH2PR18CA0044.outlook.office365.com (2603:10b6:610:55::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.18 via Frontend Transport; Thu, 24 Oct 2024 19:22:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by CH1PEPF0000AD83.mail.protection.outlook.com (10.167.244.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8093.14 via Frontend Transport; Thu, 24 Oct 2024 19:22:34 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 24 Oct 2024 12:22:26 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 24 Oct 2024 12:22:26 -0700 Received: from vdi.nvidia.com (10.127.8.14) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Thu, 24 Oct 2024 12:22:26 -0700 From: David Thompson To: , Subject: [SRU][J:linux-bluefield][PATCH v2 4/6] EDAC/bluefield: Convert to platform remove callback returning void Date: Thu, 24 Oct 2024 15:22:20 -0400 Message-ID: <830edc40fd88cd33228159ca2c4595168f98268f.1729797209.git.davthompson@nvidia.com> X-Mailer: git-send-email 2.30.1 In-Reply-To: References: MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH1PEPF0000AD83:EE_|IA1PR12MB7567:EE_ X-MS-Office365-Filtering-Correlation-Id: a390c1de-c4ae-4853-7608-08dcf4613698 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|82310400026|36860700013|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?q?WWt3hjNsY9IvDLPgkAD+RfUHWK45ulc?= =?utf-8?q?cFVQMuA+mUW90gOLEkiXbqOmDJuMTOCeOczmpUAtFHZD1AdoLhuUkZi5t5xXfMENj?= =?utf-8?q?6EVS5tuW18eVCsoezJ6y44HJLxiyis3Sqx2cMtscYd1f17PZLlwCmY7/tmBlkuYm4?= =?utf-8?q?+OrdwB8FL0iw+xy3K95OPtCdY5gphoiayK1rcA/gHXq5eAXr8JOa8vfcG09FzJLsW?= =?utf-8?q?WPGfT22i8PPEHYKb1fFnGG177ajx84cDrn97G5lt9msLH/23OhwaE5ismgZ6pI/Pf?= =?utf-8?q?fggnXCnIG7k7EUQmSDxeq7lfqm9eSLQ8qhqxlUPbZC7NsnUOIcYlKBg14U6L0reGE?= =?utf-8?q?z4ZWkF2oNiFyWvrN2HNFBkxrXVUDmdrWCWc50/vV7IhTcbVjb+zLS8zWI/7LJzUJB?= =?utf-8?q?3zzhJSaefMA2nTVGvlfYBBfCU1UaYZ5q0jEjsPInFOfC3MIIW5gmEGo5Cvv5u2ILG?= =?utf-8?q?5eowQ0xY+X/e9SVoVCAqfRVIFTbafNbunh+5Gzc+YZnKxuE55cOua8c0r5HkkUjKo?= =?utf-8?q?hz/54yD2wtihKy6kAXgIjv/wlT0WxGigjfB8jUiOz9PM2lJYEpUcc1pW0DCEAjdQy?= =?utf-8?q?wzChW18v8ChztWZ3MqMKGu7o7F6fTmHh9RHgIWzmnro+vdVgyN4TqAa8Q1RhOZ7KI?= =?utf-8?q?oRKFcKZvvkuM2slL+gphwerFkKFaFpoVcal8h5BF9iYZpK3B3UvstMDucw/kD+LZK?= =?utf-8?q?9bf1CN2AWwOlYo+8PqRoEYSR0Kdcn1N127j2fOb/YUmHsPApHAl5v4NIw7V0TwRTu?= =?utf-8?q?c7GwOhD8durO9C964bujPrc4jLcdgJlRV0lGnSLG24iPoea70F3zVeo+4tN2pXZ5F?= =?utf-8?q?nOJ6EJzWZulpu3hwSFukSCiz/PkPgDFCiQJ9YStuS3cEv1phzxoXnATSH6HuKYM5r?= =?utf-8?q?lndi8kq+ozxLTpNj9qYxMr/5yzPOTSuCCqXAW+s7RmdFCPFPkWtrsBV2E/MQIdkxU?= =?utf-8?q?06AfJL/M4YrJz1N74xA/9AOdbWdWkYfznRMAWa/0XNfKzVvLvALr7gdRKHIvb6tvI?= =?utf-8?q?NOae7eksfH3T7Dh0b2STaLLb+Hqu7B1Jo1p2zKwSZpFWtLfrr1Mv7Frz4whUs6mkf?= =?utf-8?q?Ro9SVxeE5B8PwlvSYklWPwfm4f22SZld7dF7G4w62rDmg0bcmmF7+lnAd6hlOvBKK?= =?utf-8?q?g7rHChI+o0UkK80JQYeaeUujostQvRW7AyxqsdRkVBn4oajuPW7jCp6lJFrkKYTKp?= =?utf-8?q?KUX4IqZ+lVymzl4atUEj5mCQrDyPq4A1+Yke59DMdObMp9YDRaRme8xbjcIhXGHHm?= =?utf-8?q?N9UvUZG4Jrz2zGfD2i4hDa6fsHUx+fDqGEJGgV88sJvrmUVY6s2FpETY0hTtF3jOB?= =?utf-8?q?Sv8GYjexHlW56ZKaWJXL4ajWhFr0Fh2F6A=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(82310400026)(36860700013)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2024 19:22:34.3484 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a390c1de-c4ae-4853-7608-08dcf4613698 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH1PEPF0000AD83.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7567 Received-SPF: softfail client-ip=40.107.94.74; envelope-from=davthompson@nvidia.com; helo=NAM10-MW2-obe.outbound.protection.outlook.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: shravankr@nvidia.com Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Uwe Kleine-König BugLink: https://bugs.launchpad.net/bugs/2085561 The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Signed-off-by: Borislav Petkov (AMD) Link: https://lore.kernel.org/r/20231004131254.2673842-5-u.kleine-koenig@pengutronix.de (cherry picked from commit a5347591eb6fa1263bb0902714c3c8f07dd4748b) Signed-off-by: David Thompson --- drivers/edac/bluefield_edac.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/edac/bluefield_edac.c b/drivers/edac/bluefield_edac.c index e4736eb37bfb..5b3164560648 100644 --- a/drivers/edac/bluefield_edac.c +++ b/drivers/edac/bluefield_edac.c @@ -323,14 +323,12 @@ static int bluefield_edac_mc_probe(struct platform_device *pdev) } -static int bluefield_edac_mc_remove(struct platform_device *pdev) +static void bluefield_edac_mc_remove(struct platform_device *pdev) { struct mem_ctl_info *mci = platform_get_drvdata(pdev); edac_mc_del_mc(&pdev->dev); edac_mc_free(mci); - - return 0; } static const struct acpi_device_id bluefield_mc_acpi_ids[] = { @@ -346,7 +344,7 @@ static struct platform_driver bluefield_edac_mc_driver = { .acpi_match_table = bluefield_mc_acpi_ids, }, .probe = bluefield_edac_mc_probe, - .remove = bluefield_edac_mc_remove, + .remove_new = bluefield_edac_mc_remove, }; module_platform_driver(bluefield_edac_mc_driver);