From patchwork Sun Dec 1 18:31:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: You-Sheng Yang X-Patchwork-Id: 2016894 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Y1bB56DmSz1yR0 for ; Mon, 2 Dec 2024 05:32:29 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1tHok0-0007nc-CK; Sun, 01 Dec 2024 18:32:20 +0000 Received: from mail-pl1-f182.google.com ([209.85.214.182]) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1tHojy-0007ma-Sa for kernel-team@lists.ubuntu.com; Sun, 01 Dec 2024 18:32:19 +0000 Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-2156e078563so6265355ad.2 for ; Sun, 01 Dec 2024 10:32:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733077937; x=1733682737; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bVxZdAZ99XqeOKUaiI2X3eeCfbc6k3hzQZpZNMWW3f0=; b=aTPyWmuZLkvPrBS6xd+IBWysrOm+yq8buWniIr+OhFs3u9cYmSlZmvpQdL/b3GTCQw e5z0QYMLSBmKBhjb36y/za9ubtyPYwJAwTwjWvm+Z6ZwvX7k1GPMwVdl1SQcjNkGAIoT y2/mNZL/uJPiVumWu3fHGjzdf4P0Ih9qibMVZh5nytAM2MC4A4x3z2rzkN2gny8zB52R MMdguoKsj/SSpop39P+2JeGVkkVYpar7dWH6uF2Fu5rvDidFgQoaORkrf+VjljHwRvjM iOsakpfQ8ceI4fSzBRCy0Z7ao2Tj0jXN5s4IZAdpkOtgQh3HcSVpMbzeuJXKpae7HrI4 Ze7g== X-Gm-Message-State: AOJu0YwGxVH54CKt/83h7POrSz+YD3/+LTSFh8+u28LUnLcjjs8DwGAN Xr13TNKFUCdJlZ9q5WczgwsrBn7dZNgUvTPxoy2Nm4SlAzGUm9lRGVOdVA== X-Gm-Gg: ASbGncvb9CanZbHPVAr1/h/wqsKTKlDMqvrKdW9u4gg89f3F31caqpyStjKn5jcZg7c 6AmgKQy4Vc9agaB0AGPI1Y3wTNTmmAQr+aRqZEkcrlfNVUF3r/zatemXKWgmW2nxvbBvdiTF3jT EYTUBj9mWRLxK8/Qq8NH3079hIM/3AwSsnuov4NKZKBdlNykDLB9e1eGqpU+a/AM+G+FalGl7Jw oz9t12rp7P0yXJd8ulKePPRFw0b77wW0svMqpHrm+dq0v+Robbrj7GjllfJppXJoyUpld8cHYXD hmmmqblikxz4nsHWEqrrBRBiX/wLUIaLOveghS42IBA= X-Google-Smtp-Source: AGHT+IEXbZX+vvcLLOZXAS+ozZ1ST/+BXH6FeOv7R8np2EnreDNCsPUPvqsMU1DK0HJpe/XqaiLl6w== X-Received: by 2002:a17:902:da83:b0:20c:8f98:5dbe with SMTP id d9443c01a7336-21501856a01mr288977295ad.33.1733077936803; Sun, 01 Dec 2024 10:32:16 -0800 (PST) Received: from localhost.localdomain (125-229-129-140.hinet-ip.hinet.net. [125.229.129.140]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-215219cc590sm62301975ad.266.2024.12.01.10.32.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Dec 2024 10:32:16 -0800 (PST) From: You-Sheng Yang To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/4][Plucky] drm/amd/display: Re-enable panel replay feature Date: Mon, 2 Dec 2024 02:31:48 +0800 Message-ID: <20241201183151.108974-2-vicamo.yang@canonical.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241201183151.108974-1-vicamo.yang@canonical.com> References: <20241201183151.108974-1-vicamo.yang@canonical.com> MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.214.182; envelope-from=vicamo@gmail.com; helo=mail-pl1-f182.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: Tom Chung BugLink: https://bugs.launchpad.net/bugs/2089556 [Why & How] Fixed the replay issues and now re-enable the panel replay feature. Reported-by: Arthur Borsboom Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/3344 Reviewed-by: Sun peng Li Signed-off-by: Tom Chung Signed-off-by: Wayne Lin Tested-by: Daniel Wheeler Signed-off-by: Alex Deucher (cherry picked from commit be64336307a6c3ee71fe1337c1b9f0495aa83c50) Signed-off-by: You-Sheng Yang --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 20 ++++++++----------- 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 60aa6487f9895..e14bf373dc763 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -4880,18 +4880,14 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) /* Determine whether to enable Replay support by default. */ if (!(amdgpu_dc_debug_mask & DC_DISABLE_REPLAY)) { switch (amdgpu_ip_version(adev, DCE_HWIP, 0)) { -/* - * Disabled by default due to https://gitlab.freedesktop.org/drm/amd/-/issues/3344 - * case IP_VERSION(3, 1, 4): - * case IP_VERSION(3, 1, 5): - * case IP_VERSION(3, 1, 6): - * case IP_VERSION(3, 2, 0): - * case IP_VERSION(3, 2, 1): - * case IP_VERSION(3, 5, 0): - * case IP_VERSION(3, 5, 1): - * replay_feature_enabled = true; - * break; - */ + case IP_VERSION(3, 1, 4): + case IP_VERSION(3, 2, 0): + case IP_VERSION(3, 2, 1): + case IP_VERSION(3, 5, 0): + case IP_VERSION(3, 5, 1): + replay_feature_enabled = true; + break; + default: replay_feature_enabled = amdgpu_dc_feature_mask & DC_REPLAY_MASK; break;