[SRU,O/N,1/1] ALSA: hda/realtek: fix mute/micmute LEDs for a HP EliteBook 645 G10

From: Maksym Glubokiy <maxgl.kernel@gmail.com>

BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2087983

HP EliteBook 645 G10 uses ALC236 codec and need the
ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make mute LED and
micmute LED work.

Signed-off-by: Maksym Glubokiy <maxgl.kernel@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://patch.msgid.link/20241112154815.10888-1-maxgl.kernel@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
(cherry picked from commit 96409eeab8cdd394e03ec494ea9547edc27f7ab4)
Signed-off-by: Agathe Porte <agathe.porte@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

On 19.11.24 09:46, Agathe Porte wrote:
> From: Maksym Glubokiy <maxgl.kernel@gmail.com>
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2087983

For buglinks we should use the form

https://bugs.launchpad.net/bugs/<bugid>

We would change that when applying. Note, maybe you want to look at 
maint-modify-bug which can not only add s-o-b but also the BugLink.

-Stefan
> 
> HP EliteBook 645 G10 uses ALC236 codec and need the
> ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF quirk to make mute LED and
> micmute LED work.
> 
> Signed-off-by: Maksym Glubokiy <maxgl.kernel@gmail.com>
> Cc: <stable@vger.kernel.org>
> Link: https://patch.msgid.link/20241112154815.10888-1-maxgl.kernel@gmail.com
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> (cherry picked from commit 96409eeab8cdd394e03ec494ea9547edc27f7ab4)
> Signed-off-by: Agathe Porte <agathe.porte@canonical.com>
> ---
>   sound/pci/hda/patch_realtek.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 452c6e7c20e2..d473e8e4a1be 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10321,6 +10321,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>   	SND_PCI_QUIRK(0x103c, 0x8b59, "HP Elite mt645 G7 Mobile Thin Client U89", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>   	SND_PCI_QUIRK(0x103c, 0x8b5d, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>   	SND_PCI_QUIRK(0x103c, 0x8b5e, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
> +	SND_PCI_QUIRK(0x103c, 0x8b5f, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>   	SND_PCI_QUIRK(0x103c, 0x8b63, "HP Elite Dragonfly 13.5 inch G4", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
>   	SND_PCI_QUIRK(0x103c, 0x8b65, "HP ProBook 455 15.6 inch G10 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
>   	SND_PCI_QUIRK(0x103c, 0x8b66, "HP", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),

Hello,

On 19/11/2024 10:53, Stefan Bader wrote:
> On 19.11.24 09:46, Agathe Porte wrote:
>> From: Maksym Glubokiy <maxgl.kernel@gmail.com>
>>
>> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2087983
>
> For buglinks we should use the form
>
> https://bugs.launchpad.net/bugs/<bugid>

Yes, sorry about that. I did a manual copy/paste. I will resend with 
proper format.

>
> We would change that when applying. Note, maybe you want to look at 
> maint-modify-bug which can not only add s-o-b but also the BugLink.
The SoB is already handled by `git cherry-pick -sx`. I am unable to find 
the `maint-modify-bug` script in kteam-tools. Do you know where I can 
find it to use it to send v2?

Thanks.

On 19.11.24 11:23, Agathe Porte wrote:
> Hello,
> 
> On 19/11/2024 10:53, Stefan Bader wrote:
>> On 19.11.24 09:46, Agathe Porte wrote:
>>> From: Maksym Glubokiy <maxgl.kernel@gmail.com>
>>>
>>> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2087983
>>
>> For buglinks we should use the form
>>
>> https://bugs.launchpad.net/bugs/<bugid>
> 
> Yes, sorry about that. I did a manual copy/paste. I will resend with 
> proper format.
> 
>>
>> We would change that when applying. Note, maybe you want to look at 
>> maint-modify-bug which can not only add s-o-b but also the BugLink.
> The SoB is already handled by `git cherry-pick -sx`. I am unable to find 
> the `maint-modify-bug` script in kteam-tools. Do you know where I can 
> find it to use it to send v2?

Sorry, using tab-completion too much its "maintscripts/maint-modify-patch".
Did not intent to request it being sent again. We could adjust this when 
applying.

-Stefan
> 
> Thanks.