| Message ID | 20250322183812.784676-6-aford173@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Fabio Estevam |
| Headers | show |
| Series | Migrate IMX8, IMX8M and IMX9 to use imx8_cpu | expand |
On 3/22/25 7:38 PM, Adam Ford wrote: > The imx8_cpu driver is a CPU Driver that supports the i.MX8Q > family. When it is enabled, it acts as an alternative to > arch/arm/mach-imx/cpu.c, but the imx8_cpu supports the driver > model where cpu.c does not. Imply this newer driver by default. > > Signed-off-by: Adam Ford <aford173@gmail.com> > --- > arch/arm/mach-imx/imx8/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig > index 9a43beda6fa..257c14e61b6 100644 > --- a/arch/arm/mach-imx/imx8/Kconfig > +++ b/arch/arm/mach-imx/imx8/Kconfig > @@ -9,6 +9,8 @@ config AHAB_BOOT > config IMX8 > bool > select HAS_CAAM > + imply CPU > + imply CPU_IMX Shouldn't CPU_IMX select CPU ?
On Sat, Mar 22, 2025 at 6:31 PM Marek Vasut <marek.vasut@mailbox.org> wrote: > > On 3/22/25 7:38 PM, Adam Ford wrote: > > The imx8_cpu driver is a CPU Driver that supports the i.MX8Q > > family. When it is enabled, it acts as an alternative to > > arch/arm/mach-imx/cpu.c, but the imx8_cpu supports the driver > > model where cpu.c does not. Imply this newer driver by default. > > > > Signed-off-by: Adam Ford <aford173@gmail.com> > > --- > > arch/arm/mach-imx/imx8/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig > > index 9a43beda6fa..257c14e61b6 100644 > > --- a/arch/arm/mach-imx/imx8/Kconfig > > +++ b/arch/arm/mach-imx/imx8/Kconfig > > @@ -9,6 +9,8 @@ config AHAB_BOOT > > config IMX8 > > bool > > select HAS_CAAM > > + imply CPU > > + imply CPU_IMX > Shouldn't CPU_IMX select CPU ? It does not currently. Right now, it depends on CPU being set. There is another Kconfig option for CPU_ARMV8 that also depends on CPU, and I would prefer not to change both of them. adam
On 3/23/25 1:00 AM, Adam Ford wrote: > On Sat, Mar 22, 2025 at 6:31 PM Marek Vasut <marek.vasut@mailbox.org> wrote: >> >> On 3/22/25 7:38 PM, Adam Ford wrote: >>> The imx8_cpu driver is a CPU Driver that supports the i.MX8Q >>> family. When it is enabled, it acts as an alternative to >>> arch/arm/mach-imx/cpu.c, but the imx8_cpu supports the driver >>> model where cpu.c does not. Imply this newer driver by default. >>> >>> Signed-off-by: Adam Ford <aford173@gmail.com> >>> --- >>> arch/arm/mach-imx/imx8/Kconfig | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig >>> index 9a43beda6fa..257c14e61b6 100644 >>> --- a/arch/arm/mach-imx/imx8/Kconfig >>> +++ b/arch/arm/mach-imx/imx8/Kconfig >>> @@ -9,6 +9,8 @@ config AHAB_BOOT >>> config IMX8 >>> bool >>> select HAS_CAAM >>> + imply CPU >>> + imply CPU_IMX >> Shouldn't CPU_IMX select CPU ? > > It does not currently. Right now, it depends on CPU being set. There > is another Kconfig option for CPU_ARMV8 that also depends on CPU, and > I would prefer not to change both of them. Hum, OK, thanks for clarifying.
diff --git a/arch/arm/mach-imx/imx8/Kconfig b/arch/arm/mach-imx/imx8/Kconfig index 9a43beda6fa..257c14e61b6 100644 --- a/arch/arm/mach-imx/imx8/Kconfig +++ b/arch/arm/mach-imx/imx8/Kconfig @@ -9,6 +9,8 @@ config AHAB_BOOT config IMX8 bool select HAS_CAAM + imply CPU + imply CPU_IMX config MU_BASE_SPL hex "MU base address used in SPL"
The imx8_cpu driver is a CPU Driver that supports the i.MX8Q family. When it is enabled, it acts as an alternative to arch/arm/mach-imx/cpu.c, but the imx8_cpu supports the driver model where cpu.c does not. Imply this newer driver by default. Signed-off-by: Adam Ford <aford173@gmail.com> --- arch/arm/mach-imx/imx8/Kconfig | 2 ++ 1 file changed, 2 insertions(+)