| Message ID | 20250213195351.3518305-2-j-humphreys@ti.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Ilias Apalodimas |
| Headers | show |
| Series | EFI Capsule update explicitly sets dfu_alt_info | expand |
Hi Jon, thank you for the patch. On jeu., févr. 13, 2025 at 13:53, Jonathan Humphreys <j-humphreys@ti.com> wrote: > From: Michal Simek <michal.simek@amd.com> > > Directly fill update_info.dfu_string to prepare platforms to switch > from using dfu_alt_info variable to dfu_string which contains description > for capsule update when switch is done. > > Signed-off-by: Michal Simek <michal.simek@amd.com> Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com> > --- > board/xilinx/versal/board.c | 3 +++ > board/xilinx/zynq/board.c | 3 +++ > board/xilinx/zynqmp/zynqmp.c | 3 +++ > 3 files changed, 9 insertions(+) >
On Thu, Feb 13, 2025 at 01:53:49PM -0600, Jonathan Humphreys wrote: > From: Michal Simek <michal.simek@amd.com> > > Directly fill update_info.dfu_string to prepare platforms to switch > from using dfu_alt_info variable to dfu_string which contains description > for capsule update when switch is done. > > Signed-off-by: Michal Simek <michal.simek@amd.com> > --- > board/xilinx/versal/board.c | 3 +++ > board/xilinx/zynq/board.c | 3 +++ > board/xilinx/zynqmp/zynqmp.c | 3 +++ > 3 files changed, 9 insertions(+) > > diff --git a/board/xilinx/versal/board.c b/board/xilinx/versal/board.c > index b4483d00ad1..2c387630a61 100644 > --- a/board/xilinx/versal/board.c > +++ b/board/xilinx/versal/board.c > @@ -8,6 +8,7 @@ > #include <cpu_func.h> > #include <dfu.h> > #include <env.h> > +#include <efi_loader.h> > #include <fdtdec.h> > #include <init.h> > #include <env_internal.h> > @@ -438,5 +439,7 @@ void set_dfu_alt_info(char *interface, char *devstr) > > env_set("dfu_alt_info", buf); > puts("DFU alt info setting: done\n"); > + update_info.dfu_string = strdup(buf); > + debug("Capsule DFU: %s\n", update_info.dfu_string); > } > #endif > diff --git a/board/xilinx/zynq/board.c b/board/xilinx/zynq/board.c > index a852d5b8ed5..bd004b86a88 100644 > --- a/board/xilinx/zynq/board.c > +++ b/board/xilinx/zynq/board.c > @@ -7,6 +7,7 @@ > #include <config.h> > #include <debug_uart.h> > #include <dfu.h> > +#include <efi_loader.h> > #include <init.h> > #include <log.h> > #include <dm/uclass.h> > @@ -199,5 +200,7 @@ void set_dfu_alt_info(char *interface, char *devstr) > > env_set("dfu_alt_info", buf); > puts("DFU alt info setting: done\n"); > + update_info.dfu_string = strdup(buf); > + debug("Capsule DFU: %s\n", update_info.dfu_string); > } > #endif > diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c > index 820fb252a3f..8060d54428d 100644 > --- a/board/xilinx/zynqmp/zynqmp.c > +++ b/board/xilinx/zynqmp/zynqmp.c > @@ -11,6 +11,7 @@ > #include <dfu.h> > #include <env.h> > #include <env_internal.h> > +#include <efi_loader.h> > #include <init.h> > #include <log.h> > #include <net.h> > @@ -734,6 +735,8 @@ void set_dfu_alt_info(char *interface, char *devstr) > > env_set("dfu_alt_info", buf); > puts("DFU alt info setting: done\n"); > + update_info.dfu_string = strdup(buf); > + debug("Capsule DFU: %s\n", update_info.dfu_string); > } > #endif > > -- > 2.34.1 > Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
diff --git a/board/xilinx/versal/board.c b/board/xilinx/versal/board.c index b4483d00ad1..2c387630a61 100644 --- a/board/xilinx/versal/board.c +++ b/board/xilinx/versal/board.c @@ -8,6 +8,7 @@ #include <cpu_func.h> #include <dfu.h> #include <env.h> +#include <efi_loader.h> #include <fdtdec.h> #include <init.h> #include <env_internal.h> @@ -438,5 +439,7 @@ void set_dfu_alt_info(char *interface, char *devstr) env_set("dfu_alt_info", buf); puts("DFU alt info setting: done\n"); + update_info.dfu_string = strdup(buf); + debug("Capsule DFU: %s\n", update_info.dfu_string); } #endif diff --git a/board/xilinx/zynq/board.c b/board/xilinx/zynq/board.c index a852d5b8ed5..bd004b86a88 100644 --- a/board/xilinx/zynq/board.c +++ b/board/xilinx/zynq/board.c @@ -7,6 +7,7 @@ #include <config.h> #include <debug_uart.h> #include <dfu.h> +#include <efi_loader.h> #include <init.h> #include <log.h> #include <dm/uclass.h> @@ -199,5 +200,7 @@ void set_dfu_alt_info(char *interface, char *devstr) env_set("dfu_alt_info", buf); puts("DFU alt info setting: done\n"); + update_info.dfu_string = strdup(buf); + debug("Capsule DFU: %s\n", update_info.dfu_string); } #endif diff --git a/board/xilinx/zynqmp/zynqmp.c b/board/xilinx/zynqmp/zynqmp.c index 820fb252a3f..8060d54428d 100644 --- a/board/xilinx/zynqmp/zynqmp.c +++ b/board/xilinx/zynqmp/zynqmp.c @@ -11,6 +11,7 @@ #include <dfu.h> #include <env.h> #include <env_internal.h> +#include <efi_loader.h> #include <init.h> #include <log.h> #include <net.h> @@ -734,6 +735,8 @@ void set_dfu_alt_info(char *interface, char *devstr) env_set("dfu_alt_info", buf); puts("DFU alt info setting: done\n"); + update_info.dfu_string = strdup(buf); + debug("Capsule DFU: %s\n", update_info.dfu_string); } #endif