| Message ID | 20250117031535.19595-2-boon.khai.ng@intel.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | Add Synopsys DWC XGMAC Binding | expand |
On Fri, Jan 17, 2025 at 11:15:34AM +0800, Boon Khai Ng wrote: > The Synopsys DWC XGMAC is a configurable Ethernet MAC/DMA IP block which > supports multiple options for bus type, clocking and reset structure, and > feature list. > > Signed-off-by: Boon Khai Ng <boon.khai.ng@intel.com> > --- > .../net/snps,dwc-xgmac-ethernet.txt | 67 +++++++++++++++++++ > 1 file changed, 67 insertions(+) > create mode 100644 doc/device-tree-bindings/net/snps,dwc-xgmac-ethernet.txt Same comments as the first binding patch.
> -----Original Message----- > From: Tom Rini <trini@konsulko.com> > Sent: Saturday, 18 January, 2025 1:57 AM > To: Ng, Boon Khai <boon.khai.ng@intel.com> > Cc: Uboot Open List <u-boot@lists.denx.de>; Chee, Tien Fong > <tien.fong.chee@intel.com>; Hea, Kok Kiang <kok.kiang.hea@intel.com>; > Maniyam, Dinesh <dinesh.maniyam@intel.com>; Yuslaimi, Alif Zakuan > <alif.zakuan.yuslaimi@intel.com>; Zamri, Muhammad Hazim Izzat > <muhammad.hazim.izzat.zamri@intel.com> > Subject: Re: [XGMAC dt bindings v1 1/1] dt: net: add DWC XGMAC binding > > On Fri, Jan 17, 2025 at 11:15:34AM +0800, Boon Khai Ng wrote: > > > The Synopsys DWC XGMAC is a configurable Ethernet MAC/DMA IP block > > which supports multiple options for bus type, clocking and reset > > structure, and feature list. > > > > Signed-off-by: Boon Khai Ng <boon.khai.ng@intel.com> > > --- > > .../net/snps,dwc-xgmac-ethernet.txt | 67 +++++++++++++++++++ > > 1 file changed, 67 insertions(+) > > create mode 100644 > > doc/device-tree-bindings/net/snps,dwc-xgmac-ethernet.txt > > Same comments as the first binding patch. Hi Tom, I didn't quite get the context, the previous comment in the first binding patch were " We need to just use the upstream binding here, thanks." Do you mean I can just use the doc/device-tree-bindings/net/stmmac.txt as the binding for the xgmac driver? > > -- > Tom
On Mon, Feb 17, 2025 at 02:34:24AM +0000, Ng, Boon Khai wrote: > > -----Original Message----- > > From: Tom Rini <trini@konsulko.com> > > Sent: Saturday, 18 January, 2025 1:57 AM > > To: Ng, Boon Khai <boon.khai.ng@intel.com> > > Cc: Uboot Open List <u-boot@lists.denx.de>; Chee, Tien Fong > > <tien.fong.chee@intel.com>; Hea, Kok Kiang <kok.kiang.hea@intel.com>; > > Maniyam, Dinesh <dinesh.maniyam@intel.com>; Yuslaimi, Alif Zakuan > > <alif.zakuan.yuslaimi@intel.com>; Zamri, Muhammad Hazim Izzat > > <muhammad.hazim.izzat.zamri@intel.com> > > Subject: Re: [XGMAC dt bindings v1 1/1] dt: net: add DWC XGMAC binding > > > > On Fri, Jan 17, 2025 at 11:15:34AM +0800, Boon Khai Ng wrote: > > > > > The Synopsys DWC XGMAC is a configurable Ethernet MAC/DMA IP block > > > which supports multiple options for bus type, clocking and reset > > > structure, and feature list. > > > > > > Signed-off-by: Boon Khai Ng <boon.khai.ng@intel.com> > > > --- > > > .../net/snps,dwc-xgmac-ethernet.txt | 67 +++++++++++++++++++ > > > 1 file changed, 67 insertions(+) > > > create mode 100644 > > > doc/device-tree-bindings/net/snps,dwc-xgmac-ethernet.txt > > > > Same comments as the first binding patch. > > Hi Tom, I didn't quite get the context, the previous comment in the first binding patch > were " We need to just use the upstream binding here, thanks." > > Do you mean I can just use the doc/device-tree-bindings/net/stmmac.txt > as the binding for the xgmac driver? To be clear, it means you should use the same bindings at the linux kernel, which we have in dts/upstream/
> To be clear, it means you should use the same bindings at the linux kernel, > which we have in dts/upstream/ Hi Tom, okay got it. From Linux perspective we are using both below: 1) dts/upstream/Bindings/net/snp,dwmac.yaml 2) dts/upstream/Bindings/net/socfpga-dwmac.txt In the case of U-Boot driver is mismatching with Linux binding (which is unlikely to happen), I will need to submit the changes to linux mainline to update the bindings on the changes? In summary, can I say, we will drop this patch, and just follow the dts/upstream binding? Regards, Boon Khai Ng Boon Khai
On Tue, Feb 18, 2025 at 01:43:15AM +0000, Ng, Boon Khai wrote: > > To be clear, it means you should use the same bindings at the linux kernel, > > which we have in dts/upstream/ > > Hi Tom, okay got it. From Linux perspective we are using both below: > 1) dts/upstream/Bindings/net/snp,dwmac.yaml > 2) dts/upstream/Bindings/net/socfpga-dwmac.txt > > In the case of U-Boot driver is mismatching with Linux binding (which is unlikely to happen), > I will need to submit the changes to linux mainline to update the bindings on the changes? > > In summary, can I say, we will drop this patch, and just follow the dts/upstream binding? Yes, exactly, thanks!
diff --git a/doc/device-tree-bindings/net/snps,dwc-xgmac-ethernet.txt b/doc/device-tree-bindings/net/snps,dwc-xgmac-ethernet.txt new file mode 100644 index 0000000000..98a188fe5d --- /dev/null +++ b/doc/device-tree-bindings/net/snps,dwc-xgmac-ethernet.txt @@ -0,0 +1,67 @@ +* Synopsys DWC Ethernet 10G Ethernet MAC IP version 2.10 driver (XGMAC) + +This binding supports the Synopsys Designware Ethernet 10G Ethernet MAC +IP block. The IP supports multiple options for bus type, clocking and reset +structure, and feature list. Consequently, a number of properties and list +entries in properties are marked as optional, or only required in specific HW +configurations. + +Required properties: +- compatible: One of: + - "intel,socfpga-dwxgmac", "snps,dwxgmac-2.10" + Represents the IP core when integrated into the Agilex5 Intel (R) SoC FPGA. +- reg: Address and length of the register set for the device +- clocks: Phandle and clock specifiers for each entry in clock-names, in the + same order. See ../clock/clock-bindings.txt. +- clock-names: + - stmmaceth + +- interrupt-parent: Should be the phandle for the interrupt controller + that services interrupts for this device +- interrupts: Should contain the core's combined interrupt signal +- phy-mode: See ethernet.txt file in the same directory +- resets: Phandle and reset specifiers for each entry in reset-names, in the + same order. See ../reset/reset.txt. +- reset-names: May contain any/all of the following depending on the IP + configuration, in any order: + +Optional properties: +- dma-coherent: Present if dma operations are coherent +- mac-address: See ethernet.txt in the same directory +- local-mac-address: See ethernet.txt in the same directory +- phy-handle: See ethernet.txt file in the same directory +- mdio device tree subnode: When the XGMAC has a phy connected to its local + mdio, there must be device tree subnode with the following + required properties: + - compatible: Must be "snps,dwxgmac-mdio". + - #address-cells: Must be <1>. + - #size-cells: Must be <0>. + + For each phy on the mdio bus, there must be a node with the following + fields: + + - reg: phy id used to communicate to phy. + - device_type: Must be "ethernet-phy". + - fixed-mode device tree subnode: see fixed-link.txt in the same directory +- altr,sysmgr-syscon: This propertise is a platform specific propertise to + control the system manager whether to set or reset the XGMAC. This is specific + to Intel SoC FPGA Family device. + +Examples: +gmac0: ethernet@10810000 { + compatible = "intel,socfpga-dwxgmac", "snps,dwxgmac-2.10", "snps,dwxgmac"; + reg = <0x10810000 0x3500>; + interrupts = <0 190 4>; + interrupt-names = "macirq"; + mac-address = [00 00 00 00 00 00]; + resets = <&rst EMAC0_RESET>, <&rst EMAC0_OCP_RESET>; + reset-names = "stmmaceth", "stmmaceth-ocp"; + tx-fifo-depth = <32768>; + rx-fifo-depth = <16384>; + snps,multicast-filter-bins = <256>; + iommus = <&smmu 0>; + altr,sysmgr-syscon = <&sysmgr 0x44 0>; + clocks = <&clkmgr AGILEX5_EMAC0_CLK>; + clock-names = "stmmaceth"; + status = "disabled"; +};
The Synopsys DWC XGMAC is a configurable Ethernet MAC/DMA IP block which supports multiple options for bus type, clocking and reset structure, and feature list. Signed-off-by: Boon Khai Ng <boon.khai.ng@intel.com> --- .../net/snps,dwc-xgmac-ethernet.txt | 67 +++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 doc/device-tree-bindings/net/snps,dwc-xgmac-ethernet.txt