| Message ID | 20241215233210.569642-1-marex@denx.de |
|---|---|
| State | Accepted |
| Commit | edc425ef16d30175b15fe6c895b622738fb2f58c |
| Delegated to: | Patrice Chotard |
| Headers | show |
| Series | ARM: dts: stm32: Reinstate missing root oscillators on STM32MP15xx | expand |
On 12/16/24 00:31, Marek Vasut wrote: > The root oscillators reference used to be in rcc node since > 3d15245502c4 ("ARM: dts: stm32mp1: explicit clock reference needed by RCC clock driver") > however this is not part of upstream stm32mp151.dtsi . The > RCC driver does need this reference, reinstate it globally. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > NOTE: Would be good for 2025.01, but needs to be tested on other systems > --- > Cc: Igor Opaniuk <igor.opaniuk@gmail.com> > Cc: Patrice Chotard <patrice.chotard@foss.st.com> > Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> > Cc: Simon Glass <sjg@chromium.org> > Cc: Tom Rini <trini@konsulko.com> > Cc: u-boot@dh-electronics.com > Cc: u-boot@lists.denx.de > Cc: uboot-stm32@st-md-mailman.stormreply.com > --- > arch/arm/dts/stm32mp15-u-boot.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/dts/stm32mp15-u-boot.dtsi b/arch/arm/dts/stm32mp15-u-boot.dtsi > index 66d4c40c6a8..3f57bd5fe0f 100644 > --- a/arch/arm/dts/stm32mp15-u-boot.dtsi > +++ b/arch/arm/dts/stm32mp15-u-boot.dtsi > @@ -186,6 +186,9 @@ > bootph-all; > #address-cells = <1>; > #size-cells = <0>; > + clock-names = "hse", "hsi", "csi", "lse", "lsi"; > + clocks = <&clk_hse>, <&clk_hsi>, <&clk_csi>, > + <&clk_lse>, <&clk_lsi>; > }; > > &usart1 { Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> Tested-by: Patrice Chotard <patrice.chotard@foss.st.com> Tested on STM32MP157C-DK2 and STM32MP157C-EV1 Thanks Patrice
On 12/16/24 09:23, Patrice CHOTARD wrote: > > > On 12/16/24 00:31, Marek Vasut wrote: >> The root oscillators reference used to be in rcc node since >> 3d15245502c4 ("ARM: dts: stm32mp1: explicit clock reference needed by RCC clock driver") >> however this is not part of upstream stm32mp151.dtsi . The >> RCC driver does need this reference, reinstate it globally. >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> --- >> NOTE: Would be good for 2025.01, but needs to be tested on other systems >> --- >> Cc: Igor Opaniuk <igor.opaniuk@gmail.com> >> Cc: Patrice Chotard <patrice.chotard@foss.st.com> >> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> >> Cc: Simon Glass <sjg@chromium.org> >> Cc: Tom Rini <trini@konsulko.com> >> Cc: u-boot@dh-electronics.com >> Cc: u-boot@lists.denx.de >> Cc: uboot-stm32@st-md-mailman.stormreply.com >> --- >> arch/arm/dts/stm32mp15-u-boot.dtsi | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm/dts/stm32mp15-u-boot.dtsi b/arch/arm/dts/stm32mp15-u-boot.dtsi >> index 66d4c40c6a8..3f57bd5fe0f 100644 >> --- a/arch/arm/dts/stm32mp15-u-boot.dtsi >> +++ b/arch/arm/dts/stm32mp15-u-boot.dtsi >> @@ -186,6 +186,9 @@ >> bootph-all; >> #address-cells = <1>; >> #size-cells = <0>; >> + clock-names = "hse", "hsi", "csi", "lse", "lsi"; >> + clocks = <&clk_hse>, <&clk_hsi>, <&clk_csi>, >> + <&clk_lse>, <&clk_lsi>; >> }; >> >> &usart1 { > > Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> > Tested-by: Patrice Chotard <patrice.chotard@foss.st.com> > > Tested on STM32MP157C-DK2 and STM32MP157C-EV1 > > Thanks > Patrice > _______________________________________________ > Uboot-stm32 mailing list > Uboot-stm32@st-md-mailman.stormreply.com > https://st-md-mailman.stormreply.com/mailman/listinfo/uboot-stm32 Applied to u-boot-stm32/next Thanks Patrice
On 12/18/24 11:31, Patrice CHOTARD wrote: > > > On 12/16/24 09:23, Patrice CHOTARD wrote: >> >> >> On 12/16/24 00:31, Marek Vasut wrote: >>> The root oscillators reference used to be in rcc node since >>> 3d15245502c4 ("ARM: dts: stm32mp1: explicit clock reference needed by RCC clock driver") >>> however this is not part of upstream stm32mp151.dtsi . The >>> RCC driver does need this reference, reinstate it globally. >>> >>> Signed-off-by: Marek Vasut <marex@denx.de> >>> --- >>> NOTE: Would be good for 2025.01, but needs to be tested on other systems >>> --- >>> Cc: Igor Opaniuk <igor.opaniuk@gmail.com> >>> Cc: Patrice Chotard <patrice.chotard@foss.st.com> >>> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> >>> Cc: Simon Glass <sjg@chromium.org> >>> Cc: Tom Rini <trini@konsulko.com> >>> Cc: u-boot@dh-electronics.com >>> Cc: u-boot@lists.denx.de >>> Cc: uboot-stm32@st-md-mailman.stormreply.com >>> --- >>> arch/arm/dts/stm32mp15-u-boot.dtsi | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/arch/arm/dts/stm32mp15-u-boot.dtsi b/arch/arm/dts/stm32mp15-u-boot.dtsi >>> index 66d4c40c6a8..3f57bd5fe0f 100644 >>> --- a/arch/arm/dts/stm32mp15-u-boot.dtsi >>> +++ b/arch/arm/dts/stm32mp15-u-boot.dtsi >>> @@ -186,6 +186,9 @@ >>> bootph-all; >>> #address-cells = <1>; >>> #size-cells = <0>; >>> + clock-names = "hse", "hsi", "csi", "lse", "lsi"; >>> + clocks = <&clk_hse>, <&clk_hsi>, <&clk_csi>, >>> + <&clk_lse>, <&clk_lsi>; >>> }; >>> >>> &usart1 { >> >> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> >> Tested-by: Patrice Chotard <patrice.chotard@foss.st.com> >> >> Tested on STM32MP157C-DK2 and STM32MP157C-EV1 >> >> Thanks >> Patrice >> _______________________________________________ >> Uboot-stm32 mailing list >> Uboot-stm32@st-md-mailman.stormreply.com >> https://st-md-mailman.stormreply.com/mailman/listinfo/uboot-stm32 > > > Applied to u-boot-stm32/next > > Thanks > Patrice Sorry, applied to u-boot-stm32/master Thanks Patrice
diff --git a/arch/arm/dts/stm32mp15-u-boot.dtsi b/arch/arm/dts/stm32mp15-u-boot.dtsi index 66d4c40c6a8..3f57bd5fe0f 100644 --- a/arch/arm/dts/stm32mp15-u-boot.dtsi +++ b/arch/arm/dts/stm32mp15-u-boot.dtsi @@ -186,6 +186,9 @@ bootph-all; #address-cells = <1>; #size-cells = <0>; + clock-names = "hse", "hsi", "csi", "lse", "lsi"; + clocks = <&clk_hse>, <&clk_hsi>, <&clk_csi>, + <&clk_lse>, <&clk_lsi>; }; &usart1 {
The root oscillators reference used to be in rcc node since 3d15245502c4 ("ARM: dts: stm32mp1: explicit clock reference needed by RCC clock driver") however this is not part of upstream stm32mp151.dtsi . The RCC driver does need this reference, reinstate it globally. Signed-off-by: Marek Vasut <marex@denx.de> --- NOTE: Would be good for 2025.01, but needs to be tested on other systems --- Cc: Igor Opaniuk <igor.opaniuk@gmail.com> Cc: Patrice Chotard <patrice.chotard@foss.st.com> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com> Cc: Simon Glass <sjg@chromium.org> Cc: Tom Rini <trini@konsulko.com> Cc: u-boot@dh-electronics.com Cc: u-boot@lists.denx.de Cc: uboot-stm32@st-md-mailman.stormreply.com --- arch/arm/dts/stm32mp15-u-boot.dtsi | 3 +++ 1 file changed, 3 insertions(+)