diff mbox series

[1/4] ARM: dts: stm32: Reinstate missing root oscillators on DH STM32MP15xx DHCOR

Message ID 20241215233011.569287-1-marex@denx.de
State Accepted
Commit b6519061228f6076c7be43aca9c537daf53021c5
Delegated to: Patrice Chotard
Headers show
Series [1/4] ARM: dts: stm32: Reinstate missing root oscillators on DH STM32MP15xx DHCOR | expand

Commit Message

Marek Vasut Dec. 15, 2024, 11:29 p.m. UTC
The root oscillators reference used to be in rcc node since
3d15245502c4 ("ARM: dts: stm32mp1: explicit clock reference needed by RCC clock driver")
however this is not part of upstream stm32mp151.dtsi . The
RCC driver does need this reference, reinstate it locally.

Signed-off-by: Marek Vasut <marex@denx.de>
---
NOTE: For 2025.01
---
Cc: Igor Opaniuk <igor.opaniuk@gmail.com>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
Cc: u-boot@dh-electronics.com
Cc: u-boot@lists.denx.de
Cc: uboot-stm32@st-md-mailman.stormreply.com
---
 arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Patrice CHOTARD Dec. 17, 2024, 4:42 p.m. UTC | #1
On 12/16/24 00:29, Marek Vasut wrote:
> The root oscillators reference used to be in rcc node since
> 3d15245502c4 ("ARM: dts: stm32mp1: explicit clock reference needed by RCC clock driver")
> however this is not part of upstream stm32mp151.dtsi . The
> RCC driver does need this reference, reinstate it locally.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> NOTE: For 2025.01
> ---
> Cc: Igor Opaniuk <igor.opaniuk@gmail.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: u-boot@dh-electronics.com
> Cc: u-boot@lists.denx.de
> Cc: uboot-stm32@st-md-mailman.stormreply.com
> ---
>  arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
> index 08439342cb2..ab162f39473 100644
> --- a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
> +++ b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
> @@ -112,6 +112,10 @@
>  };
>  
>  &rcc {
> +	clock-names = "hse", "hsi", "csi", "lse", "lsi";
> +	clocks = <&clk_hse>, <&clk_hsi>, <&clk_csi>,
> +		 <&clk_lse>, <&clk_lsi>;
> +
>  	st,clksrc = <
>  		CLK_MPU_PLL1P
>  		CLK_AXI_PLL2P

Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>

Thanks
PAtrice
Patrice CHOTARD Dec. 18, 2024, 10:31 a.m. UTC | #2
On 12/17/24 17:42, Patrice CHOTARD wrote:
> 
> 
> On 12/16/24 00:29, Marek Vasut wrote:
>> The root oscillators reference used to be in rcc node since
>> 3d15245502c4 ("ARM: dts: stm32mp1: explicit clock reference needed by RCC clock driver")
>> however this is not part of upstream stm32mp151.dtsi . The
>> RCC driver does need this reference, reinstate it locally.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> NOTE: For 2025.01
>> ---
>> Cc: Igor Opaniuk <igor.opaniuk@gmail.com>
>> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
>> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
>> Cc: Simon Glass <sjg@chromium.org>
>> Cc: Tom Rini <trini@konsulko.com>
>> Cc: u-boot@dh-electronics.com
>> Cc: u-boot@lists.denx.de
>> Cc: uboot-stm32@st-md-mailman.stormreply.com
>> ---
>>  arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
>> index 08439342cb2..ab162f39473 100644
>> --- a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
>> +++ b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
>> @@ -112,6 +112,10 @@
>>  };
>>  
>>  &rcc {
>> +	clock-names = "hse", "hsi", "csi", "lse", "lsi";
>> +	clocks = <&clk_hse>, <&clk_hsi>, <&clk_csi>,
>> +		 <&clk_lse>, <&clk_lsi>;
>> +
>>  	st,clksrc = <
>>  		CLK_MPU_PLL1P
>>  		CLK_AXI_PLL2P
> 
> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
> 
> Thanks
> PAtrice
Applied to u-boot-stm32/next

Thanks
Patrice
Patrice CHOTARD Dec. 18, 2024, 10:36 a.m. UTC | #3
On 12/18/24 11:31, Patrice CHOTARD wrote:
> 
> 
> On 12/17/24 17:42, Patrice CHOTARD wrote:
>>
>>
>> On 12/16/24 00:29, Marek Vasut wrote:
>>> The root oscillators reference used to be in rcc node since
>>> 3d15245502c4 ("ARM: dts: stm32mp1: explicit clock reference needed by RCC clock driver")
>>> however this is not part of upstream stm32mp151.dtsi . The
>>> RCC driver does need this reference, reinstate it locally.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> ---
>>> NOTE: For 2025.01
>>> ---
>>> Cc: Igor Opaniuk <igor.opaniuk@gmail.com>
>>> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
>>> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
>>> Cc: Simon Glass <sjg@chromium.org>
>>> Cc: Tom Rini <trini@konsulko.com>
>>> Cc: u-boot@dh-electronics.com
>>> Cc: u-boot@lists.denx.de
>>> Cc: uboot-stm32@st-md-mailman.stormreply.com
>>> ---
>>>  arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
>>> index 08439342cb2..ab162f39473 100644
>>> --- a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
>>> +++ b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
>>> @@ -112,6 +112,10 @@
>>>  };
>>>  
>>>  &rcc {
>>> +	clock-names = "hse", "hsi", "csi", "lse", "lsi";
>>> +	clocks = <&clk_hse>, <&clk_hsi>, <&clk_csi>,
>>> +		 <&clk_lse>, <&clk_lsi>;
>>> +
>>>  	st,clksrc = <
>>>  		CLK_MPU_PLL1P
>>>  		CLK_AXI_PLL2P
>>
>> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
>>
>> Thanks
>> PAtrice
> Applied to u-boot-stm32/next
> 
> Thanks
> Patrice

Sorry, applied to u-boot-stm32/master

Thanks
Patrice

> _______________________________________________
> Uboot-stm32 mailing list
> Uboot-stm32@st-md-mailman.stormreply.com
> https://st-md-mailman.stormreply.com/mailman/listinfo/uboot-stm32
diff mbox series

Patch

diff --git a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
index 08439342cb2..ab162f39473 100644
--- a/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
+++ b/arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi
@@ -112,6 +112,10 @@ 
 };
 
 &rcc {
+	clock-names = "hse", "hsi", "csi", "lse", "lsi";
+	clocks = <&clk_hse>, <&clk_hsi>, <&clk_csi>,
+		 <&clk_lse>, <&clk_lsi>;
+
 	st,clksrc = <
 		CLK_MPU_PLL1P
 		CLK_AXI_PLL2P