| Message ID | 20241212101331.6135-6-clamor95@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Thierry Reding |
| Headers | show |
| Series | ARCH Tegra improvements | expand |
чт, 12 груд. 2024 р. о 12:13 Svyatoslav Ryhel <clamor95@gmail.com> пише: > > Same as on previous SoC generations this is required for proper > video output work. > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > --- > arch/arm/dts/tegra124-nyan-big-u-boot.dtsi | 7 ------- > arch/arm/dts/tegra124-u-boot.dtsi | 13 +++++++++++++ > 2 files changed, 13 insertions(+), 7 deletions(-) > > diff --git a/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi b/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi > index 376dcdf68fb..79de06761bb 100644 > --- a/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi > +++ b/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi > @@ -7,13 +7,6 @@ > #include "tegra-u-boot.dtsi" > > / { > - host1x@50000000 { > - bootph-all; > - dc@54200000 { > - bootph-all; > - }; > - }; > - > spi@7000d400 { > spi-deactivate-delay = <500>; > spi-max-frequency = <3000000>; > diff --git a/arch/arm/dts/tegra124-u-boot.dtsi b/arch/arm/dts/tegra124-u-boot.dtsi > index 7c119725528..6a02714a258 100644 > --- a/arch/arm/dts/tegra124-u-boot.dtsi > +++ b/arch/arm/dts/tegra124-u-boot.dtsi > @@ -1,3 +1,16 @@ > #include <config.h> > > #include "tegra-u-boot.dtsi" > + > +/ { > + host1x@50000000 { > + bootph-all; > + dc@54200000 { > + bootph-all; > + }; > + > + dc@54240000 { > + bootph-all; > + }; > + }; > +}; > -- > 2.43.0 > This commit for some reason breaks u-boot build for nyan-big https://source.denx.de/u-boot/custodians/u-boot-tegra/-/jobs/1020521 Video device 'dc@54200000' cannot allocate frame buffer memory - ensure the device is set up before relocation Indicates that bootph-all is missing though it should be present, just moved into tegra124-u-boot.dtsi (this is required for any other tegra124 device which would like to have video output). Isn't tegra124-u-boot.dtsi applied if device specific -u-boot.dtsi is defined? May anyone clarify this?
ср, 12 лют. 2025 р. о 13:20 Svyatoslav Ryhel <clamor95@gmail.com> пише: > > чт, 12 груд. 2024 р. о 12:13 Svyatoslav Ryhel <clamor95@gmail.com> пише: > > > > Same as on previous SoC generations this is required for proper > > video output work. > > > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > > --- > > arch/arm/dts/tegra124-nyan-big-u-boot.dtsi | 7 ------- > > arch/arm/dts/tegra124-u-boot.dtsi | 13 +++++++++++++ > > 2 files changed, 13 insertions(+), 7 deletions(-) > > > > diff --git a/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi b/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi > > index 376dcdf68fb..79de06761bb 100644 > > --- a/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi > > +++ b/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi > > @@ -7,13 +7,6 @@ > > #include "tegra-u-boot.dtsi" > > > > / { > > - host1x@50000000 { > > - bootph-all; > > - dc@54200000 { > > - bootph-all; > > - }; > > - }; > > - > > spi@7000d400 { > > spi-deactivate-delay = <500>; > > spi-max-frequency = <3000000>; > > diff --git a/arch/arm/dts/tegra124-u-boot.dtsi b/arch/arm/dts/tegra124-u-boot.dtsi > > index 7c119725528..6a02714a258 100644 > > --- a/arch/arm/dts/tegra124-u-boot.dtsi > > +++ b/arch/arm/dts/tegra124-u-boot.dtsi > > @@ -1,3 +1,16 @@ > > #include <config.h> > > > > #include "tegra-u-boot.dtsi" > > + > > +/ { > > + host1x@50000000 { > > + bootph-all; > > + dc@54200000 { > > + bootph-all; > > + }; > > + > > + dc@54240000 { > > + bootph-all; > > + }; > > + }; > > +}; > > -- > > 2.43.0 > > > > This commit for some reason breaks u-boot build for nyan-big > https://source.denx.de/u-boot/custodians/u-boot-tegra/-/jobs/1020521 > > Video device 'dc@54200000' cannot allocate frame buffer memory - > ensure the device is set up before relocation > > Indicates that bootph-all is missing though it should be present, just > moved into tegra124-u-boot.dtsi (this is required for any other > tegra124 device which would like to have video output). Isn't > tegra124-u-boot.dtsi applied if device specific -u-boot.dtsi is > defined? May anyone clarify this? RE-sending
Hi Svyatoslav, On Thu, 13 Feb 2025 at 06:53, Svyatoslav Ryhel <clamor95@gmail.com> wrote: > > ср, 12 лют. 2025 р. о 13:20 Svyatoslav Ryhel <clamor95@gmail.com> пише: > > > > чт, 12 груд. 2024 р. о 12:13 Svyatoslav Ryhel <clamor95@gmail.com> пише: > > > > > > Same as on previous SoC generations this is required for proper > > > video output work. > > > > > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > > > --- > > > arch/arm/dts/tegra124-nyan-big-u-boot.dtsi | 7 ------- > > > arch/arm/dts/tegra124-u-boot.dtsi | 13 +++++++++++++ > > > 2 files changed, 13 insertions(+), 7 deletions(-) > > > > > > diff --git a/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi b/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi > > > index 376dcdf68fb..79de06761bb 100644 > > > --- a/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi > > > +++ b/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi > > > @@ -7,13 +7,6 @@ > > > #include "tegra-u-boot.dtsi" > > > > > > / { > > > - host1x@50000000 { > > > - bootph-all; > > > - dc@54200000 { > > > - bootph-all; > > > - }; > > > - }; > > > - > > > spi@7000d400 { > > > spi-deactivate-delay = <500>; > > > spi-max-frequency = <3000000>; > > > diff --git a/arch/arm/dts/tegra124-u-boot.dtsi b/arch/arm/dts/tegra124-u-boot.dtsi > > > index 7c119725528..6a02714a258 100644 > > > --- a/arch/arm/dts/tegra124-u-boot.dtsi > > > +++ b/arch/arm/dts/tegra124-u-boot.dtsi > > > @@ -1,3 +1,16 @@ > > > #include <config.h> > > > > > > #include "tegra-u-boot.dtsi" > > > + > > > +/ { > > > + host1x@50000000 { > > > + bootph-all; > > > + dc@54200000 { > > > + bootph-all; > > > + }; > > > + > > > + dc@54240000 { > > > + bootph-all; > > > + }; > > > + }; > > > +}; > > > -- > > > 2.43.0 > > > > > > > This commit for some reason breaks u-boot build for nyan-big > > https://source.denx.de/u-boot/custodians/u-boot-tegra/-/jobs/1020521 > > > > Video device 'dc@54200000' cannot allocate frame buffer memory - > > ensure the device is set up before relocation > > > > Indicates that bootph-all is missing though it should be present, just > > moved into tegra124-u-boot.dtsi (this is required for any other > > tegra124 device which would like to have video output). Isn't > > tegra124-u-boot.dtsi applied if device specific -u-boot.dtsi is > > defined? May anyone clarify this? Yes it should be. You can examine the final u-boot.dtb to see what results. In terms of the error, dc@54240000 is disabled for Nyan_big but I'm not sure if that is related. You could add debugging to tegra124_lcd_bind() perhaps? Regards, Simon
diff --git a/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi b/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi index 376dcdf68fb..79de06761bb 100644 --- a/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi +++ b/arch/arm/dts/tegra124-nyan-big-u-boot.dtsi @@ -7,13 +7,6 @@ #include "tegra-u-boot.dtsi" / { - host1x@50000000 { - bootph-all; - dc@54200000 { - bootph-all; - }; - }; - spi@7000d400 { spi-deactivate-delay = <500>; spi-max-frequency = <3000000>; diff --git a/arch/arm/dts/tegra124-u-boot.dtsi b/arch/arm/dts/tegra124-u-boot.dtsi index 7c119725528..6a02714a258 100644 --- a/arch/arm/dts/tegra124-u-boot.dtsi +++ b/arch/arm/dts/tegra124-u-boot.dtsi @@ -1,3 +1,16 @@ #include <config.h> #include "tegra-u-boot.dtsi" + +/ { + host1x@50000000 { + bootph-all; + dc@54200000 { + bootph-all; + }; + + dc@54240000 { + bootph-all; + }; + }; +};
Same as on previous SoC generations this is required for proper video output work. Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> --- arch/arm/dts/tegra124-nyan-big-u-boot.dtsi | 7 ------- arch/arm/dts/tegra124-u-boot.dtsi | 13 +++++++++++++ 2 files changed, 13 insertions(+), 7 deletions(-)