| Message ID | 20241206225438.13866-11-raymond.mao@linaro.org |
|---|---|
| State | Under Review |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | SMBIOS improvements | expand |
On 06.12.24 23:54, Raymond Mao wrote: > Enable sysinfo smbios by default for arm64. > When SYSINFO_SMBIOS is enabled, disable QFW_SMBIOS. > > Signed-off-by: Raymond Mao <raymond.mao@linaro.org> > Reviewed-by: Simon Glass <sjg@chromium.org> > --- > Changes in v2 > - None. > Changes in v3 > - add CONFIG_GENERATE_SMBIOS_TABLE_VERBOSE > > configs/qemu_arm64_defconfig | 3 +++ > drivers/misc/Kconfig | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig > index 8dffb91e93b..31656699d82 100644 > --- a/configs/qemu_arm64_defconfig > +++ b/configs/qemu_arm64_defconfig Doesn't this work on qemu_arm_defconfig? We should test on 32bit too. Best regards Heinrich > @@ -62,6 +62,8 @@ CONFIG_PCIE_ECAM_GENERIC=y > CONFIG_SCSI=y > CONFIG_DEBUG_UART_PL011=y > CONFIG_DEBUG_UART_SHIFT=2 > +CONFIG_SYSINFO=y > +CONFIG_SYSINFO_SMBIOS=y > CONFIG_SYSRESET=y > CONFIG_SYSRESET_CMD_POWEROFF=y > CONFIG_SYSRESET_PSCI=y > @@ -71,3 +73,4 @@ CONFIG_USB_EHCI_PCI=y > CONFIG_SEMIHOSTING=y > CONFIG_MBEDTLS_LIB=y > CONFIG_TPM=y > +CONFIG_GENERATE_SMBIOS_TABLE_VERBOSE=y > diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig > index 6009d55f400..da84b35e804 100644 > --- a/drivers/misc/Kconfig > +++ b/drivers/misc/Kconfig > @@ -568,7 +568,7 @@ config QFW_MMIO > config QFW_SMBIOS > bool > default y > - depends on QFW && SMBIOS && !SANDBOX > + depends on QFW && SMBIOS && !SANDBOX && !SYSINFO_SMBIOS > help > Hidden option to read SMBIOS tables from QEMU. >
Hi Heinrich, On Thu, 19 Dec 2024 at 11:00, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote: > On 06.12.24 23:54, Raymond Mao wrote: > > Enable sysinfo smbios by default for arm64. > > When SYSINFO_SMBIOS is enabled, disable QFW_SMBIOS. > > > > Signed-off-by: Raymond Mao <raymond.mao@linaro.org> > > Reviewed-by: Simon Glass <sjg@chromium.org> > > --- > > Changes in v2 > > - None. > > Changes in v3 > > - add CONFIG_GENERATE_SMBIOS_TABLE_VERBOSE > > > > configs/qemu_arm64_defconfig | 3 +++ > > drivers/misc/Kconfig | 2 +- > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig > > index 8dffb91e93b..31656699d82 100644 > > --- a/configs/qemu_arm64_defconfig > > +++ b/configs/qemu_arm64_defconfig > > Doesn't this work on qemu_arm_defconfig? > We should test on 32bit too. > > It has been tested on qemu_arm_defconfig manually, I can add the kconfig for it if you want. [snip] Regards, Raymond
diff --git a/configs/qemu_arm64_defconfig b/configs/qemu_arm64_defconfig index 8dffb91e93b..31656699d82 100644 --- a/configs/qemu_arm64_defconfig +++ b/configs/qemu_arm64_defconfig @@ -62,6 +62,8 @@ CONFIG_PCIE_ECAM_GENERIC=y CONFIG_SCSI=y CONFIG_DEBUG_UART_PL011=y CONFIG_DEBUG_UART_SHIFT=2 +CONFIG_SYSINFO=y +CONFIG_SYSINFO_SMBIOS=y CONFIG_SYSRESET=y CONFIG_SYSRESET_CMD_POWEROFF=y CONFIG_SYSRESET_PSCI=y @@ -71,3 +73,4 @@ CONFIG_USB_EHCI_PCI=y CONFIG_SEMIHOSTING=y CONFIG_MBEDTLS_LIB=y CONFIG_TPM=y +CONFIG_GENERATE_SMBIOS_TABLE_VERBOSE=y diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 6009d55f400..da84b35e804 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -568,7 +568,7 @@ config QFW_MMIO config QFW_SMBIOS bool default y - depends on QFW && SMBIOS && !SANDBOX + depends on QFW && SMBIOS && !SANDBOX && !SYSINFO_SMBIOS help Hidden option to read SMBIOS tables from QEMU.