| Message ID | 20241112023854.2289656-1-festevam@gmail.com |
|---|---|
| State | Accepted |
| Commit | 3c417c79e0073b500e38a31c4e671894e23e2e34 |
| Delegated to: | Fabio Estevam |
| Headers | show |
| Series | tools: imx8image: Add missing break for CMD_DCD_SKIP | expand |
Hello Fabio, On 12.11.24 03:38, Fabio Estevam wrote: > From: Fabio Estevam <festevam@denx.de> > > The CMD_DCD_SKIP case misses a break statement. > > Add it. > > Fixes: 254c00803b63 ("tools: imx8image: add possibility to skip dcd") > Addresses-Coverity-ID: 514648: Control flow issues (MISSING_BREAK) > Signed-off-by: Fabio Estevam <festevam@denx.de> > --- > tools/imx8image.c | 1 + > 1 file changed, 1 insertion(+) Thanks! Reviewed-by: Heiko Schocher <hs@denx.de> Hmm.. could we add this scan in our CI ? bye, Heiko
On Mon, Nov 11, 2024 at 11:39 PM Fabio Estevam <festevam@gmail.com> wrote: > > From: Fabio Estevam <festevam@denx.de> > > The CMD_DCD_SKIP case misses a break statement. > > Add it. > > Fixes: 254c00803b63 ("tools: imx8image: add possibility to skip dcd") > Addresses-Coverity-ID: 514648: Control flow issues (MISSING_BREAK) > Signed-off-by: Fabio Estevam <festevam@denx.de> Applied, thanks.
diff --git a/tools/imx8image.c b/tools/imx8image.c index 96ece28bd6..7a060811c7 100644 --- a/tools/imx8image.c +++ b/tools/imx8image.c @@ -93,6 +93,7 @@ static void parse_cfg_cmd(image_t *param_stack, int32_t cmd, char *token, case CMD_DCD_SKIP: if (!strncmp("true", token, 4)) dcd_skip = true; + break; case CMD_FUSE_VERSION: fuse_version = (uint8_t)(strtoll(token, NULL, 0) & 0xFF); break;