diff mbox series

[07/11] rockchip: rk3288-miqi: Drop use of silent console and late boardinfo

Message ID 20241105215202.1491441-8-jonas@kwiboo.se
State New
Headers show
Series rockchip: rk3288-miqi: Migrate to OF_UPSTREAM | expand

Commit Message

Jonas Karlman Nov. 5, 2024, 9:51 p.m. UTC
Current use of SILENT_CONSOLE hide valuable information when something
goes wrong during boot, drop this Kconfig option to allow user to see
e.g. from what media U-Boot proper is loaded from.

A second Model line is printed on console due to DISPLAY_BOARDINFO_LATE,
drop this Kconfig option to remove the second redundant line.

Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
---
 configs/miqi-rk3288_defconfig | 2 --
 1 file changed, 2 deletions(-)

Comments

Kever Yang Nov. 6, 2024, 10:45 a.m. UTC | #1
On 2024/11/6 05:51, Jonas Karlman wrote:
> Current use of SILENT_CONSOLE hide valuable information when something
> goes wrong during boot, drop this Kconfig option to allow user to see
> e.g. from what media U-Boot proper is loaded from.
>
> A second Model line is printed on console due to DISPLAY_BOARDINFO_LATE,
> drop this Kconfig option to remove the second redundant line.
>
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>

Thanks,
- Kever
> ---
>   configs/miqi-rk3288_defconfig | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/configs/miqi-rk3288_defconfig b/configs/miqi-rk3288_defconfig
> index 87fd256c8a53..678d6fb33716 100644
> --- a/configs/miqi-rk3288_defconfig
> +++ b/configs/miqi-rk3288_defconfig
> @@ -20,8 +20,6 @@ CONFIG_DEBUG_UART=y
>   CONFIG_USE_PREBOOT=y
>   CONFIG_DEFAULT_FDT_FILE="rk3288-miqi.dtb"
>   CONFIG_MISC_INIT_R=y
> -CONFIG_SILENT_CONSOLE=y
> -CONFIG_DISPLAY_BOARDINFO_LATE=y
>   CONFIG_SPL_PAD_TO=0x7f8000
>   CONFIG_CMD_GPIO=y
>   CONFIG_CMD_GPT=y
diff mbox series

Patch

diff --git a/configs/miqi-rk3288_defconfig b/configs/miqi-rk3288_defconfig
index 87fd256c8a53..678d6fb33716 100644
--- a/configs/miqi-rk3288_defconfig
+++ b/configs/miqi-rk3288_defconfig
@@ -20,8 +20,6 @@  CONFIG_DEBUG_UART=y
 CONFIG_USE_PREBOOT=y
 CONFIG_DEFAULT_FDT_FILE="rk3288-miqi.dtb"
 CONFIG_MISC_INIT_R=y
-CONFIG_SILENT_CONSOLE=y
-CONFIG_DISPLAY_BOARDINFO_LATE=y
 CONFIG_SPL_PAD_TO=0x7f8000
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_GPT=y