| Message ID | 20241024152448.102-5-paul.barker.ct@bp.renesas.com |
|---|---|
| State | New |
| Delegated to: | Marek Vasut |
| Headers | show |
| Series | Add support for Ethernet interfaces on RZ/G2L | expand |
On 10/24/24 5:24 PM, Paul Barker wrote: > In rzg2l_pinconf_set(), there are no new variables defined in the case > statement for PIN_CONFIG_INPUT_ENABLE so no additional scope is needed. > > Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com> Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org> btw. it might make sense to split the series per subsystem so it can go in piece by piece.
On 27/10/2024 16:16, Marek Vasut wrote: > On 10/24/24 5:24 PM, Paul Barker wrote: >> In rzg2l_pinconf_set(), there are no new variables defined in the case >> statement for PIN_CONFIG_INPUT_ENABLE so no additional scope is needed. >> >> Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com> > Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org> > > btw. it might make sense to split the series per subsystem so it can go > in piece by piece. I could split this into clk (patch 1), pinctrl (patch 2-4), Ethernet phy (patch 5-8) and ravb prep patches (9-10), sent as independent series. The support for RZ/G2L Ethernet (patches 11 & 12) would have to wait until all those series are merged. The devicetree changes (patches 13 & 14) could be sent once the pinctrl patches are merged. I think that this would delay things and prevent RZ/G2L Ethernet support from landing in v2024.01, so I sent this as one series. I can break it up if needed though. Let me know what you would prefer. Thanks,
On 10/28/24 9:27 AM, Paul Barker wrote: > On 27/10/2024 16:16, Marek Vasut wrote: >> On 10/24/24 5:24 PM, Paul Barker wrote: >>> In rzg2l_pinconf_set(), there are no new variables defined in the case >>> statement for PIN_CONFIG_INPUT_ENABLE so no additional scope is needed. >>> >>> Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com> >> Reviewed-by: Marek Vasut <marek.vasut+renesas@mailbox.org> >> >> btw. it might make sense to split the series per subsystem so it can go >> in piece by piece. > > I could split this into clk (patch 1), pinctrl (patch 2-4), Ethernet phy > (patch 5-8) and ravb prep patches (9-10), sent as independent series. Yes please. > The support for RZ/G2L Ethernet (patches 11 & 12) would have to wait > until all those series are merged. The devicetree changes (patches 13 & > 14) could be sent once the pinctrl patches are merged. Or just include a patchwork links to the dependencies. > I think that this would delay things and prevent RZ/G2L Ethernet support > from landing in v2024.01, so I sent this as one series. I can break it > up if needed though. Let me know what you would prefer. Please break it up, I'll try to pick it into 2025.01 still. It is easier to pick it in more manageable chunks.
diff --git a/drivers/pinctrl/renesas/rzg2l-pfc.c b/drivers/pinctrl/renesas/rzg2l-pfc.c index af371bd0ff1e..3c751e9473a5 100644 --- a/drivers/pinctrl/renesas/rzg2l-pfc.c +++ b/drivers/pinctrl/renesas/rzg2l-pfc.c @@ -381,7 +381,7 @@ static int rzg2l_pinconf_set(struct udevice *dev, unsigned int pin_selector, } switch (param) { - case PIN_CONFIG_INPUT_ENABLE: { + case PIN_CONFIG_INPUT_ENABLE: if (!(cfg & PIN_CFG_IEN)) { dev_err(dev, "pin does not support IEN\n"); return -EINVAL; @@ -391,7 +391,6 @@ static int rzg2l_pinconf_set(struct udevice *dev, unsigned int pin_selector, port_offset, pin, argument); rzg2l_rmw_pin_config(data, IEN(port_offset), pin, IEN_MASK, !!argument); break; - } case PIN_CONFIG_POWER_SOURCE: { bool support_2500 = false;
In rzg2l_pinconf_set(), there are no new variables defined in the case statement for PIN_CONFIG_INPUT_ENABLE so no additional scope is needed. Signed-off-by: Paul Barker <paul.barker.ct@bp.renesas.com> --- drivers/pinctrl/renesas/rzg2l-pfc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)