| Message ID | 20231228052915.121433-1-gch981213@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Andre Przywara |
| Headers | show |
| Series | sunxi: add defconfig for nanopi_duo2 | expand |
On Thu, 28 Dec 2023 13:29:15 +0800 Chuanhong Guo <gch981213@gmail.com> wrote: Hi, thanks for taking care and sending a patch! > FriendlyElec NanoPi Duo2 is a tiny SBC with Allwinner H3 and > Ampak AP6212 WiFi module. The device-tree for it is already > available in u-boot source tree. Add a default config for it. > > Signed-off-by: Chuanhong Guo <gch981213@gmail.com> > --- > configs/nanopi_duo2_defconfig | 11 +++++++++++ > 1 file changed, 11 insertions(+) > create mode 100644 configs/nanopi_duo2_defconfig > > diff --git a/configs/nanopi_duo2_defconfig b/configs/nanopi_duo2_defconfig > new file mode 100644 > index 0000000000..5a2069789f > --- /dev/null > +++ b/configs/nanopi_duo2_defconfig > @@ -0,0 +1,11 @@ > +CONFIG_ARM=y > +CONFIG_ARCH_SUNXI=y > +CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-nanopi-duo2" > +CONFIG_SPL=y > +CONFIG_MACH_SUN8I_H3=y > +CONFIG_DRAM_CLK=408 > +# CONFIG_VIDEO_DE2 is not set > +# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set > +CONFIG_CONSOLE_MUX=y > +CONFIG_USB_EHCI_HCD=y > +CONFIG_USB_OHCI_HCD=y Judging by the DT, this board has USB-OTG wired up correctly, so we should enable it, by adding: CONFIG_USB_MUSB_GADGET=y This would allow access to USB Ethernet, fastboot or UMS devices, which prove to be quite useful for U-Boot. Cheers, Andre
On Sun, 21 Jan 2024 01:15:28 +0000 Andre Przywara <andre.przywara@arm.com> wrote: Hi, > On Thu, 28 Dec 2023 13:29:15 +0800 > Chuanhong Guo <gch981213@gmail.com> wrote: > > Hi, > > thanks for taking care and sending a patch! > > > FriendlyElec NanoPi Duo2 is a tiny SBC with Allwinner H3 and > > Ampak AP6212 WiFi module. The device-tree for it is already > > available in u-boot source tree. Add a default config for it. > > > > Signed-off-by: Chuanhong Guo <gch981213@gmail.com> > > --- > > configs/nanopi_duo2_defconfig | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > create mode 100644 configs/nanopi_duo2_defconfig > > > > diff --git a/configs/nanopi_duo2_defconfig b/configs/nanopi_duo2_defconfig > > new file mode 100644 > > index 0000000000..5a2069789f > > --- /dev/null > > +++ b/configs/nanopi_duo2_defconfig > > @@ -0,0 +1,11 @@ > > +CONFIG_ARM=y > > +CONFIG_ARCH_SUNXI=y > > +CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-nanopi-duo2" > > +CONFIG_SPL=y > > +CONFIG_MACH_SUN8I_H3=y > > +CONFIG_DRAM_CLK=408 > > +# CONFIG_VIDEO_DE2 is not set > > +# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set > > +CONFIG_CONSOLE_MUX=y > > +CONFIG_USB_EHCI_HCD=y > > +CONFIG_USB_OHCI_HCD=y > > Judging by the DT, this board has USB-OTG wired up correctly, so we > should enable it, by adding: > CONFIG_USB_MUSB_GADGET=y > This would allow access to USB Ethernet, fastboot or UMS devices, which > prove to be quite useful for U-Boot. So I merged this patch, after adding the USB_MUSB_GADGET option. I just see that the CI complained about a missing maintainer entry, I will fix this up in a follow-up patch. Thanks, Andre. > > Cheers, > Andre
Hi! On Tue, Jan 30, 2024 at 12:56 AM Andre Przywara <andre.przywara@arm.com> wrote: > > > Judging by the DT, this board has USB-OTG wired up correctly, so we > > should enable it, by adding: > > CONFIG_USB_MUSB_GADGET=y > > This would allow access to USB Ethernet, fastboot or UMS devices, which > > prove to be quite useful for U-Boot. > > So I merged this patch, after adding the USB_MUSB_GADGET option. > I just see that the CI complained about a missing maintainer entry, I will > fix this up in a follow-up patch. Oops. I forgot to follow up your previous email. This board does have a working USB OTG port. Thanks for fixing the patch for me!
diff --git a/configs/nanopi_duo2_defconfig b/configs/nanopi_duo2_defconfig new file mode 100644 index 0000000000..5a2069789f --- /dev/null +++ b/configs/nanopi_duo2_defconfig @@ -0,0 +1,11 @@ +CONFIG_ARM=y +CONFIG_ARCH_SUNXI=y +CONFIG_DEFAULT_DEVICE_TREE="sun8i-h3-nanopi-duo2" +CONFIG_SPL=y +CONFIG_MACH_SUN8I_H3=y +CONFIG_DRAM_CLK=408 +# CONFIG_VIDEO_DE2 is not set +# CONFIG_SYS_MALLOC_CLEAR_ON_INIT is not set +CONFIG_CONSOLE_MUX=y +CONFIG_USB_EHCI_HCD=y +CONFIG_USB_OHCI_HCD=y
FriendlyElec NanoPi Duo2 is a tiny SBC with Allwinner H3 and Ampak AP6212 WiFi module. The device-tree for it is already available in u-boot source tree. Add a default config for it. Signed-off-by: Chuanhong Guo <gch981213@gmail.com> --- configs/nanopi_duo2_defconfig | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 configs/nanopi_duo2_defconfig