From patchwork Tue Jul 9 07:58:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1958225 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20230601 header.b=CNzKS3Kz; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::33e; helo=mail-wm1-x33e.google.com; envelope-from=swupdate+bncbd2zdgn6sekrblo3wo2amgqeal4z7uy@googlegroups.com; receiver=patchwork.ozlabs.org) Received: from mail-wm1-x33e.google.com (mail-wm1-x33e.google.com [IPv6:2a00:1450:4864:20::33e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WJCzn5sknz1ySg for ; Tue, 9 Jul 2024 17:58:44 +1000 (AEST) Received: by mail-wm1-x33e.google.com with SMTP id 5b1f17b1804b1-426703ac975sf3528175e9.0 for ; Tue, 09 Jul 2024 00:58:44 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1720511919; cv=pass; d=google.com; s=arc-20160816; b=0sDQuHi9DKK29lTISfifpgmAen8Nq5mt6oyPX7J4yL232Cq8xSCFx9+lmj7nglaohR 6GiBNWcGJDhxGKiO1k/9tWEr0YjlvU2SYr7BAKot/QUpoIBsR/SKcHFDzDH5bDL91qLX RSfHZkK5fYDnny6Ta/hIwzEjKE9YBoqJNIcTMHBQC6Dm4DxtZpdBjbH5WxWSIQ6zQqCl fL8rCubyeKSjLjLltg0kFFVJrIB/IKeuNwJnZLlQzluKyQjky8kOiPdAm8KJkLpsRYx3 1NQ44xWuMmRdxVehaBIyAXOMa59Wbwwg/P2pIRy3WW3lknfSlyKfpCV6EVM28Sn1JP5g KtJQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:ui-outboundreport:mime-version :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=j32h6DU7FrujAp3LtmaA+E81iKBRAvE8t1Ay7+46K5o=; fh=PMmCjjGdAMH/kzie9eYaQNAhrRMFRtixLhGcDjmEWu8=; b=l/59XgOBA1dGCV5eNEba5lsKkM89K+ZwaS2xN/6juuCc9vNi9fDNrJXGDUA4QUOm4T 4b7jGaWHcnRLBJO0RwTKIwCb5xcuHhlXsUcp279M4zZ5sIftqGLYEuhRaoNQeRHBrT0R GEPlMmxVqINa34SYNDohG3ATDe4ydBWIDIjdhoQCuyG0Tl64/k7Wf9qRVy97rO+8hI5d EoNyGWgDzAFcOibxPyrewCc2ma2TCpzUHcu0KpRwa7JDxFjOTAHAVU1FJm3h5Itj/02t M1D3Tb7DHlmwXvcm4CsVuuEEEdu3ZcFfxqFbVyCziSFuTdC6C62mdA9DVl0wA9ZT4zYz miKg==; darn=patchwork.ozlabs.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=LI95ERMG; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.131 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1720511919; x=1721116719; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:ui-outboundreport:mime-version:message-id:date :subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=j32h6DU7FrujAp3LtmaA+E81iKBRAvE8t1Ay7+46K5o=; b=CNzKS3Kz8snKYOW0Zt5PI/hC92Ct66+vAojCudbYerBDvpx62R4j6Jvh3okXnJF/zV 8RtEozWY/AN73o1CNOz29dCseak2k2p77YFYUZbrXgsa+zu56WL9xExKT/dMSdZo5f7H Byvze8PRgQPioxgOL4fV36+cbk2kWG+CzklEn17B3BAJbsFbKep/HirWHJsxdpKgiQZx Lxf+zXPINfTTq2RgpNvsGbqLrYUiyv5yT4B7as5yK2QCtPvk+C2elVcYPqthBCuMUD4Y HMonbqXQBulvpxqLZRFEp5aa22XJkAsfmumKi8M0s/XuBTIdjvCBDxxZDv663FTlFAfK TM7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720511919; x=1721116719; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :ui-outboundreport:mime-version:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:sender:from:to:cc:subject:date :message-id:reply-to; bh=j32h6DU7FrujAp3LtmaA+E81iKBRAvE8t1Ay7+46K5o=; b=AMRshreR26M7UFD0/2FG4EPElNJI8LOAgYDY46a4zZcZL34hsJOgerPtth//xNXHod 2kqFzqWBHdAAoRdu7R+z4MMdIypgyOVHp7d5ek+8iOxQBJVoWRDNW6SgEQa91RbgEP6i MTMtGVMzyY1JYG4+zoVy7ZbXkTs8Ns5eYExd/4O0LMCHsiYpzgmP/BeprKrR+oi+t+I6 cKA7az2EUjkZHkoKDd4dJWor7UZsGTqrQYPd0jJK8yFTJ5VEUsJsuMAp6NXn6Swv06ET YA3i0vEl7hAOWIKT+CBRI3w8dBBj2IF6M0SmptCL9Af/HeHXDniOI71kDpI6ymj1whjP uNPw== Sender: swupdate@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCVwFwvPI83Ep+D1rQZFRjTF/UJs4/oic83y6z3gwiWl6Jg4LgDnHogDCv92LYQwOyVSQv331WIhjTmMhGFU9U1AYMsvdh+jJ2eEtuwGyQ== X-Gm-Message-State: AOJu0Ywpk73++AZcLv+CFoLXCr65cx74qENCa+lDfARFSMgaWC0FHLuD knJyRVEDElgSBYWgw6BwzwhJWjGEYLK45lzGeKbhkUTa+YT2R3/I X-Google-Smtp-Source: AGHT+IGOIAlRwTWIkOBAmQDPe9XG6YWlKzivYDOR0US3XViLuJOndCzSnYyszwLMtCkx+VXxXN4u1g== X-Received: by 2002:a05:600c:4348:b0:426:711c:6591 with SMTP id 5b1f17b1804b1-426722c12b1mr11371535e9.4.1720511918585; Tue, 09 Jul 2024 00:58:38 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a05:600c:1c87:b0:426:ab3f:fafd with SMTP id 5b1f17b1804b1-426ab3ffcccls1179025e9.0.-pod-prod-00-eu; Tue, 09 Jul 2024 00:58:36 -0700 (PDT) X-Received: by 2002:a05:600c:424a:b0:426:6f0e:8ba4 with SMTP id 5b1f17b1804b1-426722ccc5cmr11624535e9.8.1720511915785; Tue, 09 Jul 2024 00:58:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720511915; cv=none; d=google.com; s=arc-20160816; b=lQy6xFKe18uWUurG19fFRxybeV77hfNnLbZ62aVuFKJFSijW7GXgDa7cxX5EPo/D2H IO+pIpejWQ4j8qJLmTZ3l+4vDBRS67XsdYP9mgvgYs+46zAFfK3rh+5Pux40CIBhKvN4 3TBkQON/PlYTiJGx3SpHQ4/yaZX1qNQ/A4kX9KxgP0G471rbeUUN5KLOj/gJ5945b211 EnQfKJcHaRTAX3XJDD80FciSLFXSEVv+PjzdrjCn1SlsiKN0hxG+6YH8e3Zg6//F5v+9 mcIdqkLgUq89+Zb+wApAt2lQL26oPgPSEDIfAg+BDl2YFUJhSr+B05KEQXV86DPE1atz Zz1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:mime-version:message-id :date:subject:cc:to:from:dkim-signature; bh=5svw3dq3IqqNVTVh4uxOLA7pVUgbzJNj6ZhrGIo4+24=; fh=TiEWcqMcKpHk5s7uErzpntoONrNfOXwKpI5P8bIlggk=; b=ZNmzP5CXdbBVnhUt5SIKIiz2+UAf5MPgl8l9+zLpxA6wGvXb3F30a3rJeRxNRBFN65 gsLy/aX4xwES6xmuv5hGQ/iicgYyOANXziFQlxIwJ8s3smBhrQ5lu11Gn0pe5K29IWci 1JnhwP6BDZKoOpcNu3Lx9OmlSGvNuOZyR8YASeHtuvrpVTOHb+3fz7AQSDNlyR0khxIL 3dT3qpDkW5sUKZ1Gtr2GrFaO5WpKkk4KBlIk/jvotbdkiNfoEyWK1iP2Zy3tbucv/eza VRcuUJf2kYiKbNCdHFnuUw7Mq7HPk7gW7ubjU4dXueoGYygQkgXajo3Fpt30AAHHaPWV cYcg==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=LI95ERMG; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.131 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org Received: from mout.kundenserver.de (mout.kundenserver.de. [212.227.126.131]) by gmr-mx.google.com with ESMTPS id 5b1f17b1804b1-426725595b4si507145e9.0.2024.07.09.00.58.35 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 00:58:35 -0700 (PDT) Received-SPF: pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.131 as permitted sender) client-ip=212.227.126.131; X-UI-Sender-Class: 55c96926-9e95-11ee-ae09-1f7a4046a0f6 Received: from paperino.fritz.box ([88.217.136.221]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.97]) with ESMTPSA (Nemesis) id 1MDhpf-1sZZvA0cMx-00ECkv; Tue, 09 Jul 2024 09:58:35 +0200 From: Stefano Babic To: swupdate@googlegroups.com Cc: Stefano Babic Subject: [swupdate] [PATCH 1/2] Degrade to WARN if a var is not found in env Date: Tue, 9 Jul 2024 09:58:32 +0200 Message-Id: <20240709075833.2345799-1-stefano.babic@swupdate.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:COcNJgTmUARhkSjV4VM80T/KAv7oKbkiT5TzzE5qTjhs/Kg3kO4 yo2mqdYkzoGLJzbyv9HXZWA90GOKxpcdEt5NM8dpkLL/m8rIUvJU7RgreFOJRfEHU1OTxWE 59iTW3jXTOs1Y49ku9o1b0DqZUXQd4QjJFm+mmYDMxGcDZHt3XDBkSIrErCIbyRY9uVTWg4 ZkhR1QSSsjO78gORVftcg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:8emMPYP0Xmg=;jIIoNDHG7F7EMHmOpbFtLBXlpwW 7GANxpixXzjAmJXg5YnqZFx6bGIE+qOjoYoNgXEppl3PYazbCxh/E/wn1GzkLG59YudTqdmhN hYNFpg39kXKRLxS7AWOuBYm5xA3a+sGhonU/GdQA67ZjXKtLqTZIaGk0AkOkwJ8z4td3N0+fT Q3QjN+1mdRc3ns1rYkHdieGfilqg6SJ4rM7wsluRkg/SBfsf3mXBntM6hMM13ud/eE/JttWEg 9vtjc670Ol1MIDhbBBYDYhcYQi5cIVWW4mouRLyCMn/vE6hupJdwXUgagYf5C3IAKrVVisqYD k/hw4G0Iv8S5AgQ+QZcRkrF7T/O9nZ/YllK8UuZbceH/ljSejUq19tmCs900N+cMXVOtW33Dg MY1Vk5LR2kFp0GPCUZmjESU4QFqsqcYMF3jCtJww/OZlw7xvqw/NDvSNsGksUEdmHkZvh+4VK fPt2hBZSAH4BF2KDG6wkCiQecXaAxTZH7sBOv0OXpWPpHwOSwJnFjq/I+uugXkw0EtepEhbZp CxchFSPPnWZGBqR9GvzmFLL6CXedhAIn6kcaGbZrOMnNMqmlAUiW+clSPkFzCQ/7QmU+xY86u Vz2rmqhb87U4YNv+cOqhlbTsiPTsxubbyFwLjUfoVJ7CdWxqTBslxzBr5ge4Poiwa1MQqMuPL 3aKc7tsxA+oW7gPOoaGLQVQ2TlBksQvt9Q7GWPv1FCoFM+mVsowcPVzyoU1elmxq1x7yXLG7L /I2CLrEy90DCiN77yH90YtcyzTboZRu8koap9sh46bNhNrVga0QlTU= X-Original-Sender: stefano.babic@swupdate.org X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=LI95ERMG; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.131 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , This is not always an error, so move it to WARN. Signed-off-by: Stefano Babic --- core/swupdate_vars.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1 diff --git a/core/swupdate_vars.c b/core/swupdate_vars.c index 081e6097..b2074946 100644 --- a/core/swupdate_vars.c +++ b/core/swupdate_vars.c @@ -90,7 +90,7 @@ char *swupdate_vars_get(const char *name, const char *namespace) strlcpy(msg.data.vars.varname, name, sizeof(msg.data.vars.varname)); if (ipc_send_cmd(&msg) || msg.type == NACK) { - ERROR("Failed to get variable %s", name); + WARN("Failed to get variable %s", name); return NULL; } return strdup (msg.data.vars.varvalue);