diff mbox series

[2/2] network_thread: remove old DEBUG_IPC ifdefs

Message ID 20240708001523.3974741-2-dominique.martinet@atmark-techno.com
State Accepted
Headers show
Series [1/2] misc: remove double-semicolons | expand

Commit Message

Dominique Martinet July 8, 2024, 12:15 a.m. UTC
These ifdef are no longer used and do not even work correctly (manually
defining DEBUG_IPC will dead lock on msglock); remove them.

Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
---
 core/network_thread.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Stefano Babic July 8, 2024, 10:14 a.m. UTC | #1
On 08.07.24 02:15, Dominique Martinet wrote:
> These ifdef are no longer used and do not even work correctly (manually
> defining DEBUG_IPC will dead lock on msglock); remove them.
>
> Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com>
> ---
>   core/network_thread.c | 6 ------
>   1 file changed, 6 deletions(-)
>
> diff --git a/core/network_thread.c b/core/network_thread.c
> index d7b713fb2154..b70fa12cf4ee 100644
> --- a/core/network_thread.c
> +++ b/core/network_thread.c
> @@ -424,9 +424,6 @@ void *network_thread (void *data)
>   			close(ctrlconnfd);
>   			continue;
>   		}
> -#ifdef DEBUG_IPC
> -		TRACE("request header: magic[0x%08X] type[0x%08X]", msg.magic, msg.type);
> -#endif
>
>   		should_close_socket = true;
>   		pthread_mutex_lock(&stream_mutex);
> @@ -513,9 +510,6 @@ void *network_thread (void *data)
>   					nrmsgs--;
>   					strncpy(msg.data.status.desc, notification->msg,
>   						sizeof(msg.data.status.desc) - 1);
> -#ifdef DEBUG_IPC
> -					DEBUG("GET STATUS: %s\n", msg.data.status.desc);
> -#endif
>   					msg.data.status.current = notification->status;
>   					msg.data.status.error = notification->error;
>   				}

Applied to -master, thanks !

Best regards,
Stefano
diff mbox series

Patch

diff --git a/core/network_thread.c b/core/network_thread.c
index d7b713fb2154..b70fa12cf4ee 100644
--- a/core/network_thread.c
+++ b/core/network_thread.c
@@ -424,9 +424,6 @@  void *network_thread (void *data)
 			close(ctrlconnfd);
 			continue;
 		}
-#ifdef DEBUG_IPC
-		TRACE("request header: magic[0x%08X] type[0x%08X]", msg.magic, msg.type);
-#endif
 
 		should_close_socket = true;
 		pthread_mutex_lock(&stream_mutex);
@@ -513,9 +510,6 @@  void *network_thread (void *data)
 					nrmsgs--;
 					strncpy(msg.data.status.desc, notification->msg,
 						sizeof(msg.data.status.desc) - 1);
-#ifdef DEBUG_IPC
-					DEBUG("GET STATUS: %s\n", msg.data.status.desc);
-#endif
 					msg.data.status.current = notification->status;
 					msg.data.status.error = notification->error;
 				}