From patchwork Mon Jul 8 00:15:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dominique Martinet X-Patchwork-Id: 1957779 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20230601 header.b=Tc13Qu/H; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2607:f8b0:4864:20::13d; helo=mail-il1-x13d.google.com; envelope-from=swupdate+bncbcwivbv7sugrbkg7vs2amgqecgu5zky@googlegroups.com; receiver=patchwork.ozlabs.org) Received: from mail-il1-x13d.google.com (mail-il1-x13d.google.com [IPv6:2607:f8b0:4864:20::13d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4WHPly2wdrz1xrJ for ; Mon, 8 Jul 2024 10:15:41 +1000 (AEST) Received: by mail-il1-x13d.google.com with SMTP id e9e14a558f8ab-3835c6e5763sf40944575ab.3 for ; Sun, 07 Jul 2024 17:15:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1720397737; cv=pass; d=google.com; s=arc-20160816; b=eTw5RXTVOEUhapvOont8R3GJQgTx48eAnVPNi/LijQ3Rv8SzsRvDlYjtlphdRZQ3FB gn5RXcbFJ5XBXbyzbCjSrknd2Lkn+E/j0ABw0x9pm8/rmpKYacKPA6kwJB2wPknwgcL8 AMAUoaZLcOBdjH+ZFAjEIwXyEm3igIMWKaHz4EfSBhelY2o4b9ztcgHYWYu+fahjd3+L kUQez6+Psc0bBFSNds3yuDKR5pJ6yoLrLJUK80ryECyDtT+vPlYrqQo/vSDjGewseh6k HFBUF2mGtDoJWO76L0xTaHiBe51Qu394417PDxCO8dTrbzZ2voPrOOy6x877vE1b1vE8 NZgg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature; bh=iKUxWHl1qAaCIEAbvxc3slgI6Emu2uOpCuukilAlsP4=; fh=3bpubOjK9duYmd05+n1uUcTgFyZfTIG9hnl12Nsw7xY=; b=q4apTAB0d5tDQWiEeKYJk+9ZE/+27U/LjbWuw4QSMpy0TgM4kdA9o/cVCQGlfkMZUA U3ywQ+FKjKPWGMbdistNblHZzslsgNvvFUZncjccjuFG/B9llUr7r3Wlc547K4hCNlmQ XU7Ua39VwClAbQY50A1EhHeV0Xwf6wZE8erFPOMNsVdS5zuSQsbxmEqKs8QL5S4W4KPW zn1q46BMY0QuC6WhwIeQQxfTaAQbSWzP/B3/2zQHWBfOZyELiNBJy+shVHozqROWF03d XTJEBqO64mg0hsNKqXNu1Sdf2Pn14uBLW2QY5nKHbP5Zypc4JczQMHUcOMSQ2/iEd2wf vPHQ==; darn=patchwork.ozlabs.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@atmark-techno.com header.s=gw2_bookworm header.b=hozjc976; dkim=pass header.i=@atmark-techno.com header.s=google header.b=X5j+mCrC; spf=pass (google.com: domain of dominique.martinet@atmark-techno.com designates 35.74.137.57 as permitted sender) smtp.mailfrom=dominique.martinet@atmark-techno.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=atmark-techno.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1720397737; x=1721002537; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:message-id:date:subject:cc:to:from :sender:from:to:cc:subject:date:message-id:reply-to; bh=iKUxWHl1qAaCIEAbvxc3slgI6Emu2uOpCuukilAlsP4=; b=Tc13Qu/H1FqTzz0DkbqiPZqaAefg+73DbKnhoD49KRnMfYp5u+zXifNGatf2Y3IihL qgBkuEXxT5jpUzNGpZekCIT2MlZg/JPEnkh5d1gV1iYxZ2ierIA0glyE838prjGeNHRq b1cEVwRJOr9oae0vbZa467zJixL1Tblij8fiUsheSSpcGgpKDSP4XBA5LbQAoBjj3wQz EeUM1eB+pMdLThWZJCbDWPxGOD4gjxqmjAFJRJBpYoxEXmLQklHFmHTiGw5kHucC96T0 7RDMkHZDDidgNv/DYETYNBVu6GSW4vNzyWxUd9sOdfW5M8/b1/eWWKsALWX+VPPOKRF/ uYWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720397737; x=1721002537; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :message-id:date:subject:cc:to:from:x-beenthere:x-gm-message-state :sender:from:to:cc:subject:date:message-id:reply-to; bh=iKUxWHl1qAaCIEAbvxc3slgI6Emu2uOpCuukilAlsP4=; b=NK2lLF6pJBV3sx9ML9pUIZAtpQblJ6JCMLFxJC/pos/JmWEm0Sy0RmbFvszPcjl+/o TrfWE99tRgV3fSk80mOiND1mBWLICQ4APmjU9uRg+G4m+EMtT2cEa2XLwLo3s5M3yUyN M3VMihY/y0RnoxVhXS+RfRX+GkubjTu+5Iuqq8oNl3mCOyyNhSdSGZVjfTi2b5LX49xj 6PEDGBTWrubSAtgPxLALodzONIOrD0q7lfDIIjDz6vqzaTILM6bjaNzz6XHb2mY/gahY 19W+HwinWx/EF7iuMcuQrPKSt30w4G6m0Y6YPZnJ1iC88RMEx8sx7m9b/IR40SZ+R7EC o12w== Sender: swupdate@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCX5CpM2W6DUF2ZVMrWQp30BtMCnBIqkjZ3b+yeJv4juBpd5ZdWR02dX7szN5o5VS+/joqFuXJ4CTrPBv+nhEtZi4Wy0N3D8XZ3x9qWT0g== X-Gm-Message-State: AOJu0YwlNWX9ji7hYUh/VWU7MDx2twIRCM118R67K9q4+l0wxPDN6dQe 6Vq363/6bGZsz2VxQCY3bqahzs6RYrKH4XGo2nMMFtwwd3tdZzZ2 X-Google-Smtp-Source: AGHT+IEffyER3g04b3FjeGuHxcFziKBfNnv6VG4boHRY028zI1hSyjk6k1xsMgtbFoqGKJdxCxU98A== X-Received: by 2002:a05:6e02:1d9b:b0:376:1299:81e8 with SMTP id e9e14a558f8ab-3839b0996f9mr140179215ab.28.1720397736564; Sun, 07 Jul 2024 17:15:36 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a05:6e02:198c:b0:375:b4b8:975b with SMTP id e9e14a558f8ab-38374208367ls27877055ab.2.-pod-prod-01-us; Sun, 07 Jul 2024 17:15:35 -0700 (PDT) X-Forwarded-Encrypted: i=2; AJvYcCVQlK4mE6b8UTYIV2UCRF/QtGO/T60Dz6WZU9Lp+kRXIeuJeuSPjFLjJkmYfVymhl8w9smnsZipx6WhB7cYn69Bn82DoBPLHCw/ X-Received: by 2002:a6b:4f05:0:b0:7fc:89ed:c15d with SMTP id ca18e2360f4ac-7fc89edc50fmr177266139f.13.1720397734902; Sun, 07 Jul 2024 17:15:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1720397734; cv=none; d=google.com; s=arc-20160816; b=itM1m66m0bk6uhimeAAxw49r/3WZ1CK63jY72t8Xi3Gu3XVB/77dw/gAe1rZfDaaDR TcjvFoQok9RV3vjlCdkCbKbic/y3NbcrvSC/HWfVWJxGljpOb8yr3YNmtMz+DS575CBf irVo5D67Noey5DlO4LzGBqzq/5N1BXgjUZ2zP934LXQOaNBulgKtBwpefQDUhJut+4pE 3/5kP3PXmsGKSJ2ChZZK9ebR2KK+KzqRlX8u+aKW135yp4QCp9Zw707jtaj9WCjY9SUO EL2XkyS7wveRXRuuuwWVPfJpzoxc8dOfJVRzGIH34+9yYjkXVw72qyvhteSU+1DIiGNj yNEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature:dkim-signature; bh=XYfMIcak7GW4VvMGLT18nLTUtT45DfFl9klzxXEImsM=; fh=VxtOdYtcwLK+M5N3M0oXJwATmiKF/WF4ju3H9TzqMCE=; b=GgWVY6XNrdkik5ArKZEtA7T6oouivyzNKPPq8pJp19py3uI02ISb4oX5EYrFxKy1ie Iz/l6BWkHpyloFp5CB+2qBMA2X3y+4uaxf2vBKUCXjDCflp0+lXxRQUaNkWNgDK4cqVB zwvI3VZ3klXAL6DkbIfpB41AzEbKpXj3g/BsjNTjzhhy9KYdVIyp3/bIwI2+tKmjflOm mi2uXxm7/WfM6DcDVPf9854FIhHID/kTxZvOcBrtUEDoP2Je14Y7gTXiB4diE7funN9a VxDoJkTI/TaL/7Y/arWO2gAHJv0YrIKWYrOIxNUnGjorbUDUNB3xInnK3dratOvE1Hzl rKKw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@atmark-techno.com header.s=gw2_bookworm header.b=hozjc976; dkim=pass header.i=@atmark-techno.com header.s=google header.b=X5j+mCrC; spf=pass (google.com: domain of dominique.martinet@atmark-techno.com designates 35.74.137.57 as permitted sender) smtp.mailfrom=dominique.martinet@atmark-techno.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=atmark-techno.com Received: from gw2.atmark-techno.com (gw2.atmark-techno.com. [35.74.137.57]) by gmr-mx.google.com with ESMTPS id 8926c6da1cb9f-4c07ee6d7f5si238304173.0.2024.07.07.17.15.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Jul 2024 17:15:34 -0700 (PDT) Received-SPF: pass (google.com: domain of dominique.martinet@atmark-techno.com designates 35.74.137.57 as permitted sender) client-ip=35.74.137.57; Received: from gw2.atmark-techno.com (localhost [127.0.0.1]) by gw2.atmark-techno.com (Postfix) with ESMTP id 877FA35A for ; Mon, 8 Jul 2024 09:15:32 +0900 (JST) Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by gw2.atmark-techno.com (Postfix) with ESMTPS id 3AAC8355 for ; Mon, 8 Jul 2024 09:15:32 +0900 (JST) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1fb90d7a4c3so617605ad.1 for ; Sun, 07 Jul 2024 17:15:32 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUhMYdnw5Yo7OKpnarZbhAiusnD1uHIwtDfLVXjwaS8TlsjEkgg7nSwvcOPXqkjZ/9txhl/XOQQ8DHn5eFskFfvgDXfFm6EkfK7 X-Received: by 2002:a17:902:f690:b0:1f7:1b42:431d with SMTP id d9443c01a7336-1fb33e7a014mr72184055ad.30.1720397731198; Sun, 07 Jul 2024 17:15:31 -0700 (PDT) X-Received: by 2002:a17:902:f690:b0:1f7:1b42:431d with SMTP id d9443c01a7336-1fb33e7a014mr72183955ad.30.1720397730851; Sun, 07 Jul 2024 17:15:30 -0700 (PDT) Received: from pc-0182.atmarktech (145.82.198.104.bc.googleusercontent.com. [104.198.82.145]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fb4a96b304sm47935135ad.251.2024.07.07.17.15.30 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Jul 2024 17:15:30 -0700 (PDT) Received: from [::1] (helo=pc-0182.atmark.tech) by pc-0182.atmarktech with esmtp (Exim 4.96) (envelope-from ) id 1sQc2S-00Gg1O-24; Mon, 08 Jul 2024 09:15:28 +0900 From: Dominique Martinet To: stefano.babic@swupdate.org, swupdate@googlegroups.com Cc: Dominique Martinet Subject: [swupdate] [PATCH 1/2] misc: remove double-semicolons Date: Mon, 8 Jul 2024 09:15:22 +0900 Message-Id: <20240708001523.3974741-1-dominique.martinet@atmark-techno.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Original-Sender: dominique.martinet@atmark-techno.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@atmark-techno.com header.s=gw2_bookworm header.b=hozjc976; dkim=pass header.i=@atmark-techno.com header.s=google header.b=X5j+mCrC; spf=pass (google.com: domain of dominique.martinet@atmark-techno.com designates 35.74.137.57 as permitted sender) smtp.mailfrom=dominique.martinet@atmark-techno.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=atmark-techno.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , The previous commit 9ef80aefd354 ("hawkbit: fix process notification not sending logs") introduced a typo using two semicolons after a statement. While looking I also found another one. This is not harmful, but is bad style: remove them. Signed-off-by: Dominique Martinet --- core/artifacts_versions.c | 2 +- suricatta/server_hawkbit.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/core/artifacts_versions.c b/core/artifacts_versions.c index 3ac50351a6ce..b75ac7c97c27 100644 --- a/core/artifacts_versions.c +++ b/core/artifacts_versions.c @@ -200,7 +200,7 @@ static bool is_oldstyle_version(const char *version_string, __u64 *version_numbe return false; ++ver; } - return version_to_number(version_string, version_number);; + return version_to_number(version_string, version_number); } /* diff --git a/suricatta/server_hawkbit.c b/suricatta/server_hawkbit.c index 2f7562c543db..9d71a3186e93 100644 --- a/suricatta/server_hawkbit.c +++ b/suricatta/server_hawkbit.c @@ -1004,7 +1004,7 @@ static void *process_notification_thread(void *data) if (ret < 0) { ERROR("Error getting status, stopping notification thread"); - stop = true;; + stop = true; } else { data_avail = (strlen(msg.data.status.desc) != 0); }