| Message ID | 20240708001523.3974741-1-dominique.martinet@atmark-techno.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/2] misc: remove double-semicolons | expand |
On 08.07.24 02:15, Dominique Martinet wrote: > The previous commit 9ef80aefd354 ("hawkbit: fix process notification not > sending logs") introduced a typo using two semicolons after a statement. > > While looking I also found another one. > > This is not harmful, but is bad style: remove them. > > Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com> > --- > core/artifacts_versions.c | 2 +- > suricatta/server_hawkbit.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/core/artifacts_versions.c b/core/artifacts_versions.c > index 3ac50351a6ce..b75ac7c97c27 100644 > --- a/core/artifacts_versions.c > +++ b/core/artifacts_versions.c > @@ -200,7 +200,7 @@ static bool is_oldstyle_version(const char *version_string, __u64 *version_numbe > return false; > ++ver; > } > - return version_to_number(version_string, version_number);; > + return version_to_number(version_string, version_number); > } > > /* > diff --git a/suricatta/server_hawkbit.c b/suricatta/server_hawkbit.c > index 2f7562c543db..9d71a3186e93 100644 > --- a/suricatta/server_hawkbit.c > +++ b/suricatta/server_hawkbit.c > @@ -1004,7 +1004,7 @@ static void *process_notification_thread(void *data) > > if (ret < 0) { > ERROR("Error getting status, stopping notification thread"); > - stop = true;; > + stop = true; > } else { > data_avail = (strlen(msg.data.status.desc) != 0); > } Applied to -master, thanks ! Best regards, Stefano
diff --git a/core/artifacts_versions.c b/core/artifacts_versions.c index 3ac50351a6ce..b75ac7c97c27 100644 --- a/core/artifacts_versions.c +++ b/core/artifacts_versions.c @@ -200,7 +200,7 @@ static bool is_oldstyle_version(const char *version_string, __u64 *version_numbe return false; ++ver; } - return version_to_number(version_string, version_number);; + return version_to_number(version_string, version_number); } /* diff --git a/suricatta/server_hawkbit.c b/suricatta/server_hawkbit.c index 2f7562c543db..9d71a3186e93 100644 --- a/suricatta/server_hawkbit.c +++ b/suricatta/server_hawkbit.c @@ -1004,7 +1004,7 @@ static void *process_notification_thread(void *data) if (ret < 0) { ERROR("Error getting status, stopping notification thread"); - stop = true;; + stop = true; } else { data_avail = (strlen(msg.data.status.desc) != 0); }
The previous commit 9ef80aefd354 ("hawkbit: fix process notification not sending logs") introduced a typo using two semicolons after a statement. While looking I also found another one. This is not harmful, but is bad style: remove them. Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com> --- core/artifacts_versions.c | 2 +- suricatta/server_hawkbit.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)