From patchwork Sat Jun 15 19:11:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Glembotzki X-Patchwork-Id: 1948204 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20230601 header.b=YRkZ1HxX; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Z13nh2Fy; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::337; helo=mail-wm1-x337.google.com; envelope-from=swupdate+bncbdy5juxlviebb5osw6zqmgqegghrmeq@googlegroups.com; receiver=patchwork.ozlabs.org) Received: from mail-wm1-x337.google.com (mail-wm1-x337.google.com [IPv6:2a00:1450:4864:20::337]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4W1mFS67C7z20fS for ; Sun, 16 Jun 2024 05:20:28 +1000 (AEST) Received: by mail-wm1-x337.google.com with SMTP id 5b1f17b1804b1-421f3b7b27esf28219775e9.1 for ; Sat, 15 Jun 2024 12:20:28 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1718479222; cv=pass; d=google.com; s=arc-20160816; b=uSechhfeMYpkGGGkx9jw0CG0XtQ0kOarAsc2JcboZpbATNAOvNMACqPzfqKT8RiBpQ V8VT/62JVSH8GdgmJjb9ptmwkNqPwuAq+5cl4kZNvGuDVRjSlqJm4nn78vFlKXREkRMv NjVB+5sPpdt9HaR5OR93jAJ5nL2EyHmtzqCtGP3vJ5Ncqmqo9jxajXlp0ZUXPpLbJJBW mUy/KZf1xv7XRa463ArVQaRdRELHDfRBZHC8Z2MDuqp7eHlR+E9oMEEjVS9HFDEdf44G WYCEdpf6I+wsWRWNONPNS541Qi0pIHQKnZYIEwA+FMcI8/B7/7s18xlm7Vh+pIOBfw+Z 1XsA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature :dkim-signature; bh=KYeXW377gBe9+2cO4oghdHMMMAVt7c6MqaZiyFhEg6U=; fh=VBHPtygCbH5lEGlycD0leIno2hZaCgtoO8Nqrhjx7/U=; b=jFg5xs2gAtgdZBWMhkx8sZgWYAXa+sltVCyJae5BZBIbKxs6twemOBaQI+7k9XqFTS WbSIXzF9bbeXt0RVVl0Jzo/SDsiuFxXMJn1KLhK6b/krT9IsjZhH2SRFVB42zosBKvou E+UBRD3TkEOoNv9nwy5ifHipcDSm8qk8Lo3JcS4JYYn0MfJHKWfqEn7ApT37mMejYH46 KOxMUEK3qFB5As6txq6hRT3snSrhSChVxDHZVlEv/bcDdrpRkxj6uHbYSAlIfL0fvFv9 e4inPmKCRfUApBtkkpNjq+x4//9mGnqnn/LHAspfd6RBiEiQnXN9ys5KG4EKBYinMv0K NN5g==; darn=patchwork.ozlabs.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=LI7UcPb5; spf=pass (google.com: domain of m.glembo@gmail.com designates 2a00:1450:4864:20::22f as permitted sender) smtp.mailfrom=m.glembo@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1718479222; x=1719084022; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=KYeXW377gBe9+2cO4oghdHMMMAVt7c6MqaZiyFhEg6U=; b=YRkZ1HxXSIrI2J6eJAfyvoGMGb78afUAe1dHpJrWy+RBs/Eqc47tyEe2gvjTd6azyx J0bDgw5x6PZPE2r3fCBvK8hiSXZ6wM5Uu1yLELwbFhFFWYj6ndINOa9XmUSeNSWOJx0A A8ouGY00iQX8OYd1poO7/HGg76FN1WKFGmvf4NdGPkcZZ6c6nhe9QIG+8+Sj5Fdg49r/ 0V7GjuuEywVPxpqzktEexI9i6rydGBkrM7ypbSjorIQa4+gmqbWwaQl7R3SoajfgMP43 s9Z7Al2T0psjzbB3fnE6FmgctvT9xDsTjEtWOLeBVgxn479rT3dCaRUUp1eX3m2NBGlp exFQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718479222; x=1719084022; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=KYeXW377gBe9+2cO4oghdHMMMAVt7c6MqaZiyFhEg6U=; b=Z13nh2FyyJvObH4uSx46LCMypHBLk13Lmizhy7HuIm36mZEnl/FfAHyPUHirQpemia CjoV2Feo2Mne8H8fmiMH+rTnjLzdm6uYY/DrIEzMLMQ8ey3modPuh44ANRvL8iDANz0t AAtPfsW/KbiqZx0CVbh0Fm4VMzo5Svc5s8y0SmTO49XBUU4KD3Gq7hmL8SS/xWRPldNH mdjOyLKulUkLEngxSBjQtzGok+27dKZ4t64JmtPGCuqzSZ7O3oIm2YS8r8DvSVJ6zMmY 9XnPb7iS+Nix+jl4ALV/1Jp+QDMDbYVLBaRbROfIw7TQyU2ErymPd8xIWcpy2gRVYdfG 0GOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718479222; x=1719084022; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:sender:from:to:cc:subject:date :message-id:reply-to; bh=KYeXW377gBe9+2cO4oghdHMMMAVt7c6MqaZiyFhEg6U=; b=PQcNxO878rZ/4mn/U55kjWL68tkDG0+pRHcXe3puq//cgbiZSwcZ0GhI3xeKcNGCX0 TEJnhUdMbpY7ddc8pw4K1Uhu3X5cZFkief3+4/A/7hf+9kAmJSb4Ryn3MJWO+fnwJBxD 1HITeeQlJ9SpXslKAclk+uiJt7lIdGZCwPeUjFtCOmp0J5l+c8i2Lxiyc1mc3J+6SgcE ro32rqaWjFRgO+159d1yXixgS6jV7FteERo2Y2E1ZaPYWI54Oweba1EdVDElErOiOVY2 kolWVcWjNNJVS3rhjk6NK1qNXvGoOAqxfCh5S5EoCu9K1lRgyghaerpOkRTnT6B/dVYc fqBQ== Sender: swupdate@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCWCas7dIOm521719QOEwOnSktdGPP+o0mMW71LZ/j0LZ9ghyr60gvjnUSdph2AGUYHx/yHFDCm888tmTG1lVIxQlCegJO8D/b/DEycF+A== X-Gm-Message-State: AOJu0Yyx9msRazbHxZH3Cl4ztNkymTDroxeUIP+UBXhIjdl4N97sT9cb qtr1pDovK93FNOaj2UYnAMV8AtUR0euaAZHF+bqVW11yEnuMbFD+ X-Google-Smtp-Source: AGHT+IG3ONZdNPTPtgNys2trKBNHLj86R2GKSCiWUTtO03WrdbiJ/XUPWFiYHC3aiDr6MtP6LGxBww== X-Received: by 2002:a05:600c:4f07:b0:421:7e19:5afa with SMTP id 5b1f17b1804b1-42304844b70mr62486175e9.30.1718479222019; Sat, 15 Jun 2024 12:20:22 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a05:600c:3b86:b0:421:7d7f:c621 with SMTP id 5b1f17b1804b1-422b8cabba4ls15595995e9.1.-pod-prod-05-eu; Sat, 15 Jun 2024 12:20:19 -0700 (PDT) X-Received: by 2002:a05:600c:a01:b0:422:50d7:100b with SMTP id 5b1f17b1804b1-42304820c95mr56501945e9.14.1718479219128; Sat, 15 Jun 2024 12:20:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1718479219; cv=none; d=google.com; s=arc-20160816; b=lwpPBISUrNFF8oSuEKHpPxGvHgvFO3ruf/+ZDNIbulmvt/4t8td4o8ja4tqlaw83b7 X4CZirz8Bs3C3kRVXuE8RyPwGEuCIZ+vj12YPVAqAOAp17ri/WiQkytjQOVUy3zxCFv7 //i4+cqVFW7Vl1Pcir6JgRJ2lrDflFPjKol6sjLmpygSWF+KXhEoPWluWnlcWV2WsGpA cZnRRMmCJ08PcAsOlXF/kmlMdmFWTsQTX4afESihp4Ta0FlBdPiQfaQ0r77RLLPhx3Ag o1f2n5HyxisH51/0REcrXMhbgdcRsU8Wj1Tjn+TBboOXjQ+/6pwyCfMgXKhci8WH2jKY ii1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=kCI+fyL64e7eZoDJwLBDGJN/CsLkEmd8y9siW0RWjBg=; fh=zydHuzCQWrku2OPQyZfraJZFcOpEXLQ/YBcu3QNiBd0=; b=wqrLkQnn5MHrjk7gsh/eHvnwlW02oZe2A22zgZuhRRpjxjITFp7U2redYiSIM/96tV jWZOoxu46TA6RAVn6Bu0dS+bO+ahsh+jlS4LX86xB1tyK+6ju+/xi6e0JkiMAHfweglQ 1Q1E7V8jqLLOPRHBebZwKqMrvDK7k38NrNZ1HMETMLonSbfuC7QtC0vDlbc+wX6+O7Qn i2H92j1t6md8jO0JbEjOE3IJ8rOLChGsG6lDtqE41BF2EfXizmu7nZmplQkVSm36gttZ JJcr/8QeRtkxJb+ZIwVeT3/NhR9P4EJNSqHvFMgY55BWmjew2Z1kszJ3I3iFVTX3mKI3 zzPw==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=LI7UcPb5; spf=pass (google.com: domain of m.glembo@gmail.com designates 2a00:1450:4864:20::22f as permitted sender) smtp.mailfrom=m.glembo@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com. [2a00:1450:4864:20::22f]) by gmr-mx.google.com with ESMTPS id 5b1f17b1804b1-422855708b8si572675e9.1.2024.06.15.12.20.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Jun 2024 12:20:19 -0700 (PDT) Received-SPF: pass (google.com: domain of m.glembo@gmail.com designates 2a00:1450:4864:20::22f as permitted sender) client-ip=2a00:1450:4864:20::22f; Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2eaae2a6dc1so58953181fa.0 for ; Sat, 15 Jun 2024 12:20:19 -0700 (PDT) X-Received: by 2002:a2e:a415:0:b0:2ec:1e6e:13f9 with SMTP id 38308e7fff4ca-2ec1e6e1442mr20275671fa.52.1718479217580; Sat, 15 Jun 2024 12:20:17 -0700 (PDT) Received: from PC-2635.irisgmbh.local ([2a02:8108:96c0:76fc::80bb]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6f56db61e0sm327283766b.49.2024.06.15.12.20.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Jun 2024 12:20:17 -0700 (PDT) From: Michael Glembotzki To: swupdate@googlegroups.com Cc: Michael Glembotzki Subject: [swupdate] [PATCH 06/21] mongoose: Remove double free calls Date: Sat, 15 Jun 2024 21:11:19 +0200 Message-ID: <20240615191941.40301-7-Michael.Glembotzki@iris-sensing.com> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240615191941.40301-1-Michael.Glembotzki@iris-sensing.com> References: <20240615191941.40301-1-Michael.Glembotzki@iris-sensing.com> MIME-Version: 1.0 X-Original-Sender: m.glembo@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=LI7UcPb5; spf=pass (google.com: domain of m.glembo@gmail.com designates 2a00:1450:4864:20::22f as permitted sender) smtp.mailfrom=m.glembo@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , mp_streami->part.name and mp_stream->part.filename are already freed in mg_http_free_proto_data_mp_stream(). Signed-off-by: Michael Glembotzki --- mongoose/mongoose_multipart.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/mongoose/mongoose_multipart.c b/mongoose/mongoose_multipart.c index fb62c1e4..3361169c 100644 --- a/mongoose/mongoose_multipart.c +++ b/mongoose/mongoose_multipart.c @@ -142,10 +142,6 @@ static void mg_http_multipart_finalize(struct mg_connection *c) { struct mg_http_multipart_stream *mp_stream = c->pfn_data; mg_http_multipart_call_handler(c, MG_EV_HTTP_PART_END, NULL, 0); - free((void *) mp_stream->part.filename.ptr); - mp_stream->part.filename.ptr = NULL; - free((void *) mp_stream->part.name.ptr); - mp_stream->part.name.ptr = NULL; mg_http_free_proto_data_mp_stream(mp_stream); mp_stream->state = MPS_FINISHED; free(mp_stream);