diff mbox series

[libubootenv,2/3] Remove warnings

Message ID 20240527101843.380555-2-stefano.babic@swupdate.org
State Accepted
Headers show
Series [libubootenv,1/3] Factorize function to set variables's flags | expand

Commit Message

Stefano Babic May 27, 2024, 10:18 a.m. UTC 
Signed-off-by: Stefano Babic <stefano.babic@swupdate.org>
---
 src/uboot_mtd.c | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

--
2.34.1
diff mbox series

Patch

diff --git a/src/uboot_mtd.c b/src/uboot_mtd.c
index e5a9ce1..3d8c553 100644
--- a/src/uboot_mtd.c
+++ b/src/uboot_mtd.c
@@ -218,8 +218,9 @@  out:

 int libubootenv_ubi_update_name(struct uboot_flash_env *dev)
 {
+	const size_t VOLNAME_MAX_LENGTH = DEVNAME_MAX_LENGTH - 20;
 	char device[DEVNAME_MAX_LENGTH];
-	char volume[DEVNAME_MAX_LENGTH];
+	char volume[VOLNAME_MAX_LENGTH];
 	int dev_id, vol_id, fd, ret = -EBADF;
 	struct stat st;
 	char *sep;
@@ -232,7 +233,7 @@  int libubootenv_ubi_update_name(struct uboot_flash_env *dev)
 			memset(device, 0, DEVNAME_MAX_LENGTH);
 			memcpy(device, dev->devname, sep - dev->devname);

-			memset(volume, 0, DEVNAME_MAX_LENGTH);
+			memset(volume, 0, VOLNAME_MAX_LENGTH);
 			sscanf(sep + 1, "%s", &volume[0]);

 			ret = ubi_get_dev_id_from_mtd(device);
@@ -263,9 +264,9 @@  int libubootenv_ubi_update_name(struct uboot_flash_env *dev)
 					}
 				}

-				sprintf(dev->devname, DEVICE_UBI_NAME"%d:%s", req.ubi_num, volume);
+				snprintf(dev->devname, sizeof(dev->devname) - 1, DEVICE_UBI_NAME"%d:%s", req.ubi_num, volume);
 			} else {
-				sprintf(dev->devname, DEVICE_UBI_NAME"%d:%s", ret, volume);
+				snprintf(dev->devname, sizeof(dev->devname) - 1, DEVICE_UBI_NAME"%d:%s", ret, volume);
 			}
 		} else {
 			return -EBADF;
@@ -273,6 +274,7 @@  int libubootenv_ubi_update_name(struct uboot_flash_env *dev)
 	}

 	sep = strchr(dev->devname, DEVNAME_SEPARATOR);
+	ret = 0;
 	if (sep)
 	{
 		memset(device, 0, DEVNAME_MAX_LENGTH);
@@ -289,10 +291,10 @@  int libubootenv_ubi_update_name(struct uboot_flash_env *dev)
 		if (vol_id < 0)
 			goto out;

-		sprintf(dev->devname, "%s_%d", device, vol_id);
+		if (snprintf(dev->devname, sizeof(dev->devname) - 1, "%s_%d", device, vol_id) < 0)
+			ret = -EBADF;
 	}

-	ret = 0;

 out:
 	return ret;