Message ID | 20240425165648.2804129-1-stefano.babic@swupdate.org |
---|---|
State | Accepted |
Headers | show
Return-Path: <swupdate+bncBD2ZDGN6SEKRBVMWVKYQMGQEIKNSZ7A@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20230601 header.b=qzDDEYNO; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::33a; helo=mail-wm1-x33a.google.com; envelope-from=swupdate+bncbd2zdgn6sekrbvmwvkyqmgqeiknsz7a@googlegroups.com; receiver=patchwork.ozlabs.org) Received: from mail-wm1-x33a.google.com (mail-wm1-x33a.google.com [IPv6:2a00:1450:4864:20::33a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VQMTQ6Jjkz1yZr for <incoming@patchwork.ozlabs.org>; Fri, 26 Apr 2024 02:56:57 +1000 (AEST) Received: by mail-wm1-x33a.google.com with SMTP id 5b1f17b1804b1-416640b7139sf1624775e9.1 for <incoming@patchwork.ozlabs.org>; Thu, 25 Apr 2024 09:56:57 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1714064214; cv=pass; d=google.com; s=arc-20160816; b=K8Zs9LgQC5/RWv83lW9YS8bKPUK6BKeOWjx3TPzlHJhnazm3dxmMvAtPFCNFvPRFCe Uv9wxxXyqA5wID4NBcqvR0gKxj368w/mGlpxcSAucm2JifDAR1wvI2wFLnsKpVLHhXwT 0vT//YbxB6ipOjMdN1X3EknPrzLX0iMVi+tT+PjBZ6jglurOA704t0kSZ50fHs3MHP8V iWvF5rmlCoZ8f4rZ29WI0ssHZU1WRU/nssa9JQ90yPS6dUblhFTkhJ/EiW9sEcI0qYdC RBHoTppwSsJqq//z/QJvoAh3JX01SzJDDpFQx9uOLSnseWpXJYr7Xzxr3OVbLqUjaq8j lt5A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:ui-outboundreport:mime-version :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=BYO+Cr9n6TPaS73hOIuvmQanmnbL/oFIJ/5sBRF0Ytk=; fh=P1G1AihqtpM5Xdh7AOGG8dQ/hEbFxrD0EXBQXlEgYP8=; b=aKldaRDMLt8flMHlhLiTLzv8w98Hs2X3HaM09LaqDF4zYiMtzILWWItO4n33dd01Mi fdmr5jG56aBD19JICHclU8Xsge5fwPcoTor/m/ROqSXOJs773fBwSzfGTc0Ihs2reytO RVLf3qV1rGtSh4+nOgiaZRkaiiAzfhF1ZHB6LFRfFfHUJJLyN+SLb6THx2I+tzyEqrc8 Ma74N1usC2FOVEOmqR/hJwY0OZxWF1z/8w/YYVEWHQ013axv8cFP3QHwcMuDHq+CnpO9 To9gZQXD3B9mdlc/4CMCorO9TuqKYLz47a6HARNDsezbODkRo6UX3D5oNowmFM9gdvQ+ BAPg==; darn=patchwork.ozlabs.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=x41nAesF; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.133 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1714064214; x=1714669014; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:ui-outboundreport:mime-version:message-id:date :subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=BYO+Cr9n6TPaS73hOIuvmQanmnbL/oFIJ/5sBRF0Ytk=; b=qzDDEYNOS0QIBWWsOY/48SG1iCpfQ0OD+J+ZsE8+ZL6zOOxNQIXSq8WPe6dZns7YTO 8jf/dmARGn2P2okBKo6RTLLixV19pEsUe4WBXh9btf+H9GZUU+iHr93X677wW049Kvtn J97RcNi8pBXFDYPIWZwlV7ELkGs65yDU/mVmygsDzfowARRpniUKcf2/c8a5mS6qrkCN FOJx0AQfqWGDnX2H2+fYDMAdRTY4pMTPlKoaeBNIanelTXRl/wOp+hLEiF1U1k7CtM2S XXtNeme322RjdSez8XJK9u4kKyo5Buihy02aZ2Z7YTMS/rzt5HeqSTrtHPDGJc8Wojd/ xm0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714064214; x=1714669014; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender :ui-outboundreport:mime-version:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:sender:from:to:cc:subject:date :message-id:reply-to; bh=BYO+Cr9n6TPaS73hOIuvmQanmnbL/oFIJ/5sBRF0Ytk=; b=d+b4D4evxQMJFnqSPAkvsGxJSm5hA46OBBE5jeV+mI6fG1FXts6mWgP5qlwRcJgMkd 5HVJWdKYUmPQcoTS8+uoNeko5pdZr3GUDTXb7f2l9+O7UplzpFqoPGMVCblej2BvGzGt Kyo7NGK8ZEjIHLj6er9HV3pwejxJaKfprbuzcPCCoHWExFw+qIgwvtvxqZOCmpwlWnYJ hhJcsxAK+YHd1WSJ0tlaTsayrjBZ3m86HuH6fA5nLVYnbO9V/xf2BcRxwQ/Bg8mVFPsh 3vJgNpdP/DoWzxAYNiF98TJdGZDbgh+HKPDpJV06MgVXLpmlZbj2NO8O4xMrV0KInV4i ymHw== Sender: swupdate@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCUtNZOjENt+7HXHziKesgPeS/mLoONAHXBq/I4eE3sH9UhUd2SI6JY+W934MpFJzbSFSuBjL7Zcms5a1uLfgz2SJcaoOUFQQTKnUAxMFg== X-Gm-Message-State: AOJu0Ywk9n23MJqv64Ji5flJM1QXYA4VXpyhW8r5La3QJ3nq275UQeQk rmdTVq/W3jz0cq9YjLIAXumoVtST2yCf17rxFPfsMWVT+hsn/ZMi X-Google-Smtp-Source: AGHT+IHWTZMCRLgcd3T62A2Mxlu/a969LWEjfpo5riatwmZeILoNrykfDxNTDfJ+nvB+kvtCvhW94w== X-Received: by 2002:adf:9b8f:0:b0:346:65dd:55e6 with SMTP id d15-20020adf9b8f000000b0034665dd55e6mr67454wrc.1.1714064214027; Thu, 25 Apr 2024 09:56:54 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:adf:fa05:0:b0:34a:9ada:7682 with SMTP id ffacd0b85a97d-34bf44d26a4ls376879f8f.0.-pod-prod-00-eu; Thu, 25 Apr 2024 09:56:51 -0700 (PDT) X-Received: by 2002:a5d:52c8:0:b0:346:a39f:6b69 with SMTP id r8-20020a5d52c8000000b00346a39f6b69mr2598477wrv.24.1714064211054; Thu, 25 Apr 2024 09:56:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1714064211; cv=none; d=google.com; s=arc-20160816; b=FI8rE9UPAXH3l/m16xl+AGZBJDkKdYUk7fdyac10L9DX7o5TMuG15lA0fBH4KGnHYx tQAeQOjM700XU2ygQp8lZ7/i7IAMeOPDgDf+rSUWatiGo+SQa1WZAcVd4dnhVal8mZw7 BmRHOl7Z1yZl+5T7RuocVoaVfBrqS2/c3Gpa6KvYvA/TwaZJ0Qr0ONqBBgJrogZYGmKQ DqSQtkeA8qRcaiOWfeL/iHJds8AmIuZ2wIJh5jTw4f5UU7eLqsPKYY2kA8kRjUJaEJY0 +LpGh7fnxZOx384BB89PF4aQneX2yEsqnyJY6kcLmvxpfl9c5yO3mANLPPePMGOG4KBf x+SA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=ui-outboundreport:content-transfer-encoding:mime-version:message-id :date:subject:cc:to:from:dkim-signature; bh=1e1gs5XjtHQFp3cnIZeVAly+v/myqg4/LAgg567SyPA=; fh=TiEWcqMcKpHk5s7uErzpntoONrNfOXwKpI5P8bIlggk=; b=BKB3VF6mCM5amGaVCrP7HH7Iy6pvkUqgCf9d97P7enistw1jldqO2tbmnEvqusgeBn qPCTX1BAm+m7GOMGJw8JoGyBRp6bgRbPpZmNgOxDjwNYzwAegNMcmx6z23lCJtwgmmN0 9yIpgFtCZ2XdU9exh0SM1gxa5Ejbs7i007vVZF0Zs/G7f4b1dcKxm37eAdlxpRMDOIxH OSU4c6Pjir3UA+0bNKH52kTzKBvHJmkaEzlDs/V2XPAAxlCs0Y+yNugzPCr/Vu1c+Mf6 618fZKfWKC8bXw+UespnseGbNr+K+J/0GEAY673lZwa2OkSSyi5jkEQAE1JQvcRYX47P nt3A==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=x41nAesF; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.133 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org Received: from mout.kundenserver.de (mout.kundenserver.de. [212.227.126.133]) by gmr-mx.google.com with ESMTPS id cw18-20020a056000091200b00347a3498f11si561296wrb.5.2024.04.25.09.56.50 for <swupdate@googlegroups.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 09:56:50 -0700 (PDT) Received-SPF: pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.133 as permitted sender) client-ip=212.227.126.133; X-UI-Sender-Class: 55c96926-9e95-11ee-ae09-1f7a4046a0f6 Received: from paperino.fritz.box ([88.217.136.221]) by mrelayeu.kundenserver.de (mreue009 [213.165.67.97]) with ESMTPSA (Nemesis) id 1N6srH-1sl2Fx2C3b-011zIZ; Thu, 25 Apr 2024 18:56:50 +0200 From: Stefano Babic <stefano.babic@swupdate.org> To: swupdate@googlegroups.com Cc: Stefano Babic <stefano.babic@swupdate.org> Subject: [swupdate] [PATCH] bootloader: cboot: fix close call in error branch Date: Thu, 25 Apr 2024 18:56:48 +0200 Message-Id: <20240425165648.2804129-1-stefano.babic@swupdate.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:ieLDp1EQgpSFbaR0Jrdxqt9HsTaJWTKkYBqb5picnCD8Z7N5jsI tnMNU+bOWZlUeqKNng0h5XMACPi/GymMTTySNF+KY56YtwxTyrYc6iPOWZl0nYNepr1Zck6 SpRC8JCnnaumvfijwT631XvjoM0TKj2NjQ8uS4fMq7pFIT20JkJk1R2YpTOM8dl+DVrK7zt bxEdeJ7NjOp6yRWwz8ttg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:GYWvMegYjzA=;vyhU8BPJzS5oj4rMNHE6e3xcE6x Iu9I4i2SgtgSwOWDnTdPSs2MSekbZhsUczYAjl8sbAq7zWkK7Nts0XnySd6plvmlvKOYDC1/A eTP+oAs4XcDjlg/vYBIsMpIAiQgvCY1ttXhdfC/9LhNsKjwikyO0JwfM5UxIFvlrdvVLH32Lh tLWVyYPikS7xnqRKcAx/O0T37ArJeiSvDhByIO4cwFC6wtPqg5mO+vJAch23wm5/gq1OKtjXj ulkhzsRUYOHEIcc1ekSCH4H8KWNNOgQ4NkHLcEKlrcFjz6szotQ7ffU0yF3oQpzI9gF1qKlnx ijwuKzLo6IJYNND8W3WaF4rJeiW35gRdTIzToIMw7iFoT9nG+J2HImh+dkSyQtI5E2ohucQiX ic6lzxc/kTeF8cSCX3ogKhyVrmNE4MH77ttAVO6rxsskzzlCOJlvfNbyqwud6aB7yYS9YYQSf pz4L0Sio4BdbEmBK7wjCL+GFHou5zcL6Les8QDq350CSJSIz2fK/y/kWBbZ9ew25fmeHuOFe7 3eFxmJhdzDoVbi1qrjyMKwkaTjYCLeoPoJdM38vM0/JHEmkWXBmmRvWO1lkr0e9NvxbxDLmYq kHNPD1/7M6vkyNKu+r0V9GOwPf12hHJwN2FhUwgW6RY/Qoog0OYXnty2gbQ1nEN+gpI8Xe7Wx 32paGcwQCpVBxZW++c7fiidBSVMcOwLUzX8VcTj/sNXsbNScCSMTbSiWz9H7PZReAReAzBYpP otxIifZikOtwVYygCUWvznG2tP3Wibk8TJPKiiKjRqi6x4eG7P8D/k= X-Original-Sender: stefano.babic@swupdate.org X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@swupdate.org header.s=s1-ionos header.b=x41nAesF; spf=pass (google.com: domain of stefano.babic@swupdate.org designates 212.227.126.133 as permitted sender) smtp.mailfrom=stefano.babic@swupdate.org Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: <swupdate.googlegroups.com> X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: <https://groups.google.com/group/swupdate/post>, <mailto:swupdate@googlegroups.com> List-Help: <https://groups.google.com/support/>, <mailto:swupdate+help@googlegroups.com> List-Archive: <https://groups.google.com/group/swupdate List-Subscribe: <https://groups.google.com/group/swupdate/subscribe>, <mailto:swupdate+subscribe@googlegroups.com> List-Unsubscribe: <mailto:googlegroups-manage+605343134186+unsubscribe@googlegroups.com>, <https://groups.google.com/group/swupdate/subscribe> |
Series |
bootloader: cboot: fix close call in error branch
|
expand
|
diff --git a/bootloader/cboot.c b/bootloader/cboot.c index db076395..bd4d9c08 100644 --- a/bootloader/cboot.c +++ b/bootloader/cboot.c @@ -138,7 +138,7 @@ static int do_apply_list(const char *filename) int result = 0; if (libcboot.open(BOOTINFO_O_RDWR, &ctx) < 0) { ERROR("libcboot.open returns with error"); - close(file); + fclose(file); return -ENOENT; } while ((getline(&line, &length, file)) != -1) {
This module uses fopen(), and fclose() must be used to close the FILE. Signed-off-by: Stefano Babic <stefano.babic@swupdate.org> --- bootloader/cboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.34.1