diff mbox series

[1/4] Parser: statify get_value_*

Message ID 20240425124620.51594-1-stefano.babic@swupdate.org
State Accepted
Headers show
Series [1/4] Parser: statify get_value_* | expand

Commit Message

Stefano Babic April 25, 2024, 12:46 p.m. UTC 
These functions shouldn't called outside the specific parser
implementation.

Signed-off-by: Stefano Babic <stefano.babic@swupdate.org>
---
 corelib/parsing_library_libconfig.c | 2 +-
 corelib/parsing_library_libjson.c   | 2 +-
 include/parselib.h                  | 2 --
 3 files changed, 2 insertions(+), 4 deletions(-)

--
2.34.1
diff mbox series

Patch

diff --git a/corelib/parsing_library_libconfig.c b/corelib/parsing_library_libconfig.c
index 814bfa6f..ec1dbc3b 100644
--- a/corelib/parsing_library_libconfig.c
+++ b/corelib/parsing_library_libconfig.c
@@ -19,7 +19,7 @@ 
 #include "util.h"
 #include "parselib.h"

-void get_value_libconfig(const config_setting_t *e, void *dest)
+static void get_value_libconfig(const config_setting_t *e, void *dest)
 {
 	int type = config_setting_type(e);
 	switch (type) {
diff --git a/corelib/parsing_library_libjson.c b/corelib/parsing_library_libjson.c
index bb163af5..43b73805 100644
--- a/corelib/parsing_library_libjson.c
+++ b/corelib/parsing_library_libjson.c
@@ -102,7 +102,7 @@  const char *get_field_string_json(json_object *e, const char *path)
 	return NULL;
 }

-void get_value_json(json_object *e, void *dest)
+static void get_value_json(json_object *e, void *dest)
 {
 	enum json_type type;
 	type = json_object_get_type(e);
diff --git a/include/parselib.h b/include/parselib.h
index b1674709..d8c17bde 100644
--- a/include/parselib.h
+++ b/include/parselib.h
@@ -33,7 +33,6 @@  typedef void (*iterate_callback)(const char *name, const char *value,
 #endif

 bool is_field_numeric_cfg(config_setting_t *e, const char *path);
-void get_value_libconfig(const config_setting_t *e, void *dest);
 void get_field_cfg(config_setting_t *e, const char *path, void *dest);
 void *get_child_libconfig(void *e, const char *name);
 void iterate_field_libconfig(config_setting_t *e, iterate_callback cb,
@@ -60,7 +59,6 @@  void *get_node_libconfig(config_t *cfg, const char **nodes);

 bool is_field_numeric_json(json_object *e, const char *path);
 const char *get_field_string_json(json_object *e, const char *path);
-void get_value_json(json_object *e, void *dest);
 void get_field_json(json_object *e, const char *path, void *dest);
 void *get_child_json(json_object *e, const char *name);
 void iterate_field_json(json_object *e, iterate_callback cb, void *data);