Message ID | 20240315161108.218579-2-mege.mathieu@gmail.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <swupdate+bncBDMLF7XF6MJBBP7G2GXQMGQE3JVY36I@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20230601 header.b=S0CAfWX4; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=K0rf6aWR; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::239; helo=mail-lj1-x239.google.com; envelope-from=swupdate+bncbdmlf7xf6mjbbp7g2gxqmgqe3jvy36i@googlegroups.com; receiver=patchwork.ozlabs.org) Received: from mail-lj1-x239.google.com (mail-lj1-x239.google.com [IPv6:2a00:1450:4864:20::239]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Tx8QD2lsKz1yX0 for <incoming@patchwork.ozlabs.org>; Sat, 16 Mar 2024 03:11:48 +1100 (AEDT) Received: by mail-lj1-x239.google.com with SMTP id 38308e7fff4ca-2d45f5bd000sf20348761fa.1 for <incoming@patchwork.ozlabs.org>; Fri, 15 Mar 2024 09:11:48 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1710519105; cv=pass; d=google.com; s=arc-20160816; b=Y5QdwoCMFgHu33UF4aJseNq/DU8s2yJxDxHhiqNEjyr9TqVO3lwjVYC2XccGctRRyv beMhavGbA835973240/o4VHGd2T0z5aqQCyiQf3kxZnpq2gzdJ0KCAz1id7yMhnddhgK FJFseuDfk6NbNVAo5KQ8r7+mKl0CJMMwlp040uhLPZ6kLAZrNPCW4CZg52+ALhGtZ56d VLzxjosiJWGHZfNUO+QGQztcqcHlKJvGBXvSvmryzoZsafXwG55p7fDIZOcyq5sFMV4Y 60HXM74GU6PKBsIw/YnyLPA7kpnXzfB28M30a3tnRTVD4EJ3cTX6p27JE/xKJ4sBIasn rBtw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature :dkim-signature; bh=3/pOLdFOucRlZI+DjfOySFWn7eNXrARbuQzXINRC7ms=; fh=gA9dWInojFn8BZqf/nduoKcUOuBM6n8HbarR45z2PP8=; b=Ff3DzA+5M6ztCJbHpUQCKKYwMSzZbeMMxJk3ZdyO6kWULsT1uMbn3FogDRXuOwpNCg 31854ghROe96oID5WMoZcStszq8GOxgEttLK9JQgPloCfs20dR0uk+VJooxs/nGbq3PW IP97eF4wF7skD0hhYJMD9068lFn7nTcZd14uYqdgSmq3f54L9eZzjo+Qrqny0hhBMsIZ qMER1BShV1kPiJrnWnBdIyW9163I+QlEOdTsG6KWvhlXSD1PC78sciT90/PgBqk9m6eB gvEsMRssAl52TdJrDZUQJXGGxcoZ8bD2DwtgHNM027OWNMOPra2hRWYpakptJDA9J7nh vUvw==; darn=patchwork.ozlabs.org ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=as1ZDIiX; spf=pass (google.com: domain of mege.mathieu@gmail.com designates 2a00:1450:4864:20::136 as permitted sender) smtp.mailfrom=mege.mathieu@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20230601; t=1710519105; x=1711123905; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:sender:from:to:cc:subject:date:message-id :reply-to; bh=3/pOLdFOucRlZI+DjfOySFWn7eNXrARbuQzXINRC7ms=; b=S0CAfWX4gO8zEsewT9hMPXUTqjbb7S/TdG4ZX7T+sJyP2K+vMJ7wj87XJYOy5i9MJu g0TeVaZ6FT3QGgh8TtY5XYZmxvXFlMo+32r6tUAvyFwFfnC5LbV53zbVjLB/EMi2BXWb GF6eVUsUFcDD7YjLrKKbYPQwmjPXck3GhdGobE2kt34rk0D3OnzWwURSLMpB3Np8p3BY mLeLt9LiJkgkwrzs2AwbBloMIAbTa3Eh4UHKKFIsB3DKkYtpqajEYwl5fqzAfAGDO1Z5 Cw6aQN/D4BRAQhhrqhdUHbsgBIrxPF1/RpCMdFgJOCxod74Jvv8nD2Aa1O4nhaid6rSh WRrw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710519105; x=1711123905; darn=patchwork.ozlabs.org; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:x-original-authentication-results :x-original-sender:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=3/pOLdFOucRlZI+DjfOySFWn7eNXrARbuQzXINRC7ms=; b=K0rf6aWR+riChhukIDwPz+705s0eGckVbWZyCFCOEl5LHWC1KD/SDVOFFHTjp5rchK KQEsReR5zxslCbGBfO/sJPZ3bhy3gcMGY2f8HtRS35JbS+8CfBlw9mH7tFj/6U1H3rZK xsNKQiCA8I7pWRpA9UVNbJKUYkw0M0jmjkHb6oC7CO7RasTgA6QaZy/xFEcqgqhhTbPg LATUuG0JEKYKS9YGhYNcCKerPhmJbQcuyMfRbMgJSRXH25N9N7Plkb3TeHbpqY6WjAlA p6/6POYAX4lYAhfHZ4ov5fbIlwmrRBFxqi7EIYhDtoeLLJcVRJjM8mtahbhzqn9XtDuu lvjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710519105; x=1711123905; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :x-spam-checked-in-group:list-id:mailing-list:precedence :x-original-authentication-results:x-original-sender:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :x-beenthere:x-gm-message-state:sender:from:to:cc:subject:date :message-id:reply-to; bh=3/pOLdFOucRlZI+DjfOySFWn7eNXrARbuQzXINRC7ms=; b=vzNQ9Uz5IR6mUa+Zihpsk/DsdO6aQO7p7+MbX+0x2TXRKDq8yJpkCXWk6A30nxmySQ ytfUBGGDnbWefqw+XsN0sKj8iAy9mbPc3NAH0Jp/KnMSimbFXjunWPLMn6vgJ97EHQ/e ZURACMW75+Z1mo9NvUxXHcBzIXn2lNqCjFf3VJ+foUPdb7+uopPaP15ppWUSZ86u6doY 8xzwmpa0hbvXFtEcaiSkYZ73SbeMmMQqa5DOIr6Cj0FFm1zXTl3oAxMzv3jpRwyvhJMY ag7HOsuSriwR2mSELsbwu733NGpEfneQaKe5nYsTQBVUk2CyWXhaiiIasgD+yIa0GRyo sF2Q== Sender: swupdate@googlegroups.com X-Forwarded-Encrypted: i=2; AJvYcCVv42IjdsdH9qM6nVXVLP1V1j+v2LZohelHNB/tW6oyKVTgT7v4YuhiD2bjHQAz+Ij83crBXbOuINgMxJy6IT88fgcMTxnDNRUo3fmJLQ== X-Gm-Message-State: AOJu0YzpNv7N1fNBHHbUHoWQCMEh3MP1pQb99Opz8NYnDUSM73RGa8TG Eqolapb1XaBTAjzcOQr3OcI4lu/hPvRYfGh5RD46/p4/QT9f6png X-Google-Smtp-Source: AGHT+IFjiu/GIny5vLm81xKpXgD3Zm8rk2SgqWNhAY98vcUf8YSZizRIZnw427BXlGedneqqVr7f9A== X-Received: by 2002:a2e:9653:0:b0:2d3:1bd0:6bcf with SMTP id z19-20020a2e9653000000b002d31bd06bcfmr2156627ljh.8.1710519104537; Fri, 15 Mar 2024 09:11:44 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a05:651c:229:b0:2d4:912f:2e2e with SMTP id z9-20020a05651c022900b002d4912f2e2els118996ljn.2.-pod-prod-06-eu; Fri, 15 Mar 2024 09:11:41 -0700 (PDT) X-Received: by 2002:a2e:9cd9:0:b0:2d4:92ea:21de with SMTP id g25-20020a2e9cd9000000b002d492ea21demr84671ljj.0.1710519101489; Fri, 15 Mar 2024 09:11:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1710519101; cv=none; d=google.com; s=arc-20160816; b=agyRBc5da26Ab+LQBldxDpmC58+LQX33ZKig5LmY+9W28SiKXqbtDkFTBe44Dmtrrc bYGiTMVpjv77o1QkZIBBTgmY64lFXNKmjxRu6s6WbY3+Wd6GV5zQGh/tBcJt3VAbxerO 3MJgIBzYkBAUj/RDp5Gvy1tkUznQOg/N86VW7KTR04Kzkr7NV/Gtk8OjLEw9950dcxno LskFNrGVnITOUwwAqERwaXVZaDfdm3ldrBmmMLb2p252suKvqrHWxiaHufJhnGAGtcXD Wv/ElUZSFYArrz/EYbk2nVBxX+a27R5uisa6nXhwbnItAD5hghwpryHNrL1h8ldIJ8Uh gtGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:dkim-signature; bh=SXdTm3lZ5m5GXj23I5Wt/J8P1HrNVYi9MpcyTdYcgjg=; fh=CUI1j9PdY7oRLX/gDEOzWjbkGCTMuSAa+g2jIhX+VOY=; b=Ih6U1P89rzr0jLyhrXlmhf2P5vIk2crp0a4eqRs5cTb7bGyAJdB9i5k7jId5fH+zcl 7jAcO4sVfAFoiiiQ1jnPYy7mLwK3dEmu4PIh6eZwrg1VmEYVLL5PToT/X+ea5hG76MtZ cr8fm5+fm87xj5KJSoycvUlobF8JIN+058GhdA9+ey1olhFvjTYtmeVuxx6DF/RF6SS/ 6k4+rBT9GEdpARy3D2L29tEYNscqC7Cl9TTV5cSsST2kyySNPm+qwkEno9tdR6pKAimE Hxdl1bNHBAd0ttZxPz63JLYc0nAvjQ1fPqqAraZ1VIpsWC5v4QR5gR0olrd96vLYqEy9 8P+w==; dara=google.com ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=as1ZDIiX; spf=pass (google.com: domain of mege.mathieu@gmail.com designates 2a00:1450:4864:20::136 as permitted sender) smtp.mailfrom=mege.mathieu@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com. [2a00:1450:4864:20::136]) by gmr-mx.google.com with ESMTPS id t10-20020a05651c204a00b002d471e919d7si232532ljo.7.2024.03.15.09.11.41 for <swupdate@googlegroups.com> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 Mar 2024 09:11:41 -0700 (PDT) Received-SPF: pass (google.com: domain of mege.mathieu@gmail.com designates 2a00:1450:4864:20::136 as permitted sender) client-ip=2a00:1450:4864:20::136; Received: by mail-lf1-x136.google.com with SMTP id 2adb3069b0e04-513d3746950so2390161e87.1 for <swupdate@googlegroups.com>; Fri, 15 Mar 2024 09:11:41 -0700 (PDT) X-Received: by 2002:ac2:5229:0:b0:513:ad46:dc7d with SMTP id i9-20020ac25229000000b00513ad46dc7dmr2359994lfl.61.1710519100201; Fri, 15 Mar 2024 09:11:40 -0700 (PDT) Received: from LSTA-2404.. (2a01cb09d053699aec27e8f028a71eaf.ipv6.abo.wanadoo.fr. [2a01:cb09:d053:699a:ec27:e8f0:28a7:1eaf]) by smtp.googlemail.com with ESMTPSA id t20-20020a05600c199400b004132ae838absm6296401wmq.43.2024.03.15.09.11.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 09:11:39 -0700 (PDT) From: Mathieu Mege <mege.mathieu@gmail.com> To: swupdate@googlegroups.com Cc: Mathieu Mege <mege.mathieu@gmail.com> Subject: [swupdate] [PATCH v3 2/2] [delta_handler]BUG: Fix missing last chunk in create_zckindex Date: Fri, 15 Mar 2024 17:11:08 +0100 Message-Id: <20240315161108.218579-2-mege.mathieu@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240315161108.218579-1-mege.mathieu@gmail.com> References: <20240313173120.193463-1-mege.mathieu@gmail.com> <20240315161108.218579-1-mege.mathieu@gmail.com> MIME-Version: 1.0 X-Original-Sender: mege.mathieu@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=as1ZDIiX; spf=pass (google.com: domain of mege.mathieu@gmail.com designates 2a00:1450:4864:20::136 as permitted sender) smtp.mailfrom=mege.mathieu@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: <swupdate.googlegroups.com> X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: <https://groups.google.com/group/swupdate/post>, <mailto:swupdate@googlegroups.com> List-Help: <https://groups.google.com/support/>, <mailto:swupdate+help@googlegroups.com> List-Archive: <https://groups.google.com/group/swupdate List-Subscribe: <https://groups.google.com/group/swupdate/subscribe>, <mailto:swupdate+subscribe@googlegroups.com> List-Unsubscribe: <mailto:googlegroups-manage+605343134186+unsubscribe@googlegroups.com>, <https://groups.google.com/group/swupdate/subscribe> |
Series |
[v3,1/2,delta_handler] BUG: Fix read source loop in create_zckindex
|
expand
|
Hi Mathieu, Le 15/03/2024 à 17:11, Mathieu Mege a écrit : > Signed-off-by: Mathieu Mege <mege.mathieu@gmail.com> Acked-by: Pierre-Jean Texier <texier.pj2@gmail.com> Thanks !
On 15.03.24 17:11, Mathieu Mege wrote: > Signed-off-by: Mathieu Mege <mege.mathieu@gmail.com> > --- > handlers/delta_handler.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/handlers/delta_handler.c b/handlers/delta_handler.c > index 8f0c97e..5b45003 100644 > --- a/handlers/delta_handler.c > +++ b/handlers/delta_handler.c > @@ -509,6 +509,7 @@ static bool create_zckindex(zckCtx *zck, int fd, size_t maxbytes) > } > > free(buf); > + zck_end_chunk(zck); > > if(n < 0) { > ERROR("Error occurred while reading data : %s", strerror(n)); Acked-by: Stefano Babic <stefano.babic@swupdate.org> Best regards, Stefano Babic
diff --git a/handlers/delta_handler.c b/handlers/delta_handler.c index 8f0c97e..5b45003 100644 --- a/handlers/delta_handler.c +++ b/handlers/delta_handler.c @@ -509,6 +509,7 @@ static bool create_zckindex(zckCtx *zck, int fd, size_t maxbytes) } free(buf); + zck_end_chunk(zck); if(n < 0) { ERROR("Error occurred while reading data : %s", strerror(n));
Signed-off-by: Mathieu Mege <mege.mathieu@gmail.com> --- handlers/delta_handler.c | 1 + 1 file changed, 1 insertion(+)