diff mbox series

[3/3] suricatta/lua: Adapt General HTTP Server to updated specification

Message ID 20240221180540.37058-3-michael.adler@siemens.com
State Accepted
Delegated to: Stefano Babic
Headers show
Series [1/3] suricatta/lua: Update specification | expand

Commit Message

Michael Adler Feb. 21, 2024, 6:05 p.m. UTC
From: Christian Storm <christian.storm@siemens.com>

Adapt to Suricatta Lua Module Interface Specification
updates due to LuaLS's recently implemented stricter
inference checks.

Signed-off-by: Christian Storm <christian.storm@siemens.com>
Signed-off-by: Michael Adler <michael.adler@siemens.com>
---
 examples/suricatta/swupdate_suricatta.lua | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Stefano Babic Feb. 29, 2024, 8:46 a.m. UTC | #1
On 21.02.24 19:05, 'Michael Adler' via swupdate wrote:
> From: Christian Storm <christian.storm@siemens.com>
>
> Adapt to Suricatta Lua Module Interface Specification
> updates due to LuaLS's recently implemented stricter
> inference checks.
>
> Signed-off-by: Christian Storm <christian.storm@siemens.com>
> Signed-off-by: Michael Adler <michael.adler@siemens.com>
> ---
>   examples/suricatta/swupdate_suricatta.lua | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/examples/suricatta/swupdate_suricatta.lua b/examples/suricatta/swupdate_suricatta.lua
> index a74905c9..434663fc 100644
> --- a/examples/suricatta/swupdate_suricatta.lua
> +++ b/examples/suricatta/swupdate_suricatta.lua
> @@ -137,9 +137,9 @@ jobtype = {
>   --- A Job.
>   --
>   --- @class job
> ---- @field md5  string    MD5 sum of the artifact
> ---- @field url  string    URL of the artifact
> ---- @field typ  job.type  Type of job
> +--- @field md5  string | nil    MD5 sum of the artifact
> +--- @field url  string | nil    URL of the artifact
> +--- @field typ  job.type | nil  Type of job
>
>
>   --- Configuration for the General Purpose HTTP Server.
> @@ -476,7 +476,7 @@ function server_stop()
>       gs.channel_config = {}
>       for channel, _ in pairs(gs.channel) do
>           gs.channel[channel].close()
> -        gs.channel[channel] = {}
> +        gs.channel[channel] = nil
>       end
>       return suricatta.status.OK
>   end


Applied to -master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/examples/suricatta/swupdate_suricatta.lua b/examples/suricatta/swupdate_suricatta.lua
index a74905c9..434663fc 100644
--- a/examples/suricatta/swupdate_suricatta.lua
+++ b/examples/suricatta/swupdate_suricatta.lua
@@ -137,9 +137,9 @@  jobtype = {
 --- A Job.
 --
 --- @class job
---- @field md5  string    MD5 sum of the artifact
---- @field url  string    URL of the artifact
---- @field typ  job.type  Type of job
+--- @field md5  string | nil    MD5 sum of the artifact
+--- @field url  string | nil    URL of the artifact
+--- @field typ  job.type | nil  Type of job
 
 
 --- Configuration for the General Purpose HTTP Server.
@@ -476,7 +476,7 @@  function server_stop()
     gs.channel_config = {}
     for channel, _ in pairs(gs.channel) do
         gs.channel[channel].close()
-        gs.channel[channel] = {}
+        gs.channel[channel] = nil
     end
     return suricatta.status.OK
 end