diff mbox series

bootloader: EBG: Short-circuit bootloader_env_set()

Message ID 20220829173054.83323-1-christian.storm@siemens.com
State Accepted
Headers show
Series bootloader: EBG: Short-circuit bootloader_env_set() | expand

Commit Message

Storm, Christian Aug. 29, 2022, 5:30 p.m. UTC 
EBG's do_env_set() gets wired to bootloader_env_set(),
hence spare this indirection.

Signed-off-by: Christian Storm <christian.storm@siemens.com>
---
 bootloader/ebg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefano Babic Aug. 30, 2022, 8:29 a.m. UTC | #1 
On 29.08.22 19:30, Christian Storm wrote:
> EBG's do_env_set() gets wired to bootloader_env_set(),
> hence spare this indirection.
> 
> Signed-off-by: Christian Storm <christian.storm@siemens.com>
> ---
>   bootloader/ebg.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bootloader/ebg.c b/bootloader/ebg.c
> index bb369d0..09e2785 100644
> --- a/bootloader/ebg.c
> +++ b/bootloader/ebg.c
> @@ -174,7 +174,7 @@ static int do_apply_list(const char *filename)
>   		key = strtok(line, "=");
>   		value = strtok(NULL, "\t\n");
>   		if (value != NULL && key != NULL) {
> -			if ((ret = bootloader_env_set(key, value)) != 0) {
> +			if ((ret = do_env_set(key, value)) != 0) {
>   				break;
>   			}
>   		}

Reviewed-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/bootloader/ebg.c b/bootloader/ebg.c
index bb369d0..09e2785 100644
--- a/bootloader/ebg.c
+++ b/bootloader/ebg.c
@@ -174,7 +174,7 @@  static int do_apply_list(const char *filename)
 		key = strtok(line, "=");
 		value = strtok(NULL, "\t\n");
 		if (value != NULL && key != NULL) {
-			if ((ret = bootloader_env_set(key, value)) != 0) {
+			if ((ret = do_env_set(key, value)) != 0) {
 				break;
 			}
 		}