| Message ID | 20220530055423.1292275-1-dominique.martinet@atmark-techno.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v2,1/3] core/bootloader: print list of registered bootloaders as TRACE | expand |
On 30.05.22 07:54, Dominique Martinet wrote: > bootloaders list should not change from one run to another, print the > list of available bootloaders at TRACE level instead of INFO. > > The selected bootloader is still printed as INFO, as that is more > likely to cause problems is the value is not expected. > > Example output, the first few info lines go from: > ---- > [INFO ] : SWUPDATE running : [print_registered_bootloaders] : Registered bootloaders: > [INFO ] : SWUPDATE running : [print_registered_bootloaders] : uboot loaded. > [INFO ] : SWUPDATE running : [print_registered_bootloaders] : none loaded. > [INFO ] : SWUPDATE running : [print_registered_bootloaders] : grub loaded. > [INFO ] : SWUPDATE running : [main] : Using default bootloader interface: none > ---- > to > ---- > [INFO ] : SWUPDATE running : [main] : Using default bootloader interface: none > ---- > > Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com> > --- > v2: split off only bootloaders info message as discussed > > core/bootloader.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/core/bootloader.c b/core/bootloader.c > index 5694d43d6ceb..b8678b8c3710 100644 > --- a/core/bootloader.c > +++ b/core/bootloader.c > @@ -62,9 +62,9 @@ const char* get_bootloader(void) > > void print_registered_bootloaders(void) > { > - INFO("Registered bootloaders:"); > + TRACE("Registered bootloaders:"); > for (unsigned int i = 0; i < num_available; i++) { > - INFO("\t%s\t%s", available[i].name, > + TRACE("\t%s\t%s", available[i].name, > available[i].funcs == NULL ? "shared lib not found." > : "loaded."); > } Applied to -master, thanks ! Bext regards, Stefano Babic
diff --git a/core/bootloader.c b/core/bootloader.c index 5694d43d6ceb..b8678b8c3710 100644 --- a/core/bootloader.c +++ b/core/bootloader.c @@ -62,9 +62,9 @@ const char* get_bootloader(void) void print_registered_bootloaders(void) { - INFO("Registered bootloaders:"); + TRACE("Registered bootloaders:"); for (unsigned int i = 0; i < num_available; i++) { - INFO("\t%s\t%s", available[i].name, + TRACE("\t%s\t%s", available[i].name, available[i].funcs == NULL ? "shared lib not found." : "loaded."); }
bootloaders list should not change from one run to another, print the list of available bootloaders at TRACE level instead of INFO. The selected bootloader is still printed as INFO, as that is more likely to cause problems is the value is not expected. Example output, the first few info lines go from: ---- [INFO ] : SWUPDATE running : [print_registered_bootloaders] : Registered bootloaders: [INFO ] : SWUPDATE running : [print_registered_bootloaders] : uboot loaded. [INFO ] : SWUPDATE running : [print_registered_bootloaders] : none loaded. [INFO ] : SWUPDATE running : [print_registered_bootloaders] : grub loaded. [INFO ] : SWUPDATE running : [main] : Using default bootloader interface: none ---- to ---- [INFO ] : SWUPDATE running : [main] : Using default bootloader interface: none ---- Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com> --- v2: split off only bootloaders info message as discussed core/bootloader.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)