Message ID | 20211209010659.724523-4-dominique.martinet@atmark-techno.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <swupdate+bncBCWIVBV7SUGRBPFNYWGQMGQEUUUDKEA@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20210112 header.b=Ey/aX/2g; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2607:f8b0:4864:20::53e; helo=mail-pg1-x53e.google.com; envelope-from=swupdate+bncbcwivbv7sugrbpfnywgqmgqeuuudkea@googlegroups.com; receiver=<UNKNOWN>) Received: from mail-pg1-x53e.google.com (mail-pg1-x53e.google.com [IPv6:2607:f8b0:4864:20::53e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4J8bV84sMlz9t55 for <incoming@patchwork.ozlabs.org>; Thu, 9 Dec 2021 12:07:11 +1100 (AEDT) Received: by mail-pg1-x53e.google.com with SMTP id i12-20020a63584c000000b00330ec6e2c37sf2275762pgm.7 for <incoming@patchwork.ozlabs.org>; Wed, 08 Dec 2021 17:07:11 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1639012029; cv=pass; d=google.com; s=arc-20160816; b=XSD2eCZMPcJ/jInjlGDSywJCf9lbFyk3BTye6QlqC4J9n6gwtxAN+yeDL3n8bGKZf3 2A7L1H3CzumYXtqKEgbDbS02XYxXwZkLbSf4z6hzGXd8hPlgnSEmj97JuvVtSXhiOOkg rsBcuy3G1xAjGf/mGT40SHm6HfZOw8+wjC/1Xow7nE1gQ85C+J8HMBRZ8H5DyxJFkn1F Qc/Wykz2M4st5VUX499wzvV8BTdCD1b8xgzGta8P4UEsC3cHe9zio0wk46dhzEs3/3ml FxqyvSzAYutDhDowIoBQ6Ps79hgSyC7KVRe+DTTCLVdeho2kqBRrja+/qSTeM1qvD8IW 6Q0Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=TPzVfQWVcJQuKjGO5nlL3Fc4lvwjNtzprcQgh8H69XQ=; b=kYKYLT/2Wmuqs0h9sv8RBNRrVBRLFj6Y9jc9Lql8jFiw9ZsqBr/OZf2XUACrs6bkn7 xoJz5WgoU0z8InOVJph5wBtQRBMVAxOoOYOq5VlZ6eIxNoRQ/07C3DN5DPCMKNF8mEJG K4DP6Jz15cKDyb41xv3IS/WhwTp4SbqHQBOswoIhM4JtVjKQUmx83TfrJKAnWNmnnCTV 7kC9iqvrw+KYCoXmX4vqUTxcfzb56yWpKDzRoQr6rO8bKCm0kq6Ry6o1+siEE39UAjvB GA5LTkKTbFwv2Q/xbxwvzs+PQu/NGYTQ1feD1REmzwL/Ju7UuFe4gjHH78YrUuXHciqh VSzA== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of dominique.martinet@atmark-techno.com designates 35.74.137.57 as permitted sender) smtp.mailfrom=dominique.martinet@atmark-techno.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20210112; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=TPzVfQWVcJQuKjGO5nlL3Fc4lvwjNtzprcQgh8H69XQ=; b=Ey/aX/2gjuRG8Hf33GEY3WlI9601dAFEi4WHvovVb87qU2cxmsXYgb22zo8x5vzHIo CpBeWFUFs2DE1TW/VwWR9VRTI8OvWR3LtOwdmGroCXshxM8+gxIx7W+O8I1Q7JO4l/bN 7Xu3AOdK0JYyCVFXx16W3wyn9GBhX0Vn3vuFjtPxF/gDYSQ2E4NKtm7nXE5krPSpDdQS kacNbw+301wh5RAueqCbO2rTC43ldF6A0LZE+ByLI8++VL4UKA9ELppnDCGv4SoYMGXG 8umU2qeRNOrrkDpSQGYb3iGelf2H2fRgtPdCm9IysbJ5Q2F0mgpsyRe9jIm1QdOElDac 25fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=TPzVfQWVcJQuKjGO5nlL3Fc4lvwjNtzprcQgh8H69XQ=; b=nfDzQD+Cey/YFesNFdPeAYD49xDFUx4fBPq/GxIPe4rmr1ANgCWXXIVjcoh5AIJ7n2 DpXDHn7fXg5Yu1xL1nhcwa9ZtAN2cdgOyeJQbFXufAQ/SA7GfcsVkPRYry20LTHwrbG4 vGf3BTsR0oYgtJ88eCWOtWKdELtgLGzI95z51ojE7dqIYCRjAcWiwPDI+j8Rs1TaXvly CeH+puj4YrxvuxxeqehhdkFMwYZ0A0tNgJ5Q7fbRLOamxwVoijg4ntWY1Br0II4L+TEH a4NKE8D3lvZl/Tzga72K4Tvl/vOPYrMTqBKjtPMtOUV37nOQ9K/xt7oL9jcAO/n/9hU8 zHwA== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM532rxiB8Uiq7GkMCBcceZ4IriBwKcMtLbDN5mPAcW/BmJ9/a2RFr XRTsyd6/3VXWKMRT8FfjJcg= X-Google-Smtp-Source: ABdhPJwgCh1qp3NqkYYRMQZh+H1Ke61pF7ibFzoTvQtmtryDoVJGxYtPE9S/kvftwSjI/gccTQ/CwQ== X-Received: by 2002:a17:902:ea09:b0:141:ec88:4410 with SMTP id s9-20020a170902ea0900b00141ec884410mr64703252plg.51.1639012029001; Wed, 08 Dec 2021 17:07:09 -0800 (PST) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a17:902:d50e:: with SMTP id b14ls2087410plg.7.gmail; Wed, 08 Dec 2021 17:07:08 -0800 (PST) X-Received: by 2002:a17:90a:7ac8:: with SMTP id b8mr11432053pjl.206.1639012028241; Wed, 08 Dec 2021 17:07:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1639012028; cv=none; d=google.com; s=arc-20160816; b=YpohO80aeyaBxcy6wo8DDOB89cV4/iBUGaB3F1q52GcMn505VXlkLyU+jHP8A1ci2i 9nZDVJdlS6g1tWIZLz1IM8gB4X0jv9l9lJotIj344mZajS1IPfSADMbt7vSmJR8etYHz XNvciO/lLwjeKKyrmnklEjYkAN3n0s2O120cxq6lOKgouuaKhuoApyBYtwUZw4/mdMc+ xD6l1H18SW1sLlbuNFmyVGYWNuTR4PeZLDUKq1ZMPVjEjC63ve31Nap42xIIfJU4iZid ikpTlVVcleOfejkuYBzIsnz5iCWKZKYddVUzblCtiEwmP3IejxqSLP+1HRHtr3vT/xBb 1AwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=vU/EkTXJ4VtgICjWp4bhVuVGVBsXJ4CUtw31WN/7RhM=; b=evyZOGeditjqdGV5Wtv5UqHwCdM3sg21YxWH71jKsK4s6sgpOwSoLAdBrjiiAWSRmu +mCU7cohsTPgDaQI6ufuGzyHXpEUqKRr6k9AE1RNlN3XOR6bxkcipv8xrgpK207qmHbV M2GRvOppDwh+7MoyBV+ueep7AQVog7ifmxg3Xo15i2iMm6CDbz3DZAOVw+HN3hn1NJ2c XPG55Nbs9dvWSEgxb03ZDNldwTkuS0Cw6fFNTSNjh2MLJms98r7psJjfyEwAJV7ig3oE a0bzpttnKE46pfrxtIMkQVAhH5GHjfxiTVpimjnqfoj2IiOq8jUT6J1QvtRxgGoQ9u8v 6yLA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of dominique.martinet@atmark-techno.com designates 35.74.137.57 as permitted sender) smtp.mailfrom=dominique.martinet@atmark-techno.com Received: from gw2.atmark-techno.com (gw2.atmark-techno.com. [35.74.137.57]) by gmr-mx.google.com with ESMTP id x31si401641pfh.5.2021.12.08.17.07.08 for <swupdate@googlegroups.com>; Wed, 08 Dec 2021 17:07:08 -0800 (PST) Received-SPF: pass (google.com: domain of dominique.martinet@atmark-techno.com designates 35.74.137.57 as permitted sender) client-ip=35.74.137.57; Received: from gw2.atmark-techno.com (localhost [127.0.0.1]) by gw2.atmark-techno.com (Postfix) with ESMTP id 183DF20D39 for <swupdate@googlegroups.com>; Thu, 9 Dec 2021 10:07:07 +0900 (JST) Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by gw2.atmark-techno.com (Postfix) with ESMTPS id A430C20D39 for <swupdate@googlegroups.com>; Thu, 9 Dec 2021 10:07:06 +0900 (JST) Received: by mail-pj1-f71.google.com with SMTP id a16-20020a17090aa51000b001a78699acceso4767938pjq.8 for <swupdate@googlegroups.com>; Wed, 08 Dec 2021 17:07:06 -0800 (PST) X-Received: by 2002:a63:1018:: with SMTP id f24mr19037482pgl.20.1639012025711; Wed, 08 Dec 2021 17:07:05 -0800 (PST) X-Received: by 2002:a63:1018:: with SMTP id f24mr19037467pgl.20.1639012025520; Wed, 08 Dec 2021 17:07:05 -0800 (PST) Received: from pc-0115 (145.82.198.104.bc.googleusercontent.com. [104.198.82.145]) by smtp.gmail.com with ESMTPSA id d9sm5070697pfu.144.2021.12.08.17.07.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Dec 2021 17:07:05 -0800 (PST) Received: from martinet by pc-0115 with local (Exim 4.95) (envelope-from <martinet@pc-0115>) id 1mv7to-0032Uq-0q; Thu, 09 Dec 2021 10:07:04 +0900 From: Dominique Martinet <dominique.martinet@atmark-techno.com> To: swupdate@googlegroups.com Cc: Dominique Martinet <dominique.martinet@atmark-techno.com> Subject: [swupdate] [PATCH v2 4/4] write_notify_msg: silence status client disappearing messages Date: Thu, 9 Dec 2021 10:06:59 +0900 Message-Id: <20211209010659.724523-4-dominique.martinet@atmark-techno.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211209010659.724523-1-dominique.martinet@atmark-techno.com> References: <20211209010659.724523-1-dominique.martinet@atmark-techno.com> MIME-Version: 1.0 X-Original-Sender: dominique.martinet@atmark-techno.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of dominique.martinet@atmark-techno.com designates 35.74.137.57 as permitted sender) smtp.mailfrom=dominique.martinet@atmark-techno.com Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: <swupdate.googlegroups.com> X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: <https://groups.google.com/group/swupdate/post>, <mailto:swupdate@googlegroups.com> List-Help: <https://groups.google.com/support/>, <mailto:swupdate+help@googlegroups.com> List-Archive: <https://groups.google.com/group/swupdate List-Subscribe: <https://groups.google.com/group/swupdate/subscribe>, <mailto:swupdate+subscribe@googlegroups.com> List-Unsubscribe: <mailto:googlegroups-manage+605343134186+unsubscribe@googlegroups.com>, <https://groups.google.com/group/swupdate/subscribe> |
Series |
[v2,1/4] ipc_notify_receive: add timeout_ms argument
|
expand
|
diff --git a/core/network_thread.c b/core/network_thread.c index 1b63690a2af5..4dd3ec27ae8f 100644 --- a/core/network_thread.c +++ b/core/network_thread.c @@ -141,8 +141,6 @@ static int write_notify_msg(ipc_message *msg, int sockfd) */ if (n == 0) { fprintf(stderr, "Error: A status client is not responding, removing it.\n"); - } else { - fprintf(stderr, "A status client disappeared, removing it: %s\n", strerror(errno)); } ret = -1; break;
There is currently no IPC message to signal we are going to quit, so there status disappearing messages will always appear and do not bring useful information. A better fix would be to add a new message type NOTIFY_STREAM_END or similar to unregister the stream before closing, but it does not add much value over what we currently do Signed-off-by: Dominique Martinet <dominique.martinet@atmark-techno.com> --- v2: trivial rebase on master core/network_thread.c | 2 -- 1 file changed, 2 deletions(-)