Message ID | 20211204192101.46818-1-jan.vermaete@gmail.com |
---|---|
State | Changes Requested |
Headers | show |
Series | [1/2] Update of the website. | expand |
Hi Jan, On 04.12.21 20:21, Jan Vermaete wrote: > The web-app website was not building anymore for me with Ubuntu 20.04. I cannot confirm this, I see exactly the opposite: build successful in -master, build fails if I apply your patch. Are you using npm (6.14) delivered in 20.04 ? From master: $ npm install npm WARN deprecated popper.js@1.16.1: You can find the new Popper v2 at @popperjs/core, this package is dedicated to the legacy v1 npm WARN deprecated request@2.88.0: request has been deprecated, see https://github.com/request/request/issues/3142 npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. Upgrade to chokidar 3 with 15x less dependencies. npm WARN deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142 npm WARN deprecated har-validator@5.1.5: this library is no longer supported npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ and could be using insecure binaries. Upgrade to fsevents 2. npm WARN deprecated circular-json@0.3.3: CircularJSON is in maintenance only, flatted is its successor. npm WARN deprecated resolve-url@0.2.1: https://github.com/lydell/resolve-url#deprecated npm WARN deprecated urix@0.1.0: Please see https://github.com/lydell/urix#deprecated > node-sass@4.14.1 install /tmp/swupdate/web-app/node_modules/node-sass > node scripts/install.js Cached binary found at /home/stefano/.npm/node-sass/4.14.1/linux-x64-64_binding.node > node-sass@4.14.1 postinstall /tmp/swupdate/web-app/node_modules/node-sass > node scripts/build.js Binary found at /tmp/swupdate/web-app/node_modules/node-sass/vendor/linux-x64-64/binding.node Testing binary Binary is fine > gifsicle@4.0.1 postinstall /tmp/swupdate/web-app/node_modules/gifsicle > node lib/install.js ✔ gifsicle pre-build test passed successfully > jpegtran-bin@4.0.0 postinstall /tmp/swupdate/web-app/node_modules/jpegtran-bin > node lib/install.js ✔ jpegtran pre-build test passed successfully > optipng-bin@5.1.0 postinstall /tmp/swupdate/web-app/node_modules/optipng-bin > node lib/install.js ✔ optipng pre-build test passed successfully > @fortawesome/fontawesome-free@5.15.4 postinstall /tmp/swupdate/web-app/node_modules/@fortawesome/fontawesome-free > node attribution.js Font Awesome Free 5.15.4 by @fontawesome - https://fontawesome.com License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License) npm notice created a lockfile as package-lock.json. You should commit this file. npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.2.7 (node_modules/chokidar/node_modules/fsevents): npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.13: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"}) npm WARN swupdate@0.2.0 No repository field. added 1096 packages from 642 contributors and audited 1098 packages in 10.654s 58 packages are looking for funding run `npm fund` for details found 27 vulnerabilities (16 moderate, 11 high) run `npm audit fix` to fix them, or `npm audit` for details $ npm run build > swupdate@0.2.0 build /tmp/swupdate/web-app > gulp build [16:04:57] Using gulpfile /tmp/swupdate/web-app/gulpfile.js [16:04:57] Starting 'build'... [16:04:57] Starting 'clean'... [16:04:57] Finished 'clean' after 1.82 ms [16:04:57] Starting 'copy-css'... [16:04:57] Starting 'copy-js'... [16:04:57] Starting 'copy-fonts'... [16:04:57] Starting 'sass'... [16:04:57] Starting 'minify-css'... [16:04:57] Starting 'minify-js'... [16:04:57] Starting 'minify-html'... [16:04:57] Starting 'resize-images'... [16:04:57] Finished 'copy-css' after 13 ms [16:04:57] Finished 'copy-js' after 13 ms [16:04:57] Finished 'copy-fonts' after 13 ms [16:04:57] Finished 'sass' after 13 ms [16:04:57] Finished 'minify-css' after 13 ms [16:04:57] Finished 'minify-js' after 13 ms [16:04:57] Finished 'minify-html' after 13 ms [16:04:57] Finished 'resize-images' after 13 ms [16:04:57] Finished 'build' after 17 ms [16:04:59] gulp-imagemin: ✔ favicon.png (saved 74 B - 7.2%) [16:04:59] gulp-imagemin: ✔ logo.png (saved 74 B - 8.2%) [16:04:59] gulp-imagemin: ✔ background.jpg (saved 24 B - 0%) [16:04:59] gulp-imagemin: Minified 3 images (saved 172 B - 0%) Best regards, Stefano Babic > And also not with only updating npm, as I did in the past. > Now I had to update nodejs too: https://github.com/nodesource/distributions/blob/master/README.md > > And with some small changes in gulpfile.js and packages.json it's building again. > > I have update the package list with 'ncu'. > Installed with `sudo npm install -g npm-check-updates` > > Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com> > --- > web-app/gulpfile.js | 31 +++++++++++++++++-------------- > web-app/package.json | 40 +++++++++++++++++++++------------------- > 2 files changed, 38 insertions(+), 33 deletions(-) > > diff --git a/web-app/gulpfile.js b/web-app/gulpfile.js > index 19d17a1..3e1b343 100755 > --- a/web-app/gulpfile.js > +++ b/web-app/gulpfile.js > @@ -5,20 +5,23 @@ > * SPDX-License-Identifier: MIT > */ > > -var cleanCSS = require('gulp-clean-css') > -var del = require('del') > -var gulp = require('gulp') > -var gzip = require('gulp-gzip') > -var imagemin = require('gulp-imagemin') > -var filter = require('gulp-filter') > -var htmlmin = require('gulp-htmlmin') > -var minify = require('gulp-minify') > -var rename = require('gulp-rename') > -var replace = require('gulp-replace') > -var sass = require('gulp-sass') > -var tar = require('gulp-tar') > -var useref = require('gulp-useref') > -var minimist = require('minimist') > +import cleanCSS from 'gulp-clean-css' > +import del from 'del' > +import gulp from 'gulp' > +import gzip from 'gulp-gzip' > +import imagemin from 'gulp-imagemin' > +import filter from 'gulp-filter' > +import htmlmin from 'gulp-htmlmin' > +import minify from 'gulp-minify' > +import rename from 'gulp-rename' > +import replace from 'gulp-replace' > +import dartSass from 'sass' > +import gulpSass from 'gulp-sass' > +import tar from 'gulp-tar' > +import useref from 'gulp-useref' > +import minimist from 'minimist' > + > +const sass = gulpSass(dartSass) > > var knownOptions = { > string: 'output', > diff --git a/web-app/package.json b/web-app/package.json > index 2909b45..f7b5a21 100755 > --- a/web-app/package.json > +++ b/web-app/package.json > @@ -3,6 +3,7 @@ > "version": "0.2.0", > "description": "Software Update for Embedded Systems Web Front End", > "main": "index.html", > + "type": "module", > "scripts": { > "htmlhint": "htmlhint *.html", > "standard": "standard --fix *.js", > @@ -15,32 +16,33 @@ > "license": "MIT", > "devDependencies": { > "csslint": "^1.0.5", > - "del": "^3.0.0", > - "gulp": "^4.0.0", > - "gulp-clean-css": "^4.0.0", > - "gulp-filter": "^5.1.0", > + "del": "^6.0.0", > + "gulp": "^4.0.2", > + "sass": "^1.44.0", > + "gulp-clean-css": "^4.3.0", > + "gulp-filter": "^7.0.0", > "gulp-gzip": "^1.4.2", > "gulp-html-replace": "^1.6.2", > "gulp-htmlmin": "^5.0.1", > - "gulp-imagemin": "^5.0.3", > + "gulp-imagemin": "^8.0.0", > "gulp-minify": "^3.1.0", > - "gulp-rename": "^1.4.0", > - "gulp-replace": "^1.0.0", > - "gulp-sass": "^4.0.2", > - "gulp-tar": "^2.1.0", > - "gulp-useref": "^3.1.6", > - "htmlhint": "^0.10.1", > - "minimist": "^1.2.0", > - "sass-lint": "^1.12.1", > - "standard": "^12.0.1", > - "eslint": "^5.11.1" > + "gulp-rename": "^2.0.0", > + "gulp-replace": "^1.1.3", > + "gulp-sass": "^5.0.0", > + "gulp-tar": "^3.1.0", > + "gulp-useref": "^5.0.0", > + "htmlhint": "^1.0.0", > + "minimist": "^1.2.5", > + "sass-lint": "^1.13.1", > + "standard": "^16.0.4", > + "eslint": "^8.4.0" > }, > "dependencies": { > - "@fortawesome/fontawesome-free": "^5.6.3", > - "bootstrap": "^4.2.1", > + "@fortawesome/fontawesome-free": "^5.15.4", > + "bootstrap": "^5.1.3", > "popper.js": "^1.14.6", > - "dropzone": "5.5.1", > - "jquery": "^3.3.1" > + "dropzone": "5.9.3", > + "jquery": "^3.6.0" > }, > "standard": { > "ignore": [ >
HI Stefano, I'm using npm version 8.2.0. And it's installed at /usr/local/bin, what's not the one that came with Ubuntu. Fair, let's wait with the patch until Ubuntu moves to a more recent version. Those who are, like me, kind of forced to use the latest for the good feeling of security can use the patch to have everything working at the LTS version of NPM. Br, On Sun, Dec 5, 2021 at 4:06 PM Stefano Babic <sbabic@denx.de> wrote: > Hi Jan, > > On 04.12.21 20:21, Jan Vermaete wrote: > > The web-app website was not building anymore for me with Ubuntu 20.04. > > I cannot confirm this, I see exactly the opposite: build successful in > -master, build fails if I apply your patch. Are you using npm (6.14) > delivered in 20.04 ? > > From master: > > $ npm install > > npm WARN deprecated popper.js@1.16.1: You can find the new Popper v2 at > @popperjs/core, this package is dedicated to the legacy v1 > npm WARN deprecated request@2.88.0: request has been deprecated, see > https://github.com/request/request/issues/3142 > npm WARN deprecated chokidar@2.1.8: Chokidar 2 will break on node v14+. > Upgrade to chokidar 3 with 15x less dependencies. > npm WARN deprecated request@2.88.2: request has been deprecated, see > https://github.com/request/request/issues/3142 > npm WARN deprecated har-validator@5.1.5: this library is no longer > supported > npm WARN deprecated fsevents@1.2.13: fsevents 1 will break on node v14+ > and could be using insecure binaries. Upgrade to fsevents 2. > npm WARN deprecated circular-json@0.3.3: CircularJSON is in maintenance > only, flatted is its successor. > npm WARN deprecated resolve-url@0.2.1: > https://github.com/lydell/resolve-url#deprecated > npm WARN deprecated urix@0.1.0: Please see > https://github.com/lydell/urix#deprecated > > > node-sass@4.14.1 install /tmp/swupdate/web-app/node_modules/node-sass > > node scripts/install.js > > Cached binary found at > /home/stefano/.npm/node-sass/4.14.1/linux-x64-64_binding.node > > > node-sass@4.14.1 postinstall > /tmp/swupdate/web-app/node_modules/node-sass > > node scripts/build.js > > Binary found at > > /tmp/swupdate/web-app/node_modules/node-sass/vendor/linux-x64-64/binding.node > Testing binary > Binary is fine > > > gifsicle@4.0.1 postinstall /tmp/swupdate/web-app/node_modules/gifsicle > > node lib/install.js > > ✔ gifsicle pre-build test passed successfully > > > jpegtran-bin@4.0.0 postinstall > /tmp/swupdate/web-app/node_modules/jpegtran-bin > > node lib/install.js > > ✔ jpegtran pre-build test passed successfully > > > optipng-bin@5.1.0 postinstall > /tmp/swupdate/web-app/node_modules/optipng-bin > > node lib/install.js > > ✔ optipng pre-build test passed successfully > > > @fortawesome/fontawesome-free@5.15.4 postinstall > /tmp/swupdate/web-app/node_modules/@fortawesome/fontawesome-free > > node attribution.js > > Font Awesome Free 5.15.4 by @fontawesome - https://fontawesome.com > License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: > SIL OFL 1.1, Code: MIT License) > > npm notice created a lockfile as package-lock.json. You should commit > this file. > npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.2.7 > (node_modules/chokidar/node_modules/fsevents): > npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for > fsevents@1.2.13: wanted {"os":"darwin","arch":"any"} (current: > {"os":"linux","arch":"x64"}) > npm WARN swupdate@0.2.0 No repository field. > > added 1096 packages from 642 contributors and audited 1098 packages in > 10.654s > > 58 packages are looking for funding > run `npm fund` for details > > found 27 vulnerabilities (16 moderate, 11 high) > run `npm audit fix` to fix them, or `npm audit` for details > > $ npm run build > > > swupdate@0.2.0 build /tmp/swupdate/web-app > > gulp build > > [16:04:57] Using gulpfile /tmp/swupdate/web-app/gulpfile.js > [16:04:57] Starting 'build'... > [16:04:57] Starting 'clean'... > [16:04:57] Finished 'clean' after 1.82 ms > [16:04:57] Starting 'copy-css'... > [16:04:57] Starting 'copy-js'... > [16:04:57] Starting 'copy-fonts'... > [16:04:57] Starting 'sass'... > [16:04:57] Starting 'minify-css'... > [16:04:57] Starting 'minify-js'... > [16:04:57] Starting 'minify-html'... > [16:04:57] Starting 'resize-images'... > [16:04:57] Finished 'copy-css' after 13 ms > [16:04:57] Finished 'copy-js' after 13 ms > [16:04:57] Finished 'copy-fonts' after 13 ms > [16:04:57] Finished 'sass' after 13 ms > [16:04:57] Finished 'minify-css' after 13 ms > [16:04:57] Finished 'minify-js' after 13 ms > [16:04:57] Finished 'minify-html' after 13 ms > [16:04:57] Finished 'resize-images' after 13 ms > [16:04:57] Finished 'build' after 17 ms > [16:04:59] gulp-imagemin: ✔ favicon.png (saved 74 B - 7.2%) > [16:04:59] gulp-imagemin: ✔ logo.png (saved 74 B - 8.2%) > [16:04:59] gulp-imagemin: ✔ background.jpg (saved 24 B - 0%) > [16:04:59] gulp-imagemin: Minified 3 images (saved 172 B - 0%) > > Best regards, > Stefano Babic > > > And also not with only updating npm, as I did in the past. > > Now I had to update nodejs too: > https://github.com/nodesource/distributions/blob/master/README.md > > > > And with some small changes in gulpfile.js and packages.json it's > building again. > > > > I have update the package list with 'ncu'. > > Installed with `sudo npm install -g npm-check-updates` > > > > Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com> > > --- > > web-app/gulpfile.js | 31 +++++++++++++++++-------------- > > web-app/package.json | 40 +++++++++++++++++++++------------------- > > 2 files changed, 38 insertions(+), 33 deletions(-) > > > > diff --git a/web-app/gulpfile.js b/web-app/gulpfile.js > > index 19d17a1..3e1b343 100755 > > --- a/web-app/gulpfile.js > > +++ b/web-app/gulpfile.js > > @@ -5,20 +5,23 @@ > > * SPDX-License-Identifier: MIT > > */ > > > > -var cleanCSS = require('gulp-clean-css') > > -var del = require('del') > > -var gulp = require('gulp') > > -var gzip = require('gulp-gzip') > > -var imagemin = require('gulp-imagemin') > > -var filter = require('gulp-filter') > > -var htmlmin = require('gulp-htmlmin') > > -var minify = require('gulp-minify') > > -var rename = require('gulp-rename') > > -var replace = require('gulp-replace') > > -var sass = require('gulp-sass') > > -var tar = require('gulp-tar') > > -var useref = require('gulp-useref') > > -var minimist = require('minimist') > > +import cleanCSS from 'gulp-clean-css' > > +import del from 'del' > > +import gulp from 'gulp' > > +import gzip from 'gulp-gzip' > > +import imagemin from 'gulp-imagemin' > > +import filter from 'gulp-filter' > > +import htmlmin from 'gulp-htmlmin' > > +import minify from 'gulp-minify' > > +import rename from 'gulp-rename' > > +import replace from 'gulp-replace' > > +import dartSass from 'sass' > > +import gulpSass from 'gulp-sass' > > +import tar from 'gulp-tar' > > +import useref from 'gulp-useref' > > +import minimist from 'minimist' > > + > > +const sass = gulpSass(dartSass) > > > > var knownOptions = { > > string: 'output', > > diff --git a/web-app/package.json b/web-app/package.json > > index 2909b45..f7b5a21 100755 > > --- a/web-app/package.json > > +++ b/web-app/package.json > > @@ -3,6 +3,7 @@ > > "version": "0.2.0", > > "description": "Software Update for Embedded Systems Web Front End", > > "main": "index.html", > > + "type": "module", > > "scripts": { > > "htmlhint": "htmlhint *.html", > > "standard": "standard --fix *.js", > > @@ -15,32 +16,33 @@ > > "license": "MIT", > > "devDependencies": { > > "csslint": "^1.0.5", > > - "del": "^3.0.0", > > - "gulp": "^4.0.0", > > - "gulp-clean-css": "^4.0.0", > > - "gulp-filter": "^5.1.0", > > + "del": "^6.0.0", > > + "gulp": "^4.0.2", > > + "sass": "^1.44.0", > > + "gulp-clean-css": "^4.3.0", > > + "gulp-filter": "^7.0.0", > > "gulp-gzip": "^1.4.2", > > "gulp-html-replace": "^1.6.2", > > "gulp-htmlmin": "^5.0.1", > > - "gulp-imagemin": "^5.0.3", > > + "gulp-imagemin": "^8.0.0", > > "gulp-minify": "^3.1.0", > > - "gulp-rename": "^1.4.0", > > - "gulp-replace": "^1.0.0", > > - "gulp-sass": "^4.0.2", > > - "gulp-tar": "^2.1.0", > > - "gulp-useref": "^3.1.6", > > - "htmlhint": "^0.10.1", > > - "minimist": "^1.2.0", > > - "sass-lint": "^1.12.1", > > - "standard": "^12.0.1", > > - "eslint": "^5.11.1" > > + "gulp-rename": "^2.0.0", > > + "gulp-replace": "^1.1.3", > > + "gulp-sass": "^5.0.0", > > + "gulp-tar": "^3.1.0", > > + "gulp-useref": "^5.0.0", > > + "htmlhint": "^1.0.0", > > + "minimist": "^1.2.5", > > + "sass-lint": "^1.13.1", > > + "standard": "^16.0.4", > > + "eslint": "^8.4.0" > > }, > > "dependencies": { > > - "@fortawesome/fontawesome-free": "^5.6.3", > > - "bootstrap": "^4.2.1", > > + "@fortawesome/fontawesome-free": "^5.15.4", > > + "bootstrap": "^5.1.3", > > "popper.js": "^1.14.6", > > - "dropzone": "5.5.1", > > - "jquery": "^3.3.1" > > + "dropzone": "5.9.3", > > + "jquery": "^3.6.0" > > }, > > "standard": { > > "ignore": [ > > > > -- > ===================================================================== > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de > ===================================================================== >
diff --git a/web-app/gulpfile.js b/web-app/gulpfile.js index 19d17a1..3e1b343 100755 --- a/web-app/gulpfile.js +++ b/web-app/gulpfile.js @@ -5,20 +5,23 @@ * SPDX-License-Identifier: MIT */ -var cleanCSS = require('gulp-clean-css') -var del = require('del') -var gulp = require('gulp') -var gzip = require('gulp-gzip') -var imagemin = require('gulp-imagemin') -var filter = require('gulp-filter') -var htmlmin = require('gulp-htmlmin') -var minify = require('gulp-minify') -var rename = require('gulp-rename') -var replace = require('gulp-replace') -var sass = require('gulp-sass') -var tar = require('gulp-tar') -var useref = require('gulp-useref') -var minimist = require('minimist') +import cleanCSS from 'gulp-clean-css' +import del from 'del' +import gulp from 'gulp' +import gzip from 'gulp-gzip' +import imagemin from 'gulp-imagemin' +import filter from 'gulp-filter' +import htmlmin from 'gulp-htmlmin' +import minify from 'gulp-minify' +import rename from 'gulp-rename' +import replace from 'gulp-replace' +import dartSass from 'sass' +import gulpSass from 'gulp-sass' +import tar from 'gulp-tar' +import useref from 'gulp-useref' +import minimist from 'minimist' + +const sass = gulpSass(dartSass) var knownOptions = { string: 'output', diff --git a/web-app/package.json b/web-app/package.json index 2909b45..f7b5a21 100755 --- a/web-app/package.json +++ b/web-app/package.json @@ -3,6 +3,7 @@ "version": "0.2.0", "description": "Software Update for Embedded Systems Web Front End", "main": "index.html", + "type": "module", "scripts": { "htmlhint": "htmlhint *.html", "standard": "standard --fix *.js", @@ -15,32 +16,33 @@ "license": "MIT", "devDependencies": { "csslint": "^1.0.5", - "del": "^3.0.0", - "gulp": "^4.0.0", - "gulp-clean-css": "^4.0.0", - "gulp-filter": "^5.1.0", + "del": "^6.0.0", + "gulp": "^4.0.2", + "sass": "^1.44.0", + "gulp-clean-css": "^4.3.0", + "gulp-filter": "^7.0.0", "gulp-gzip": "^1.4.2", "gulp-html-replace": "^1.6.2", "gulp-htmlmin": "^5.0.1", - "gulp-imagemin": "^5.0.3", + "gulp-imagemin": "^8.0.0", "gulp-minify": "^3.1.0", - "gulp-rename": "^1.4.0", - "gulp-replace": "^1.0.0", - "gulp-sass": "^4.0.2", - "gulp-tar": "^2.1.0", - "gulp-useref": "^3.1.6", - "htmlhint": "^0.10.1", - "minimist": "^1.2.0", - "sass-lint": "^1.12.1", - "standard": "^12.0.1", - "eslint": "^5.11.1" + "gulp-rename": "^2.0.0", + "gulp-replace": "^1.1.3", + "gulp-sass": "^5.0.0", + "gulp-tar": "^3.1.0", + "gulp-useref": "^5.0.0", + "htmlhint": "^1.0.0", + "minimist": "^1.2.5", + "sass-lint": "^1.13.1", + "standard": "^16.0.4", + "eslint": "^8.4.0" }, "dependencies": { - "@fortawesome/fontawesome-free": "^5.6.3", - "bootstrap": "^4.2.1", + "@fortawesome/fontawesome-free": "^5.15.4", + "bootstrap": "^5.1.3", "popper.js": "^1.14.6", - "dropzone": "5.5.1", - "jquery": "^3.3.1" + "dropzone": "5.9.3", + "jquery": "^3.6.0" }, "standard": { "ignore": [
The web-app website was not building anymore for me with Ubuntu 20.04. And also not with only updating npm, as I did in the past. Now I had to update nodejs too: https://github.com/nodesource/distributions/blob/master/README.md And with some small changes in gulpfile.js and packages.json it's building again. I have update the package list with 'ncu'. Installed with `sudo npm install -g npm-check-updates` Signed-off-by: Jan Vermaete <jan.vermaete@gmail.com> --- web-app/gulpfile.js | 31 +++++++++++++++++-------------- web-app/package.json | 40 +++++++++++++++++++++------------------- 2 files changed, 38 insertions(+), 33 deletions(-)