From patchwork Thu May 13 07:13:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Hilliard X-Patchwork-Id: 1477934 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2607:f8b0:4864:20::b3d; helo=mail-yb1-xb3d.google.com; envelope-from=swupdate+bncbcl4hcw73qcbbdnd6ocamgqe2qglgvq@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=ljkzMRCT; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=S2XdgPVv; dkim-atps=neutral Received: from mail-yb1-xb3d.google.com (mail-yb1-xb3d.google.com [IPv6:2607:f8b0:4864:20::b3d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4FgjYc5mNbz9sXM for ; Thu, 13 May 2021 17:13:22 +1000 (AEST) Received: by mail-yb1-xb3d.google.com with SMTP id n129-20020a2527870000b02904ed02e1aab5sf31089001ybn.21 for ; Thu, 13 May 2021 00:13:22 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1620889997; cv=pass; d=google.com; s=arc-20160816; b=Wvvl9Tacc8sZXwqhRwg+rtXrvMQFKE6IahZZXmL29UKsAFmN2YaJj2w1N8zMoMhXkH ZceK3sxC6ZTIJtuBKUwFd39QbU5gThWoSfjsTHI+ikZBjiIFdjD7wl+qM6D84xqyXszN kmGg/yaJA18dUTna9T1lRqxaCdr06AI//dih5y/ly22MPt8wwvIM9HNJJO9E/VK5U4xt tn2CV0caC+992VXw5WLEO86CauQJtfpnxSdOQ/wNtFLChi3EbsoHOLwfw3slcL8VoZJ4 nWGW0jthiP/wj2qR0IpkPXuKjKujRJjz2aOp9xr8O3McPCY9y2HW6HR6icEqwRI+BlAH 4bFQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:message-id:date :subject:cc:to:from:sender:dkim-signature:dkim-signature; bh=cSW0nLjEdPZ28pFKEZVj9WK/4jdlgfkifhVE27G+4fo=; b=b1W4ukeHHKgbGBkt2kiaeMlvPCL8KWD0Jacn7Pnr9golOingiCjQg+HwkjEpG0TEpa 8MK+P3DcVtoQSEDx2bgvR8Rjy3xiov0ZXUHQ3RaqYzKEpavkd/qymXYZvdrMex1hnAbo Ci0UZvJXP47M6fJ4lqmcfHnUtPWfP/9TMeIR7PFpbjb44im/xhQiuiUp5xZmkxYXywPO XbhhWufD3gDkqfpEwRdjCI/xxtS6kXgYkeGWb6gtLVgomj1O93o4+UwG+JS3uXQ4+5br B2cPCSHwWCgd39NtEJXhW/Vt2zhRh4fmupB4ZOZ/tCYS0pTzqh6ds24zz/7nuEa20Tjq whIQ== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CUV7xEhJ; spf=pass (google.com: domain of james.hilliard1@gmail.com designates 2607:f8b0:4864:20::d32 as permitted sender) smtp.mailfrom=james.hilliard1@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=cSW0nLjEdPZ28pFKEZVj9WK/4jdlgfkifhVE27G+4fo=; b=ljkzMRCT04IrAieW3VRyK6qWppSWiPiAQFD5/O2Vk6EYejFgVnEM/CctislV4+7ROd dEUmYuka/PUdWu0rcxGxR2P4I5r9e9bSGzZE3KcKoersPKVtmNQpEtcvkyaCIUyrN0cu pUPWVHwHmyMGHhslO+JMujO2Jt14cmLuVOPLWTToxDLq3/RC5OTCvfBbvB4ejTCMKzDB XrgnMfUg9BSiGMZqeXGMcuxa6eeqvktrz/5XNNciQQMDNVuQ0siFWVUdvDXTcu1SEjqY PQDPK3nlc3/HWLIzurtSJRGSrczA5KSioA8ayuPcanFgDBOPS9B08wsy+OSd1hxuWAMi 5mXg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-subscribe:list-unsubscribe; bh=cSW0nLjEdPZ28pFKEZVj9WK/4jdlgfkifhVE27G+4fo=; b=S2XdgPVvw1rKsSTLf60utOwuCcqwwtsQNaBbT8yxhTflSjTRL0U7zWIVNCu4PgI39L bOg9mpVtlCPZ3CiNcYvvalQ+kjsM2GnVfzt7dHLfABu6rjNAvNPn2imdB/ZSoiiFcqiN NdSnOljNoDeZWSFkXXH2a+Y30NhYFPGL8OYshnFhhmckdGrwNoSQcj1nobSUJWTDTton UuH4iBPASD9m7ZjwtBUCrX4OFOTtlbH4s6LacYAHrogeCdhLhCmVK3Lq9RBbHfVRczjf sQ4p5uxgCN5XQbJ1LvQ7clxPcUPQA2RxCwotQ4vMzND2+EiVfpkXrZ6dO5h0m5nIMVf3 I3Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=cSW0nLjEdPZ28pFKEZVj9WK/4jdlgfkifhVE27G+4fo=; b=CZvBF+iNY5sWsvvAGujGfZF6vT65Au/eT/B6NEZNAQJXKlR6vdFWNO/3kYQrle4anU a+YrPYVvHC/PGn/9WjcZshdu7yhO2p6HpLcX4RiEtL0Zv8wtZSDTwS1yRcC1ePpQhqa6 hWjk0d2Ggf2it+T7S3kyHIXV/Goi1owgY9PmIuGTtcKEyt+l1QRwoTBYVYpu36NNaGe2 noBWj82jbtU27U6ShZXQnW+YDCUua1NsFn/hMrmlhtcP1ag+kXXRxu4WZ+vu5gNrvY4l 1//oxRhR/1Bh8tFIx3mrvxFEyUiu+c38Edh8ERSuai4F3rjxlfuGGbxbC8QqkCk4g4Vf VwLg== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM530hdjbmyWBpzEK3PCDtYUjEZtidFG563UCUbhQ9Ovyc1rUiuaf1 DG0pfhI5CbuFDnoqzrBzttY= X-Google-Smtp-Source: ABdhPJwc1l8PgHgX1BQtMVQuS/k8cDJUJaU4kEK7MOE6HFditqc9/nyxo0Gn6s3ErIb8RNcGzezzDQ== X-Received: by 2002:a25:d9d1:: with SMTP id q200mr52757311ybg.356.1620889997810; Thu, 13 May 2021 00:13:17 -0700 (PDT) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a25:7808:: with SMTP id t8ls2252469ybc.3.gmail; Thu, 13 May 2021 00:13:17 -0700 (PDT) X-Received: by 2002:a25:1855:: with SMTP id 82mr54101529yby.305.1620889997374; Thu, 13 May 2021 00:13:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1620889997; cv=none; d=google.com; s=arc-20160816; b=VDZqCBvntl6+ZkBngf0MMmZJuIjer068C6rHsDiPbiFDlr5EBO5CLkeP8dLUepybtG hhsUGhzfMunJS4MNxiFqS0O/In5Qnp6BKDu0bX7GBMQ4p6qi7iOsgkVdP3px2/Ddn8c3 4ubSsLImIiEOHI5K/SWeQWwBD+VdBjeZDJjuQJl+33gcQgbwyaKzPY/2SVAUAzcq3x/b 4Cdh9f0eASLSX52ECtylQbUzU5qREsGYBOinOeuZ2DD4IKBta3YQFLIGfB5TWqTDPIs1 RgYtkXaFN3Z9IkHQOM1EMCagkMvaA7FiiFgZq0q40VxPMfUwcDb2BLZzgcfTuP9/RfXZ 7xlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dkim-signature; bh=GZJAiAGWknTVRjXdYusygmFLWmITI14Nu27ysmN6+KE=; b=sacZwRBwCYQSDvzG0Tld1VvF/ONjQIv+lHo3NyUwDDGygaYs1SMIbUmFGszWVzl4uN 4YAXwuiIwFz9ShSxqKnoa6TK53yLxQ2cgpS8tyNTmdlBVgWwH0dsr3UxRpyDrcBgCurG T1tYBQ7O3ONsqLvTjcB7mEa3UncYqwfTH+WDeFXT8VwX5F7moqmOX+B+lJsgxzAUHOLz 5ycpJt/SYuHCfrq97poJnlZdA6lxnZ2Wz8gb/wRI/+R3Q+GySk4ZRRlI2odMDYIs6aw/ 6j7PB55+Abkz60i9iMT75ZwG8D/xEz1ZVzgTp+8LSIH7LasXF7TQnoczFYqc7vEYUyvT obzQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CUV7xEhJ; spf=pass (google.com: domain of james.hilliard1@gmail.com designates 2607:f8b0:4864:20::d32 as permitted sender) smtp.mailfrom=james.hilliard1@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com. [2607:f8b0:4864:20::d32]) by gmr-mx.google.com with ESMTPS id e5si125810ybb.3.2021.05.13.00.13.17 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 May 2021 00:13:17 -0700 (PDT) Received-SPF: pass (google.com: domain of james.hilliard1@gmail.com designates 2607:f8b0:4864:20::d32 as permitted sender) client-ip=2607:f8b0:4864:20::d32; Received: by mail-io1-xd32.google.com with SMTP id k16so9989571ios.10 for ; Thu, 13 May 2021 00:13:17 -0700 (PDT) X-Received: by 2002:a05:6602:27d0:: with SMTP id l16mr8745753ios.101.1620889996650; Thu, 13 May 2021 00:13:16 -0700 (PDT) Received: from MacBook-Pro.localdomain ([143.131.13.66]) by smtp.gmail.com with ESMTPSA id t2sm948576ilm.58.2021.05.13.00.13.15 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 May 2021 00:13:16 -0700 (PDT) From: James Hilliard To: swupdate@googlegroups.com Cc: James Hilliard Subject: [swupdate] [PATCH 1/1] diskpart: disable fdisk dialog driven partitioning Date: Thu, 13 May 2021 01:13:11 -0600 Message-Id: <20210513071311.84629-1-james.hilliard1@gmail.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Original-Sender: james.hilliard1@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CUV7xEhJ; spf=pass (google.com: domain of james.hilliard1@gmail.com designates 2607:f8b0:4864:20::d32 as permitted sender) smtp.mailfrom=james.hilliard1@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Since we don't support dialog driven partitioning we should ensure it is disabled as it can cause failures under some circumstances. Signed-off-by: James Hilliard Reviewed-by: Stefano Babic --- handlers/diskpart_handler.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/handlers/diskpart_handler.c b/handlers/diskpart_handler.c index 65010c1..641c6f9 100644 --- a/handlers/diskpart_handler.c +++ b/handlers/diskpart_handler.c @@ -194,6 +194,16 @@ static int diskpart(struct img_type *img, return -ENOMEM; } + /* + * The library uses dialog driven partitioning by default. + * Disable as we don't support interactive dialogs. + */ + ret = fdisk_disable_dialogs(cxt, 1); + if (ret) { + ERROR("Failed to disable dialogs"); + goto handler_release; + } + ret = fdisk_assign_device(cxt, img->device, 0); if (ret == -EACCES) { ERROR("no access to %s", img->device);