From patchwork Thu Apr 9 12:12:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Jonas X-Patchwork-Id: 1268575 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::43c; helo=mail-wr1-x43c.google.com; envelope-from=swupdate+bncbcemdfwl6alrbuncxt2akgqeioa7y7q@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=MY7LOjSX; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=SpQ4jSm3; dkim-atps=neutral Received: from mail-wr1-x43c.google.com (mail-wr1-x43c.google.com [IPv6:2a00:1450:4864:20::43c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 48yg5d5NRbz9sP7 for ; Thu, 9 Apr 2020 22:13:08 +1000 (AEST) Received: by mail-wr1-x43c.google.com with SMTP id 91sf6256326wro.1 for ; Thu, 09 Apr 2020 05:13:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1586434386; cv=pass; d=google.com; s=arc-20160816; b=eJrkkptgJvL5TNH8zpE5HroacoX89XZSOtWjN8QZCqvXrBLLeEfkRfyTcaGJ2UvBuQ N85ON9R4JhiYGUc+cuPIE4K4AVKe+XtHmYfdnv52pQT6BJIKubGO5ngEq3kkCCvKzup0 gYd88AfyFdEcUxWPgS4L+rNR8Cxf2cQQZjuYoiwxYcvGGx+qhIzht61NjauUResX66s2 2Ckss0SCvEezdODXws2XPEt2O4A0RI82UbdsVLtbru1Bb1L/eN0gM7Wqe8VTzVh4v/mW Nxgyu2boMw55q8bQr0sl8Ys6ymSCfFQ3t8gnme79h+1rlYM9kNalx2yaecbni+QvcELy sl8Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:message-id:date:subject:cc:to:from :mime-version:sender:dkim-signature:dkim-signature; bh=ZiY0/WDQhmakJpF2XsHS2yweTw8j6H+kGSbgybjprHs=; b=MviW/DOJ6ocbJwxT0NzmsQYiVTroURlAy/hxbl/1O1ZIm14f9zw4WupdY3uSDE1v7j aTCpRKQw0ZOWVHPB5d3hVshJNuly+AqyBKDIzeOtQOIlxnIwDOxy/CZ1gr7YAc/UQoRg xa9ZSo4CggPowB9IaVewaHjtcALXpsvKBPkym0UGQYy+8UWoY5gux4CD58kmyJy1WogZ HvLhwhS7o6roDR1mB9Lg7J738Wk13iAn93OhtJoexeLWOcBrD/r2Iitpk1jc5CYg3nMl XZDGurEX3cpg7LtqDLMszr8htMYlDYGqOLuNtKlhUM3/dhN8JIwUys5ve+l6Su1MoL0e T5Bw== ARC-Authentication-Results: i=2; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Cezk3RLz; spf=pass (google.com: domain of toertel@gmail.com designates 2a00:1450:4864:20::341 as permitted sender) smtp.mailfrom=toertel@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:mime-version:from:to:cc:subject:date:message-id :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=ZiY0/WDQhmakJpF2XsHS2yweTw8j6H+kGSbgybjprHs=; b=MY7LOjSXKQ3IBlj8PjPU73tGP8wMqndP0z6YQK5Sd/JBpcr8fckvhBH3bGWWFl14Uc ldZL0r5CK3zF/AVVx9ke7teutg8hmI+cAXOYYuKwdEQulwvCv6gP8kQuf3uZlEW0KAmr Hj9KtDz8152GziQrM0EvflAYZ4p1kq8tbEe7RruXEpCW6ZRfVPJIYJCyKtlYskoJTMF8 xo9T/eVsSWYrITldsGyyfcPzwRQgyE7LN03JlTnQUhDzUW19zmyqfEvtOCBQv1rriTc4 yecElaakZRlxZ9uGVnWWEKQiJo8Z6IKd3GI7bjJPiPhbwDibePsWmpnbFjfy/P7jAwyL 7y/w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:to:cc:subject:date:message-id:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-subscribe:list-unsubscribe; bh=ZiY0/WDQhmakJpF2XsHS2yweTw8j6H+kGSbgybjprHs=; b=SpQ4jSm3HEaUwtMiw0GVTCkRiLS2q26augha3nIZPaKLp60wgfenC4cM86h7l5Zj3r 3tMP11bQGh10YqXidxcPrywVE3LZcVQYrqV/GhcZixBU171av/RGRYFS/g2yCzcz1B01 pZt8pq1zEe/v2t1/rxvAmMDp3yWSpZBS/flrdBXv0PGGx+PNIe0ZdEln2TYTOeqz242l lrjEiCuMdty+bko7t5sXlONqjvCAJY+N9i4gpeR8KiFcZUdtO5kRObrLuh7jftyrqzX/ tZ/68nOr4xaAaggl+0amg5wnheYiPyV5qpIiIzFVGwJlzPP9A0IkOiROp6DyWwAhOqdW lMpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:mime-version:from:to:cc:subject:date :message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=ZiY0/WDQhmakJpF2XsHS2yweTw8j6H+kGSbgybjprHs=; b=U5XwRB91YicDRWLS/nLazewxC7amIm+CzFoyBR5z93ZUM/nd6fIsp+DlCp52txRCQb rMJZMssupF+QD/wCESNEERveL3tPeJqD/XDJAE9S/a/HFT3ltK8I8pOgksVVbd6qKVZl bkpgAuY4IDLDhOWX6c6L2GpINp23klMJmoWiuC3oWJPEbhw9gBg88Sst+ScFEY/uEG18 WjBzjjmPuJXUxYq8zQhDq/0ZghVssAADEN7/z+1jle14nN/ElxGYK7Rn/snFkzM/GuID NyhpQ6/A8Iixw7tZzg3YPjbJR7sBtMTdeacZBMAuKrmCq3QekQDZBv4DkiJxRRnRZ6Zr tR5g== Sender: swupdate@googlegroups.com X-Gm-Message-State: AGi0PuZeA3gZ7U1VmxqrxAMLOt2Cyrm4x4QS0g7fGL8dcv7apwN8Xout j0ulaO1ccce1LTZpC76m9sE= X-Google-Smtp-Source: APiQypJd0GrH0YBO3IPHtlgLDpFpzNydx7Bmec8knK7nF9G+TmUMaW+2GeDe8Mlq1czsuG1WmjdZrw== X-Received: by 2002:a1c:96d1:: with SMTP id y200mr10412121wmd.114.1586434385889; Thu, 09 Apr 2020 05:13:05 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: swupdate@googlegroups.com Received: by 2002:adf:f6d2:: with SMTP id y18ls7780971wrp.0.gmail; Thu, 09 Apr 2020 05:13:05 -0700 (PDT) X-Received: by 2002:a05:6000:12c5:: with SMTP id l5mr2311080wrx.185.1586434385230; Thu, 09 Apr 2020 05:13:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586434385; cv=none; d=google.com; s=arc-20160816; b=mGanYwQl7UydDSBwg7uQif/WwA2zbOghLFeVW38VSvdoMHM2jELQwiajltuXauniFz AY8x+Va0sjOFwnpMnumVa7Roqbf8suW6jdqPzXSi2Ow5vVzh2dWDv3IrBv3Eytn5hp0q cO/pk6VgD0fdzZABjdXYF8hBI4FN9CrB68bPnjaAaO+9jIpskdgjuBcGMKSS1km5jjV9 bH9pkszIBz4NacmIcTRWgZVXiNOsSyRwcBCMRNwKTJUO+MvY6gtC4HwCXpCUu5Zg4KCd 6V1oLgtDczxI9MyJ7+9L5wJCTGewiUr+LTKS6y7eOWmHNcRUuRIo+Guc5OpTSWWOpaYR z8Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature; bh=efc9dcfSAJxhByTjfNudLPNXeqb2jLzJ724ZZuxuFB4=; b=Yn/L3UVdWA6aeN1ZwqRNdTL+MmObDaIWZ6WLUuc6hChKw7p+fXMw4vBMiWdHAGNGu1 bC938lWEUxfNoXOzWGBXFROyGtktwc4vtlqjEN6yg7rf62zVWoukfbUhl0Xi113cPX+6 HkRKLzv42Zba0Hb/ABCcEdw80ijgM4DEWRWsDL8WJtazHLdTxfmsUL6L2+TYrXXGo4QH juoYr68nTH231Wiobd2DzXG+QESqIQFQLi5h7mV8helcFbhg0MAF1DycU9T7cffmEWnN hOByij3Wv+HNAcCJ4Sd6Q+a7hDjzA/P2yVLyJogweBTnCpVAe5yR9uWSURzA+QyRT+k1 hpFQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Cezk3RLz; spf=pass (google.com: domain of toertel@gmail.com designates 2a00:1450:4864:20::341 as permitted sender) smtp.mailfrom=toertel@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com. [2a00:1450:4864:20::341]) by gmr-mx.google.com with ESMTPS id f129si48173wmf.2.2020.04.09.05.13.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2020 05:13:05 -0700 (PDT) Received-SPF: pass (google.com: domain of toertel@gmail.com designates 2a00:1450:4864:20::341 as permitted sender) client-ip=2a00:1450:4864:20::341; Received: by mail-wm1-x341.google.com with SMTP id y24so3954566wma.4 for ; Thu, 09 Apr 2020 05:13:05 -0700 (PDT) X-Received: by 2002:a1c:98c2:: with SMTP id a185mr10077942wme.85.1586434384548; Thu, 09 Apr 2020 05:13:04 -0700 (PDT) Received: from gigabyte.fritz.box (p200300CFAF40240080F700F195DF4713.dip0.t-ipconnect.de. [2003:cf:af40:2400:80f7:f1:95df:4713]) by smtp.gmail.com with ESMTPSA id k84sm3606117wmk.2.2020.04.09.05.13.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2020 05:13:03 -0700 (PDT) From: Mark Jonas To: swupdate@googlegroups.com Cc: Mark Jonas Subject: [swupdate] [PATCH 1/2] core: Fix CID 292193 argument cannot be negative Date: Thu, 9 Apr 2020 14:12:54 +0200 Message-Id: <20200409121255.24428-1-toertel@gmail.com> X-Mailer: git-send-email 2.17.1 X-Original-Sender: toertel@gmail.com X-Original-Authentication-Results: gmr-mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Cezk3RLz; spf=pass (google.com: domain of toertel@gmail.com designates 2a00:1450:4864:20::341 as permitted sender) smtp.mailfrom=toertel@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Calling socket() can fail. In this case socket() returns -1. In this case it does not make sense to continue and use a broken listenfd when calling bind(). Signed-off-by: Mark Jonas --- core/network_thread.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/network_thread.c b/core/network_thread.c index 677ec3d..19d54b3 100644 --- a/core/network_thread.c +++ b/core/network_thread.c @@ -123,6 +123,9 @@ int listener_create(const char *path, int type) if (listenfd == -1) { TRACE("creating socket at %s", path); listenfd = socket(AF_LOCAL, type, 0); + if (listenfd < 0) { + return -1; + } unlink(path); bzero(&servaddr, sizeof(servaddr)); servaddr.sun_family = AF_LOCAL; @@ -142,7 +145,6 @@ int listener_create(const char *path, int type) return -1; } return listenfd; - } static void cleanum_msg_list(void)