From patchwork Mon May 7 12:12:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raphael Freudiger X-Patchwork-Id: 909717 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:400c:c09::23d; helo=mail-wm0-x23d.google.com; envelope-from=swupdate+bncbaabbxefyhlqkgqec2klk5i@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=siemens.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.b="PUOAmq8e"; dkim-atps=neutral Received: from mail-wm0-x23d.google.com (mail-wm0-x23d.google.com [IPv6:2a00:1450:400c:c09::23d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 40fhNH3QYbz9s37 for ; Mon, 7 May 2018 22:13:19 +1000 (AEST) Received: by mail-wm0-x23d.google.com with SMTP id 70sf2227027wmb.2 for ; Mon, 07 May 2018 05:13:19 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1525695196; cv=pass; d=google.com; s=arc-20160816; b=cYvPnS/LCXeDzoS/t70K662fOSLC0/TFyIv69X4NcCcKx+NfJuBwoaGkAl2dfKLQR/ vxHsHgoZLEFtzZOFFVAT+HLUwzH+Rms0tbdQlyHpjZ8pStYNpTV1VAgRew48ukgj7XlG oodrdDZuZ2shMLkgG0Sg9l5pZxAGPXkhaxY5SEQSqv+3N3rwhapapc7IlUsJWloSeDE8 SsD4ngNqycDd9Ai/A2u8ZwwbgZLLB7D2EEmTTDT5JBEac+WVrHI2Ar6oQa7r5zAQyIda ADvcEghYtBQ85O4/GvoIQ+GEOPFRF4xswITRvNZtPladC30AhLm5sCxEz8O1PeE5NcZ6 MGNw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:arc-authentication-results :arc-message-signature:mime-version:sender:dkim-signature :arc-authentication-results; bh=Ub4Kj9SJs0CrKsHpUMQvR+cAo6sZ+SkXyo9p6cTeNac=; b=SpcDvr1K5PO8WhTHL1Gf9gxHJD6B8OHibiawip9xcctbd7AorOOk3qbR7DSzN+3De3 zzg72W6M+81ueVvpDqcCvURYUMPdMs7iSC10a+uawr5H0DynW8GTCprRthQcMWKLHSoE lU/v8LbzbGP8jDClxMNFsmkolqDFToXhYXEtpXnOLX4EWJ4V5ZNG58f+NrtKZIZQL1V8 tp8yJWOfn+dtoisSXYZAumNoYCyr6AASGG9flPtXxU7d/AKQayGlQmNyS3ShAyB5qnWT V2Fj0/OlkCxMdoHHW/kO+Puqq4vn6PtpJr5tdnQCYPLdL/I1ZeLOQ9JUJ0roXSsAUAw5 Q4JA== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=pass (google.com: domain of raphael.freudiger@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=raphael.freudiger@siemens.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:mime-version:from:to:cc:subject:date:message-id:in-reply-to :references:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=Ub4Kj9SJs0CrKsHpUMQvR+cAo6sZ+SkXyo9p6cTeNac=; b=PUOAmq8eirIgN7y/O2HubmEpx0rFYzbAsyXpvJMfQ0iaZf/i0x86Y96i2v7w7o9fPJ jNECBf2nFzdi6z/tWxFG8J9GgjAoRcPeJiorLBWMnTKMWy7e2U7Nn+xZuAkZABwShHpr VUS8z3lz4ox+r19IDQB5T6RWzEfs3QNk3GJ1U2dXLJjg+oFTR9W6G/1jJksPvYqXx7EI bpyl5QbHjzpLIxKRtKwXYyI+hkg/e8AYfCA9Ur+WYsAh5XHY1y5lRiXAf8jJcMURE10E 923itoiLUJ8SKJzz4or6PR/AyjzIoAe5uZbAo56HKMTSIKst0XdnuzUGxgIKnP9csJAd IpbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:mime-version:from:to:cc:subject:date :message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=Ub4Kj9SJs0CrKsHpUMQvR+cAo6sZ+SkXyo9p6cTeNac=; b=kHpKTG+gXxY6C3e2eyiQng4wk+ZgEfBJwGnTwrpSAW95m2agNPNlJNdRzz0YNSN6rB A/l9Os2Qsd+bxE5AB53rkDlAM82yDLX6WizWCJkVIW+C7psX3DT4nsdc5R1xDUBTLgfJ KNJDE4kRGwKX8VhJaeZL5eKaArS1fu3jv0U5zvT0UIi7uGK57Z/mzvXznsP+TXPGJC+9 /22Xt2+4IRJnCe7u1er0nM2MNabAOBffKE+F3f19+N/RTiv3St4XqxYsXtEFFs4kIm/c ZTR23CTaqS9uv5Mmg+Ozjl5/2DePz3ZrCZ9AAN5nmmWPfnPMM1BTfOb35HyTQfPEKHT8 2D+Q== Sender: swupdate@googlegroups.com X-Gm-Message-State: ALKqPwdYpNnJcvBo8mezxnCp/2h0ZJImcIn5saTbzszBVsQtafZBbXdZ CQ4+QCQOskBsuhLKu2HIZoo= X-Google-Smtp-Source: AB8JxZo7LBuvf+ATgMLqOq1jjd9ub3ROebqzQYxOGub4cZH23hqPzoqm8FX3nob/l880npOsC/9Hyw== X-Received: by 2002:a1c:9e15:: with SMTP id h21-v6mr8136wme.5.1525695196708; Mon, 07 May 2018 05:13:16 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: swupdate@googlegroups.com Received: by 2002:adf:9a4f:: with SMTP id z73-v6ls6943377wrb.12.gmail; Mon, 07 May 2018 05:13:16 -0700 (PDT) X-Received: by 2002:adf:e544:: with SMTP id z4-v6mr3159001wrm.6.1525695196248; Mon, 07 May 2018 05:13:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1525695196; cv=none; d=google.com; s=arc-20160816; b=WwZbV5JLqfVefD1PnEM3Y/nXDS9zrc8TPc+J+iyTbib4PGY78tjRr8kZnLBgiddQYZ iDW0Ri957H1q96hQ5rUJs057pF6lSsjCC7CGp99ucn2TooI1gJiW0tZ9t5cDfxIYoAon LRsMYdR0p14s6PebBIeCE/fha+IdUNHy636UdpughYuD3rEejsOFqtDZh7uOXKUfXohG uroFqC82T7NkZIw90CmM+s+e+VVkl/xdR9AXT/S0IdfCQVs3T/wr5520xco/e/BCmQU/ S+I0q6s5nkpmliWFEeXlFhfdTojW8ZzKnvYdYMFoEGK/rgzFry37o3WCs4hifgGXw06H Ujgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=SO9Th3njw6ZOIQeEVaTXaVAOHThNC/uqyQ0ubS7eqzk=; b=CE/etvdQahTlKwyNcG7DjwwFlMYtUjU5BE74RNG9LXygL+GohzgY2DkkVWLn0KJlO+ 1cwdNj12y8yzNytWhwgz/BPZOKEML1QDogVK5LqL+u1YyQ+py8ayZ3w67vZ6cKdqhiSF P7bb+vba+RM2vineRsMLS7cOFxSS5Kn3DOC34TqLH/g0KimjXdCRM16YROANRp8Ip46j U63c6TxNBvV9NceDveU7txsAXbWaA3XADYrR6LkxymkwEN0KXQuI4b79q0K9GtX7T5wQ Z5B8dWvIx+0OR8m31PP0DgsrfM0B17pI449rUcUVeJ6JkB7u/1MH/lSNlLw7v/EiW60v NkXw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of raphael.freudiger@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=raphael.freudiger@siemens.com Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id y144-v6si380369wmd.3.2018.05.07.05.13.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 May 2018 05:13:16 -0700 (PDT) Received-SPF: pass (google.com: domain of raphael.freudiger@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Received: from mail3.siemens.de (mail3.siemens.de [139.25.208.14]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id w47CDFBa019547 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 7 May 2018 14:13:15 +0200 Received: from dev.vm6.ccp.siemens.com (MD1AT2FC.ad001.siemens.net [139.16.79.173]) by mail3.siemens.de (8.15.2/8.15.2) with ESMTP id w47CDFNn019075; Mon, 7 May 2018 14:13:15 +0200 Received: from dev.vm6.ccp.siemens.com (localhost [127.0.0.1]) by dev.vm6.ccp.siemens.com (Postfix) with ESMTP id 9DCDE343AEE3; Mon, 7 May 2018 14:13:15 +0200 (CEST) From: Raphael Freudiger To: swupdate@googlegroups.com Cc: Raphael Freudiger Subject: [swupdate] [meta-swupdate][PATCH 3/3] swupdate_class: use shell function to create swupdate file Date: Mon, 7 May 2018 14:12:51 +0200 Message-Id: <20180507121251.13088-3-raphael.freudiger@siemens.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180507121251.13088-1-raphael.freudiger@siemens.com> References: <20180507121251.13088-1-raphael.freudiger@siemens.com> X-Original-Sender: raphael.freudiger@siemens.com X-Original-Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of raphael.freudiger@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=raphael.freudiger@siemens.com Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Having a separate shell function is better readable and maintainable than the string passed to os.system. Signed-off-by: Raphael Freudiger --- classes/swupdate-base.bbclass | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/classes/swupdate-base.bbclass b/classes/swupdate-base.bbclass index 29cfe5f..46e87a4 100644 --- a/classes/swupdate-base.bbclass +++ b/classes/swupdate-base.bbclass @@ -164,9 +164,16 @@ python do_swuimage () { else: bb.fatal("Unrecognized SWUPDATE_SIGNING mechanism."); - line = 'for i in ' + ' '.join(list_for_cpio) + '; do echo $i;done | cpio -ov -H crc >' + os.path.join(swupdate_dir,d.getVar('IMAGE_NAME', True) + '.swu') - os.system("cd " + s + ";" + line) + d.setVar("LIST_FOR_CPIO", ' '.join(list_for_cpio)) + bb.build.exec_func("create_swu", d) +} + +create_swu() { + cd ${S} + for i in ${LIST_FOR_CPIO} + do + echo $i + done | cpio -ov -H crc > ${SWUPDATE_DIR}/${IMAGE_NAME}.swu - line = 'ln -sf ' + d.getVar('IMAGE_NAME', True) + '.swu ' + d.getVar('IMAGE_LINK_NAME', True) + '.swu' - os.system("cd " + swupdate_dir + "; " + line) + ln -sf ${IMAGE_NAME}.swu ${SWUPDATE_DIR}/${IMAGE_LINK_NAME}.swu }