| Message ID | 20180423123109.18590-2-christian.storm@siemens.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/8] core: warn about non-Linux parent SIGTERM tracking | expand |
On 23/04/2018 14:31, Christian Storm wrote: > Do not hard-code "gcc" usage but instead rely > on "cc" for portability. > > Signed-off-by: Thomas Zander <thomas.zander@siemens.com> > Signed-off-by: Christian Storm <christian.storm@siemens.com> > --- > Makefile | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Makefile b/Makefile > index a1ff4b1..54af2a8 100644 > --- a/Makefile > +++ b/Makefile > @@ -114,8 +114,8 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \ > else if [ -x /bin/bash ]; then echo /bin/bash; \ > else echo sh; fi ; fi) > > -HOSTCC = gcc > -HOSTCXX = g++ > +HOSTCC = cc > +HOSTCXX = c++ > HOSTCFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer > HOSTCXXFLAGS = -O2 > > @@ -172,8 +172,8 @@ include $(srctree)/scripts/Kbuild.include > # this looks a bit horrible, but 'VAR ?= VALUE' preserves builtin values > # rather than only user-supplied values from env or command-line > $(call set_if_default_or_unset,AS,$$(CROSS_COMPILE)as) > -$(call set_if_default_or_unset,LD,$$(CROSS_COMPILE)gcc) > -$(call set_if_default_or_unset,CC,$$(CROSS_COMPILE)gcc) > +$(call set_if_default_or_unset,LD,$$(CROSS_COMPILE)cc) > +$(call set_if_default_or_unset,CC,$$(CROSS_COMPILE)cc) > $(call set_if_default_or_unset,CPP,$$(CC) -E) > $(call set_if_default_or_unset,AR,$$(CROSS_COMPILE)ar) > $(call set_if_default_or_unset,NM,$$(CROSS_COMPILE)nm) > Reviewed-by: Stefano Babic <sbabic@denx.de> Best regards, Stefano Babic
Could it be this breaks the yocto build of swupdate? ERROR: swupdate-git-r0 do_configure: oe_runmake failed ERROR: swupdate-git-r0 do_configure: Function failed: do_configure (log file is located at /.../build/tmp/work/cortexa9hf-neon-puppy-linux-gnueabi/swupdate/git-r0/temp/log.do_configure.165763) ERROR: Logfile of failure stored in: /.../tmp/work/cortexa9hf-neon-puppy-linux-gnueabi/swupdate/git-r0/temp/log.do_configure.165763 Log data follows: | DEBUG: Executing shell function do_configure | Using .config as base | Merging .../sources/poky/../meta-sta/recipes-support/swupdate/swupdate/swupdate.cfg | # | # merged configuration written to .config (needs make) | # | NOTE: make V=1 ARCH=arm CROSS_COMPILE=arm-puppy-linux-gnueabi- SKIP_STRIP=y oldconfig | make -f scripts/Makefile.build obj=scripts/basic | cc -Wp,-MD,scripts/basic/.fixdep.d -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer -o scripts/basic/fixdep scripts/basic/fixdep.c | /bin/sh: cc: command not found | scripts/Makefile.host:91: recipe for target 'scripts/basic/fixdep' failed | make[1]: *** [scripts/basic/fixdep] Error 127 | Makefile:245: recipe for target 'scripts_basic' failed | make: *** [scripts_basic] Error 2 | ERROR: oe_runmake failed On Monday, April 23, 2018 at 7:54:50 PM UTC+2, Stefano Babic wrote: > On 23/04/2018 14:31, Christian Storm wrote: > > Do not hard-code "gcc" usage but instead rely > > on "cc" for portability. > > > > Signed-off-by: Thomas Zander <thomas...@siemens.com <javascript:>> > > Signed-off-by: Christian Storm <christi...@siemens.com <javascript:>> > > --- > > Makefile | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index a1ff4b1..54af2a8 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -114,8 +114,8 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then > echo $$BASH; \ > > else if [ -x /bin/bash ]; then echo /bin/bash; \ > > else echo sh; fi ; fi) > > > > -HOSTCC = gcc > > -HOSTCXX = g++ > > +HOSTCC = cc > > +HOSTCXX = c++ > > HOSTCFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 > -fomit-frame-pointer > > HOSTCXXFLAGS = -O2 > > > > @@ -172,8 +172,8 @@ include $(srctree)/scripts/Kbuild.include > > # this looks a bit horrible, but 'VAR ?= VALUE' preserves builtin > values > > # rather than only user-supplied values from env or command-line > > $(call set_if_default_or_unset,AS,$$(CROSS_COMPILE)as) > > -$(call set_if_default_or_unset,LD,$$(CROSS_COMPILE)gcc) > > -$(call set_if_default_or_unset,CC,$$(CROSS_COMPILE)gcc) > > +$(call set_if_default_or_unset,LD,$$(CROSS_COMPILE)cc) > > +$(call set_if_default_or_unset,CC,$$(CROSS_COMPILE)cc) > > $(call set_if_default_or_unset,CPP,$$(CC) -E) > > $(call set_if_default_or_unset,AR,$$(CROSS_COMPILE)ar) > > $(call set_if_default_or_unset,NM,$$(CROSS_COMPILE)nm) > > > > Reviewed-by: Stefano Babic <sba...@denx.de <javascript:>> > > Best regards, > Stefano Babic > > > -- > ===================================================================== > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de > <javascript:> > ===================================================================== >
Hi Jan, On 03/05/2018 11:57, jan wrote: > Could it be this breaks the yocto build of swupdate? > You're right - it breaks. It does not break outside Yocto (no errors reported by Travis) just because the distro install via alternatives a "cc" package. But in Yocto sysroot, this is not present. Let's wait for an answer from Tom and Christian. Regards, Stefano > ERROR: swupdate-git-r0 do_configure: oe_runmake failed > ERROR: swupdate-git-r0 do_configure: Function failed: do_configure (log > file is located at > /.../build/tmp/work/cortexa9hf-neon-puppy-linux-gnueabi/swupdate/git-r0/temp/log.do_configure.165763) > ERROR: Logfile of failure stored in: > /.../tmp/work/cortexa9hf-neon-puppy-linux-gnueabi/swupdate/git-r0/temp/log.do_configure.165763 > Log data follows: > | DEBUG: Executing shell function do_configure > | Using .config as base > | Merging > .../sources/poky/../meta-sta/recipes-support/swupdate/swupdate/swupdate.cfg > | # > | # merged configuration written to .config (needs make) > | # > | NOTE: make V=1 ARCH=arm CROSS_COMPILE=arm-puppy-linux-gnueabi- > SKIP_STRIP=y oldconfig > | make -f scripts/Makefile.build obj=scripts/basic > | cc -Wp,-MD,scripts/basic/.fixdep.d -Wall -Wmissing-prototypes > -Wstrict-prototypes -O2 -fomit-frame-pointer -o scripts/basic/fixdep > scripts/basic/fixdep.c > | /bin/sh: cc: command not found > | scripts/Makefile.host:91: recipe for target 'scripts/basic/fixdep' failed > | make[1]: *** [scripts/basic/fixdep] Error 127 > | Makefile:245: recipe for target 'scripts_basic' failed > | make: *** [scripts_basic] Error 2 > | ERROR: oe_runmake failed > > > > On Monday, April 23, 2018 at 7:54:50 PM UTC+2, Stefano Babic wrote: > > On 23/04/2018 14:31, Christian Storm wrote: > > Do not hard-code "gcc" usage but instead rely > > on "cc" for portability. > > > > Signed-off-by: Thomas Zander <thomas...@siemens.com <javascript:>> > > Signed-off-by: Christian Storm <christi...@siemens.com <javascript:>> > > --- > > Makefile | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/Makefile b/Makefile > > index a1ff4b1..54af2a8 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -114,8 +114,8 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; > then echo $$BASH; \ > > else if [ -x /bin/bash ]; then echo /bin/bash; \ > > else echo sh; fi ; fi) > > > > -HOSTCC = gcc > > -HOSTCXX = g++ > > +HOSTCC = cc > > +HOSTCXX = c++ > > HOSTCFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 > -fomit-frame-pointer > > HOSTCXXFLAGS = -O2 > > > > @@ -172,8 +172,8 @@ include $(srctree)/scripts/Kbuild.include > > # this looks a bit horrible, but 'VAR ?= VALUE' preserves builtin > values > > # rather than only user-supplied values from env or command-line > > $(call set_if_default_or_unset,AS,$$(CROSS_COMPILE)as) > > -$(call set_if_default_or_unset,LD,$$(CROSS_COMPILE)gcc) > > -$(call set_if_default_or_unset,CC,$$(CROSS_COMPILE)gcc) > > +$(call set_if_default_or_unset,LD,$$(CROSS_COMPILE)cc) > > +$(call set_if_default_or_unset,CC,$$(CROSS_COMPILE)cc) > > $(call set_if_default_or_unset,CPP,$$(CC) -E) > > $(call set_if_default_or_unset,AR,$$(CROSS_COMPILE)ar) > > $(call set_if_default_or_unset,NM,$$(CROSS_COMPILE)nm) > > > > Reviewed-by: Stefano Babic <sba...@denx.de <javascript:>> > > Best regards, > Stefano Babic > > > -- > ===================================================================== > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: > sba...@denx.de <javascript:> > ===================================================================== > > -- > You received this message because you are subscribed to the Google > Groups "swupdate" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to swupdate+unsubscribe@googlegroups.com > <mailto:swupdate+unsubscribe@googlegroups.com>. > To post to this group, send email to swupdate@googlegroups.com > <mailto:swupdate@googlegroups.com>. > For more options, visit https://groups.google.com/d/optout.
Hi, Please find attached a patch that solved the issue. If found the inspiration in poky/meta/recipes-kernel/make-mod-scripts/make-mod-scripts_1.0.bb On Thu, May 3, 2018 at 11:08 PM, Stefano Babic <sbabic@denx.de> wrote: > Hi Jan, > > On 03/05/2018 11:57, jan wrote: >> Could it be this breaks the yocto build of swupdate? >> > > You're right - it breaks. > > It does not break outside Yocto (no errors reported by Travis) just > because the distro install via alternatives a "cc" package. But in Yocto > sysroot, this is not present. > > Let's wait for an answer from Tom and Christian. > > Regards, > Stefano > >> ERROR: swupdate-git-r0 do_configure: oe_runmake failed >> ERROR: swupdate-git-r0 do_configure: Function failed: do_configure (log >> file is located at >> /.../build/tmp/work/cortexa9hf-neon-puppy-linux-gnueabi/swupdate/git-r0/temp/log.do_configure.165763) >> ERROR: Logfile of failure stored in: >> /.../tmp/work/cortexa9hf-neon-puppy-linux-gnueabi/swupdate/git-r0/temp/log.do_configure.165763 >> Log data follows: >> | DEBUG: Executing shell function do_configure >> | Using .config as base >> | Merging >> .../sources/poky/../meta-sta/recipes-support/swupdate/swupdate/swupdate.cfg >> | # >> | # merged configuration written to .config (needs make) >> | # >> | NOTE: make V=1 ARCH=arm CROSS_COMPILE=arm-puppy-linux-gnueabi- >> SKIP_STRIP=y oldconfig >> | make -f scripts/Makefile.build obj=scripts/basic >> | cc -Wp,-MD,scripts/basic/.fixdep.d -Wall -Wmissing-prototypes >> -Wstrict-prototypes -O2 -fomit-frame-pointer -o scripts/basic/fixdep >> scripts/basic/fixdep.c >> | /bin/sh: cc: command not found >> | scripts/Makefile.host:91: recipe for target 'scripts/basic/fixdep' failed >> | make[1]: *** [scripts/basic/fixdep] Error 127 >> | Makefile:245: recipe for target 'scripts_basic' failed >> | make: *** [scripts_basic] Error 2 >> | ERROR: oe_runmake failed >> >> >> >> On Monday, April 23, 2018 at 7:54:50 PM UTC+2, Stefano Babic wrote: >> >> On 23/04/2018 14:31, Christian Storm wrote: >> > Do not hard-code "gcc" usage but instead rely >> > on "cc" for portability. >> > >> > Signed-off-by: Thomas Zander <thomas...@siemens.com <javascript:>> >> > Signed-off-by: Christian Storm <christi...@siemens.com <javascript:>> >> > --- >> > Makefile | 8 ++++---- >> > 1 file changed, 4 insertions(+), 4 deletions(-) >> > >> > diff --git a/Makefile b/Makefile >> > index a1ff4b1..54af2a8 100644 >> > --- a/Makefile >> > +++ b/Makefile >> > @@ -114,8 +114,8 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; >> then echo $$BASH; \ >> > else if [ -x /bin/bash ]; then echo /bin/bash; \ >> > else echo sh; fi ; fi) >> > >> > -HOSTCC = gcc >> > -HOSTCXX = g++ >> > +HOSTCC = cc >> > +HOSTCXX = c++ >> > HOSTCFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 >> -fomit-frame-pointer >> > HOSTCXXFLAGS = -O2 >> > >> > @@ -172,8 +172,8 @@ include $(srctree)/scripts/Kbuild.include >> > # this looks a bit horrible, but 'VAR ?= VALUE' preserves builtin >> values >> > # rather than only user-supplied values from env or command-line >> > $(call set_if_default_or_unset,AS,$$(CROSS_COMPILE)as) >> > -$(call set_if_default_or_unset,LD,$$(CROSS_COMPILE)gcc) >> > -$(call set_if_default_or_unset,CC,$$(CROSS_COMPILE)gcc) >> > +$(call set_if_default_or_unset,LD,$$(CROSS_COMPILE)cc) >> > +$(call set_if_default_or_unset,CC,$$(CROSS_COMPILE)cc) >> > $(call set_if_default_or_unset,CPP,$$(CC) -E) >> > $(call set_if_default_or_unset,AR,$$(CROSS_COMPILE)ar) >> > $(call set_if_default_or_unset,NM,$$(CROSS_COMPILE)nm) >> > >> >> Reviewed-by: Stefano Babic <sba...@denx.de <javascript:>> >> >> Best regards, >> Stefano Babic >> >> >> -- >> ===================================================================== >> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk >> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany >> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: >> sba...@denx.de <javascript:> >> ===================================================================== >> >> -- >> You received this message because you are subscribed to the Google >> Groups "swupdate" group. >> To unsubscribe from this group and stop receiving emails from it, send >> an email to swupdate+unsubscribe@googlegroups.com >> <mailto:swupdate+unsubscribe@googlegroups.com>. >> To post to this group, send email to swupdate@googlegroups.com >> <mailto:swupdate@googlegroups.com>. >> For more options, visit https://groups.google.com/d/optout. > > -- > ===================================================================== > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de > =====================================================================
Hi Jan, On 04/05/2018 08:59, jan vermaete wrote: > Hi, > > Please find attached a patch that solved the issue. Fine - for the future, can you use git send-email to have inline patches ? Attached patches are not detected by patchworks and they are not tracked - thanks ! Best regards, Stefano Babic > If found the inspiration in > poky/meta/recipes-kernel/make-mod-scripts/make-mod-scripts_1.0.bb > > On Thu, May 3, 2018 at 11:08 PM, Stefano Babic <sbabic@denx.de> wrote: >> Hi Jan, >> >> On 03/05/2018 11:57, jan wrote: >>> Could it be this breaks the yocto build of swupdate? >>> >> >> You're right - it breaks. >> >> It does not break outside Yocto (no errors reported by Travis) just >> because the distro install via alternatives a "cc" package. But in Yocto >> sysroot, this is not present. >> >> Let's wait for an answer from Tom and Christian. >> >> Regards, >> Stefano >> >>> ERROR: swupdate-git-r0 do_configure: oe_runmake failed >>> ERROR: swupdate-git-r0 do_configure: Function failed: do_configure (log >>> file is located at >>> /.../build/tmp/work/cortexa9hf-neon-puppy-linux-gnueabi/swupdate/git-r0/temp/log.do_configure.165763) >>> ERROR: Logfile of failure stored in: >>> /.../tmp/work/cortexa9hf-neon-puppy-linux-gnueabi/swupdate/git-r0/temp/log.do_configure.165763 >>> Log data follows: >>> | DEBUG: Executing shell function do_configure >>> | Using .config as base >>> | Merging >>> .../sources/poky/../meta-sta/recipes-support/swupdate/swupdate/swupdate.cfg >>> | # >>> | # merged configuration written to .config (needs make) >>> | # >>> | NOTE: make V=1 ARCH=arm CROSS_COMPILE=arm-puppy-linux-gnueabi- >>> SKIP_STRIP=y oldconfig >>> | make -f scripts/Makefile.build obj=scripts/basic >>> | cc -Wp,-MD,scripts/basic/.fixdep.d -Wall -Wmissing-prototypes >>> -Wstrict-prototypes -O2 -fomit-frame-pointer -o scripts/basic/fixdep >>> scripts/basic/fixdep.c >>> | /bin/sh: cc: command not found >>> | scripts/Makefile.host:91: recipe for target 'scripts/basic/fixdep' failed >>> | make[1]: *** [scripts/basic/fixdep] Error 127 >>> | Makefile:245: recipe for target 'scripts_basic' failed >>> | make: *** [scripts_basic] Error 2 >>> | ERROR: oe_runmake failed >>> >>> >>> >>> On Monday, April 23, 2018 at 7:54:50 PM UTC+2, Stefano Babic wrote: >>> >>> On 23/04/2018 14:31, Christian Storm wrote: >>> > Do not hard-code "gcc" usage but instead rely >>> > on "cc" for portability. >>> > >>> > Signed-off-by: Thomas Zander <thomas...@siemens.com <javascript:>> >>> > Signed-off-by: Christian Storm <christi...@siemens.com <javascript:>> >>> > --- >>> > Makefile | 8 ++++---- >>> > 1 file changed, 4 insertions(+), 4 deletions(-) >>> > >>> > diff --git a/Makefile b/Makefile >>> > index a1ff4b1..54af2a8 100644 >>> > --- a/Makefile >>> > +++ b/Makefile >>> > @@ -114,8 +114,8 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; >>> then echo $$BASH; \ >>> > else if [ -x /bin/bash ]; then echo /bin/bash; \ >>> > else echo sh; fi ; fi) >>> > >>> > -HOSTCC = gcc >>> > -HOSTCXX = g++ >>> > +HOSTCC = cc >>> > +HOSTCXX = c++ >>> > HOSTCFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 >>> -fomit-frame-pointer >>> > HOSTCXXFLAGS = -O2 >>> > >>> > @@ -172,8 +172,8 @@ include $(srctree)/scripts/Kbuild.include >>> > # this looks a bit horrible, but 'VAR ?= VALUE' preserves builtin >>> values >>> > # rather than only user-supplied values from env or command-line >>> > $(call set_if_default_or_unset,AS,$$(CROSS_COMPILE)as) >>> > -$(call set_if_default_or_unset,LD,$$(CROSS_COMPILE)gcc) >>> > -$(call set_if_default_or_unset,CC,$$(CROSS_COMPILE)gcc) >>> > +$(call set_if_default_or_unset,LD,$$(CROSS_COMPILE)cc) >>> > +$(call set_if_default_or_unset,CC,$$(CROSS_COMPILE)cc) >>> > $(call set_if_default_or_unset,CPP,$$(CC) -E) >>> > $(call set_if_default_or_unset,AR,$$(CROSS_COMPILE)ar) >>> > $(call set_if_default_or_unset,NM,$$(CROSS_COMPILE)nm) >>> > >>> >>> Reviewed-by: Stefano Babic <sba...@denx.de <javascript:>> >>> >>> Best regards, >>> Stefano Babic >>> >>> >>> -- >>> ===================================================================== >>> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk >>> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany >>> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: >>> sba...@denx.de <javascript:> >>> ===================================================================== >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "swupdate" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to swupdate+unsubscribe@googlegroups.com >>> <mailto:swupdate+unsubscribe@googlegroups.com>. >>> To post to this group, send email to swupdate@googlegroups.com >>> <mailto:swupdate@googlegroups.com>. >>> For more options, visit https://groups.google.com/d/optout. >> >> -- >> ===================================================================== >> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk >> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany >> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de >> ===================================================================== > > >
diff --git a/Makefile b/Makefile index a1ff4b1..54af2a8 100644 --- a/Makefile +++ b/Makefile @@ -114,8 +114,8 @@ CONFIG_SHELL := $(shell if [ -x "$$BASH" ]; then echo $$BASH; \ else if [ -x /bin/bash ]; then echo /bin/bash; \ else echo sh; fi ; fi) -HOSTCC = gcc -HOSTCXX = g++ +HOSTCC = cc +HOSTCXX = c++ HOSTCFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer HOSTCXXFLAGS = -O2 @@ -172,8 +172,8 @@ include $(srctree)/scripts/Kbuild.include # this looks a bit horrible, but 'VAR ?= VALUE' preserves builtin values # rather than only user-supplied values from env or command-line $(call set_if_default_or_unset,AS,$$(CROSS_COMPILE)as) -$(call set_if_default_or_unset,LD,$$(CROSS_COMPILE)gcc) -$(call set_if_default_or_unset,CC,$$(CROSS_COMPILE)gcc) +$(call set_if_default_or_unset,LD,$$(CROSS_COMPILE)cc) +$(call set_if_default_or_unset,CC,$$(CROSS_COMPILE)cc) $(call set_if_default_or_unset,CPP,$$(CC) -E) $(call set_if_default_or_unset,AR,$$(CROSS_COMPILE)ar) $(call set_if_default_or_unset,NM,$$(CROSS_COMPILE)nm)