diff mbox series

[meta-swupdate] Use HTTPS as git protocol

Message ID 20170925122204.25838-1-christian.storm@siemens.com
State Changes Requested
Headers show
Series [meta-swupdate] Use HTTPS as git protocol | expand

Commit Message

Storm, Christian Sept. 25, 2017, 12:22 p.m. UTC
Using HTTPS for fetching the source is more (corporate)
proxy-friendly than using SSH.

Signed-off-by: Christian Storm <christian.storm@siemens.com>
---
 recipes-support/swupdate/swupdate.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefano Babic Sept. 25, 2017, 1 p.m. UTC | #1
Hi Christian,

On 25/09/2017 14:22, Christian Storm wrote:
> Using HTTPS for fetching the source is more (corporate)
> proxy-friendly than using SSH.

It is not ssh, it is git. Most friendly as ssh for companies, but not
enough. Rather git in https has a lot of overload,

> 
> Signed-off-by: Christian Storm <christian.storm@siemens.com>
> ---
>  recipes-support/swupdate/swupdate.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc
> index 123aa9d..705d312 100644
> --- a/recipes-support/swupdate/swupdate.inc
> +++ b/recipes-support/swupdate/swupdate.inc
> @@ -7,7 +7,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
>  
>  inherit cml1 update-rc.d systemd pkgconfig
>  
> -SRC_URI = "git://github.com/sbabic/swupdate.git;protocol=git \
> +SRC_URI = "git://github.com/sbabic/swupdate.git;protocol=https \
>       file://defconfig \
>       file://swupdate \
>       file://swupdate.service \
> 

Reviewed-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano
Storm, Christian Sept. 25, 2017, 2:07 p.m. UTC | #2
Hi Stefano,

> > Using HTTPS for fetching the source is more (corporate)
> > proxy-friendly than using SSH.
> 
> It is not ssh, it is git. 

Yes, I was not accurate enough on this, I meant SSH subsuming
other "shell" protocols. Just sent out a v2..

> Most friendly as ssh for companies, but not enough. 

Unfortunately...



Kind regards,
   Christian
diff mbox series

Patch

diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc
index 123aa9d..705d312 100644
--- a/recipes-support/swupdate/swupdate.inc
+++ b/recipes-support/swupdate/swupdate.inc
@@ -7,7 +7,7 @@  LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3"
 
 inherit cml1 update-rc.d systemd pkgconfig
 
-SRC_URI = "git://github.com/sbabic/swupdate.git;protocol=git \
+SRC_URI = "git://github.com/sbabic/swupdate.git;protocol=https \
      file://defconfig \
      file://swupdate \
      file://swupdate.service \