diff mbox series

[meta-swupdate] Fixed regression issue in which swupdate_unstripped was built and directly installed without first changing install name.

Message ID 1527268104-15261-1-git-send-email-ksloat@aampglobal.com
State Accepted
Headers show
Series [meta-swupdate] Fixed regression issue in which swupdate_unstripped was built and directly installed without first changing install name. | expand

Commit Message

Ken Sloat May 25, 2018, 5:08 p.m. UTC
From: Ken Sloat <ksloat@aampglobal.com>

As discussed previously, this fixes a regression issue on the Morty branch.

Signed-off-by: Ken Sloat <ksloat@aampglobal.com>
---
 recipes-support/swupdate/swupdate.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

ltkenbo0@gmail.com June 4, 2018, 2:55 p.m. UTC | #1
On Friday, May 25, 2018 at 1:08:31 PM UTC-4, ksl...@aampglobal.com wrote:
> From: Ken Sloat <ksloat@aampglobal.com>
> 
> As discussed previously, this fixes a regression issue on the Morty branch.
> 
> Signed-off-by: Ken Sloat <ksloat@aampglobal.com>
> ---
>  recipes-support/swupdate/swupdate.inc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc
> index 27dcf86..7326e9f 100644
> --- a/recipes-support/swupdate/swupdate.inc
> +++ b/recipes-support/swupdate/swupdate.inc
> @@ -97,12 +97,12 @@ do_configure () {
>  do_compile() {
>    unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
>    oe_runmake swupdate_unstripped
> -
> +  cp swupdate_unstripped swupdate
>  }
>  
>  do_install () {
>    install -d ${D}${bindir}/
> -  install -m 0755 swupdate_unstripped ${D}${bindir}/
> +  install -m 0755 swupdate ${D}${bindir}/
>  
>    install -m 0755 -d ${D}/www
>    if [ -d ${S}/web-app ];then
> -- 
> 2.7.4

Hi Stefano,

Does this patch look good? This is regression issue we discussed, my email is different because I am using my gmail account to post here.
Stefano Babic June 4, 2018, 3:31 p.m. UTC | #2
On 04/06/2018 16:55, ltkenbo0@gmail.com wrote:
> On Friday, May 25, 2018 at 1:08:31 PM UTC-4, ksl...@aampglobal.com wrote:
>> From: Ken Sloat <ksloat@aampglobal.com>
>>
>> As discussed previously, this fixes a regression issue on the Morty branch.
>>
>> Signed-off-by: Ken Sloat <ksloat@aampglobal.com>
>> ---
>>  recipes-support/swupdate/swupdate.inc | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc
>> index 27dcf86..7326e9f 100644
>> --- a/recipes-support/swupdate/swupdate.inc
>> +++ b/recipes-support/swupdate/swupdate.inc
>> @@ -97,12 +97,12 @@ do_configure () {
>>  do_compile() {
>>    unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
>>    oe_runmake swupdate_unstripped
>> -
>> +  cp swupdate_unstripped swupdate
>>  }
>>  
>>  do_install () {
>>    install -d ${D}${bindir}/
>> -  install -m 0755 swupdate_unstripped ${D}${bindir}/
>> +  install -m 0755 swupdate ${D}${bindir}/
>>  
>>    install -m 0755 -d ${D}/www
>>    if [ -d ${S}/web-app ];then
>> -- 
>> 2.7.4
> 
> Hi Stefano,
> 
> Does this patch look good? This is regression issue we discussed, my email is different because I am using my gmail account to post here.
> 

I rearranged the commit message and merged into -morty, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc
index 27dcf86..7326e9f 100644
--- a/recipes-support/swupdate/swupdate.inc
+++ b/recipes-support/swupdate/swupdate.inc
@@ -97,12 +97,12 @@  do_configure () {
 do_compile() {
   unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS
   oe_runmake swupdate_unstripped
-
+  cp swupdate_unstripped swupdate
 }
 
 do_install () {
   install -d ${D}${bindir}/
-  install -m 0755 swupdate_unstripped ${D}${bindir}/
+  install -m 0755 swupdate ${D}${bindir}/
 
   install -m 0755 -d ${D}/www
   if [ -d ${S}/web-app ];then