diff mbox series

[meta-swupdate] swupdate: add 2017.11

Message ID 1512742071-22167-1-git-send-email-vincent.prince.fr@gmail.com
State Changes Requested
Headers show
Series [meta-swupdate] swupdate: add 2017.11 | expand

Commit Message

vincent....@gmail.com Dec. 8, 2017, 2:07 p.m. UTC 
Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com>
---
 recipes-support/swupdate/swupdate.inc        | 2 +-
 recipes-support/swupdate/swupdate_2017.11.bb | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)
 create mode 100644 recipes-support/swupdate/swupdate_2017.11.bb

Comments

vincent....@gmail.com Dec. 8, 2017, 3:42 p.m. UTC | #1 
I kept  following line for older versions compatibility:
install -m 0644 ${S}include/progress.h ${D}${includedir}

Maybe we need to handle CURL and SYSTEMD new Kconfig variables in a V2.


Le vendredi 8 décembre 2017 15:08:06 UTC+1, Vincent Prince a écrit :
>
> Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com> 
> --- 
>  recipes-support/swupdate/swupdate.inc        | 2 +- 
>  recipes-support/swupdate/swupdate_2017.11.bb | 4 ++++ 
>  2 files changed, 5 insertions(+), 1 deletion(-) 
>  create mode 100644 recipes-support/swupdate/swupdate_2017.11.bb 
>
> diff --git a/recipes-support/swupdate/swupdate.inc 
> b/recipes-support/swupdate/swupdate.inc 
> index 1431d15..d7e7ef3 100644 
> --- a/recipes-support/swupdate/swupdate.inc 
> +++ b/recipes-support/swupdate/swupdate.inc 
> @@ -118,7 +118,7 @@ do_install () { 
>   
>    install -d ${D}${libdir}/ 
>    install -d ${D}${includedir}/ 
> -  install -m 0644 ${S}include/network_ipc.h ${D}${includedir} 
> +  install -m 0644 ${S}include/*_ipc.h ${D}${includedir} 
>    install -m 0644 ${S}include/swupdate_status.h ${D}${includedir} 
>    install -m 0644 ${S}include/progress.h ${D}${includedir} 
>    install -m 0755 ${S}ipc/lib.a ${D}${libdir}/libswupdate.a 
> diff --git a/recipes-support/swupdate/swupdate_2017.11.bb 
> b/recipes-support/swupdate/swupdate_2017.11.bb 
> new file mode 100644 
> index 0000000..fd6a6f5 
> --- /dev/null 
> +++ b/recipes-support/swupdate/swupdate_2017.11.bb 
> @@ -0,0 +1,4 @@ 
> +require swupdate.inc 
> +require swupdate_tools.inc 
> + 
> +SRCREV = "c0fec16b3fc82b0db12d8ac58be7055ed1b8d439" 
> -- 
> 2.7.4 
>
>
vincent....@gmail.com Dec. 12, 2017, 9:29 a.m. UTC | #2 
Hi Stefano,

I'm not confident with my pending V2...

Do we need to support older versions of swupdate ? (keep _2017.07.bb for
instance) or should we only have latest version?
Due to includes, it can be hard to support retro-compatibility without
dirty stuff.

I think we don't have to manage CONFIG_CURL as it is automatically added
when CONFIG_DOWNLOAD is set, am I wrong?

For systemd part, there is the new swupdate.socket, and after that, to
handle CONFIG_SYSTEMD, can we replace

    if 'CONFIG_SYSTEMD=y\n' in features:
        depends = d.getVar('DEPENDS', False)
        d.setVar('DEPENDS', depends + ' systemd')

by something like

    if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)};
then
           depends = d.getVar('DEPENDS', False)
           d.setVar('DEPENDS', depends + ' systemd')
    fi

then in do_configure, patch .config to add CONFIG_SYSTEMD :

do_configure () {
  cp ${WORKDIR}/defconfig ${S}/.config
  if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)};
then
     echo "CONFIG_SYSTEMD=y" >> ${S}/.config
  fi

I'm not sure it is the cleanest way to do it,

Best regards,
Vincent

2017-12-08 16:55 GMT+01:00 Stefano Babic <sbabic@denx.de>:

> Hi Vincent,
>
> On 08/12/2017 16:42, Vincent Prince wrote:
> > I kept  following line for older versions compatibility:
> > install -m 0644 ${S}include/progress.h ${D}${includedir}
> >
> > Maybe we need to handle CURL and SYSTEMD new Kconfig variables in a V2.
>
> Agree - please send a V2, thanks !
>
> Best regards,
> Stefano
>
> >
> >
> > Le vendredi 8 décembre 2017 15:08:06 UTC+1, Vincent Prince a écrit :
> >
> >     Signed-off-by: Vincent Prince <vincent.prince.fr@gmail.com
> >     <mailto:vincent.prince.fr@gmail.com>>
> >     ---
> >      recipes-support/swupdate/swupdate.inc        | 2 +-
> >      recipes-support/swupdate/swupdate_2017.11.bb
> >     <http://swupdate_2017.11.bb> | 4 ++++
> >      2 files changed, 5 insertions(+), 1 deletion(-)
> >      create mode 100644 recipes-support/swupdate/swupdate_2017.11.bb
> >     <http://swupdate_2017.11.bb>
> >
> >     diff --git a/recipes-support/swupdate/swupdate.inc
> >     b/recipes-support/swupdate/swupdate.inc
> >     index 1431d15..d7e7ef3 100644
> >     --- a/recipes-support/swupdate/swupdate.inc
> >     +++ b/recipes-support/swupdate/swupdate.inc
> >     @@ -118,7 +118,7 @@ do_install () {
> >
> >        install -d ${D}${libdir}/
> >        install -d ${D}${includedir}/
> >     -  install -m 0644 ${S}include/network_ipc.h ${D}${includedir}
> >     +  install -m 0644 ${S}include/*_ipc.h ${D}${includedir}
> >        install -m 0644 ${S}include/swupdate_status.h ${D}${includedir}
> >        install -m 0644 ${S}include/progress.h ${D}${includedir}
> >        install -m 0755 ${S}ipc/lib.a ${D}${libdir}/libswupdate.a
> >     diff --git a/recipes-support/swupdate/swupdate_2017.11.bb
> >     <http://swupdate_2017.11.bb>
> >     b/recipes-support/swupdate/swupdate_2017.11.bb
> >     <http://swupdate_2017.11.bb>
> >     new file mode 100644
> >     index 0000000..fd6a6f5
> >     --- /dev/null
> >     +++ b/recipes-support/swupdate/swupdate_2017.11.bb
> >     <http://swupdate_2017.11.bb>
> >     @@ -0,0 +1,4 @@
> >     +require swupdate.inc
> >     +require swupdate_tools.inc
> >     +
> >     +SRCREV = "c0fec16b3fc82b0db12d8ac58be7055ed1b8d439"
> >     --
> >     2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google
> > Groups "swupdate" group.
> > To unsubscribe from this group and stop receiving emails from it, send
> > an email to swupdate+unsubscribe@googlegroups.com
> > <mailto:swupdate+unsubscribe@googlegroups.com>.
> > To post to this group, send email to swupdate@googlegroups.com
> > <mailto:swupdate@googlegroups.com>.
> > For more options, visit https://groups.google.com/d/optout.
>
>
> --
> =====================================================================
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
> =====================================================================
>
diff mbox series

Patch

diff --git a/recipes-support/swupdate/swupdate.inc b/recipes-support/swupdate/swupdate.inc
index 1431d15..d7e7ef3 100644
--- a/recipes-support/swupdate/swupdate.inc
+++ b/recipes-support/swupdate/swupdate.inc
@@ -118,7 +118,7 @@  do_install () {
 
   install -d ${D}${libdir}/
   install -d ${D}${includedir}/
-  install -m 0644 ${S}include/network_ipc.h ${D}${includedir}
+  install -m 0644 ${S}include/*_ipc.h ${D}${includedir}
   install -m 0644 ${S}include/swupdate_status.h ${D}${includedir}
   install -m 0644 ${S}include/progress.h ${D}${includedir}
   install -m 0755 ${S}ipc/lib.a ${D}${libdir}/libswupdate.a
diff --git a/recipes-support/swupdate/swupdate_2017.11.bb b/recipes-support/swupdate/swupdate_2017.11.bb
new file mode 100644
index 0000000..fd6a6f5
--- /dev/null
+++ b/recipes-support/swupdate/swupdate_2017.11.bb
@@ -0,0 +1,4 @@ 
+require swupdate.inc
+require swupdate_tools.inc
+
+SRCREV = "c0fec16b3fc82b0db12d8ac58be7055ed1b8d439"