mbox series

[0/1] Fix failing A/B UBI volume updates

Message ID 20240620084932.4759-1-sam.van.den.berge@gmail.com
Headers show
Series Fix failing A/B UBI volume updates | expand

Message

Sam Van Den Berge June 20, 2024, 8:49 a.m. UTC 
From: Sam Van Den Berge <sam.van.den.berge@gmail.com>

Commit "5604c225 handlers: ubivol: Allow specifying MTD device" breaks UBI A/B
volume updates with an atomic swap at the end of the update because 1 strlen
check is missing in ubi_volume_get_info.

I think this bug is pretty serious because since release 2024.05, the ubiswap
fails after an update and hence the update fails.

Would it be possible to create a new (patch) release with this fix included?

Sam Van Den Berge (1):
  handlers: ubivol: fix missing device strlen check

 handlers/ubivol_handler.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefano Babic June 20, 2024, 9:24 a.m. UTC | #1 
On 20.06.24 10:49, sam.van.den.berge@gmail.com wrote:
> From: Sam Van Den Berge <sam.van.den.berge@gmail.com>
>
> Commit "5604c225 handlers: ubivol: Allow specifying MTD device" breaks UBI A/B
> volume updates with an atomic swap at the end of the update because 1 strlen
> check is missing in ubi_volume_get_info.
>
> I think this bug is pretty serious because since release 2024.05, the ubiswap
> fails after an update and hence the update fails.
>
> Would it be possible to create a new (patch) release with this fix included?

I will take care of it and release a 2024.05.1

Regards,
Stefano

>
> Sam Van Den Berge (1):
>    handlers: ubivol: fix missing device strlen check
>
>   handlers/ubivol_handler.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>