mbox series

[v3,0/4] downloader curl options: add max-download-speed

Message ID 20240530082007.1427631-1-dominique.martinet@atmark-techno.com
Headers show
Series downloader curl options: add max-download-speed | expand

Message

Dominique Martinet May 30, 2024, 8:20 a.m. UTC 
suricatta had a bunch of options not handled for downloader, so these
few patches level the field a bit:
- for command line option, just add --max-download-speed
- for config parsing, use common channel_settings()
- while here ustrtoull bit me during testing so make it a bit more
strict; I wasn't sure if we wanted a hard error but keeping the same
value is probably better for compatiblity... Thinking again most
callers don't check for errors so it'd probably be better to keep the
original value for compatibility instead?
I don't have strong feelings either way

link to v1/v2: https://groups.google.com/g/swupdate/c/wQFyW58kTnI/m/5VQEUdDQCAAJ

v1->v2:
- keep 'retries' that wasn't 'retry' for downloader settings

v2->v3:
- remove error message in ustrtoull
- add many warnings/errors to various callers


Dominique Martinet (3):
  util: ustrtoull: error on bad suffixes
  downloader: allow common channel settings
  ustrtoull callers cleanup: add warnings/errors when ustrotull fails

Shin-ya Koga (1):
  downloader: add -n/--max-download-speed option

 core/util.c                         |  8 ++++++++
 corelib/downloader.c                | 19 +++++++++++++++----
 corelib/server_utils.c              |  6 +++++-
 doc/source/swupdate.rst             |  8 ++++++++
 examples/configuration/swupdate.cfg |  4 ++++
 handlers/copy_handler.c             | 10 ++++++++--
 handlers/delta_handler.c            |  7 +++++--
 handlers/diskpart_handler.c         |  4 ++++
 suricatta/server_general.c          |  5 +++++
 suricatta/server_hawkbit.c          |  8 ++++++++
 suricatta/server_lua.c              |  3 +++
 11 files changed, 73 insertions(+), 9 deletions(-)