| Message ID | 20250123201909.15469-1-algonell@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | oradax: fix typo in dax_dbg message | expand |
That is not a typo. "Copyin" is correct as it refers to copying data in from user space. Rob On 1/23/25 13:17, Andrew Kreimer wrote: > There is a typo in a printk message: copyin -> copying. > > Fix it via codespell. > > Signed-off-by: Andrew Kreimer <algonell@gmail.com> > --- > drivers/sbus/char/oradax.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/sbus/char/oradax.c b/drivers/sbus/char/oradax.c > index a536dd6f4f7c..3f93208b616a 100644 > --- a/drivers/sbus/char/oradax.c > +++ b/drivers/sbus/char/oradax.c > @@ -874,7 +874,7 @@ static int dax_ccb_exec(struct dax_ctx *ctx, const char __user *buf, > * user in between validation and submission. > */ > if (copy_from_user(ctx->ccb_buf, buf, count)) { > - dax_dbg("copyin of user CCB buffer failed"); > + dax_dbg("copying of user CCB buffer failed"); > ctx->result.exec.status = DAX_SUBMIT_ERR_CCB_ARR_MMU_MISS; > return 0; > }
On Thu, Jan 23, 2025 at 01:23:20PM -0700, Rob Gardner wrote: > That is not a typo. "Copyin" is correct as it refers to copying data in from > user space. My bad!
Hi Rob, On Thu, 2025-01-23 at 13:23 -0700, Rob Gardner wrote: > That is not a typo. "Copyin" is correct as it refers to copying data in > from user space. If it's "copying in" data from user space, it should be spelled "copy in" and not "copyin" unless my English grammar skills are failing me. Adrian
On 1/26/25 11:32, John Paul Adrian Glaubitz wrote: > Hi Rob, > > On Thu, 2025-01-23 at 13:23 -0700, Rob Gardner wrote: >> That is not a typo. "Copyin" is correct as it refers to copying data in >> from user space. > If it's "copying in" data from user space, it should be spelled "copy in" > and not "copyin" unless my English grammar skills are failing me. > The resulting phrase "copy in of user CCB buffer" would contain two consecutive prepositions, which is poor English grammar. ;) There used to be a kernel function called copyin() that was changed to copy_from_user() in the dim past. But I think "copyin" is still widely understood as an /operation/, not an English word, kind of like "ccb". Apologies to all for cluttering up multiple lists with this trivia. Rob
diff --git a/drivers/sbus/char/oradax.c b/drivers/sbus/char/oradax.c index a536dd6f4f7c..3f93208b616a 100644 --- a/drivers/sbus/char/oradax.c +++ b/drivers/sbus/char/oradax.c @@ -874,7 +874,7 @@ static int dax_ccb_exec(struct dax_ctx *ctx, const char __user *buf, * user in between validation and submission. */ if (copy_from_user(ctx->ccb_buf, buf, count)) { - dax_dbg("copyin of user CCB buffer failed"); + dax_dbg("copying of user CCB buffer failed"); ctx->result.exec.status = DAX_SUBMIT_ERR_CCB_ARR_MMU_MISS; return 0; }
There is a typo in a printk message: copyin -> copying. Fix it via codespell. Signed-off-by: Andrew Kreimer <algonell@gmail.com> --- drivers/sbus/char/oradax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)