mbox series

[v2,0/4] PCI: Simplify bus range parsing

Message ID 20250113231557.441289-1-helgaas@kernel.org
Headers show
Series PCI: Simplify bus range parsing | expand

Message

Bjorn Helgaas Jan. 13, 2025, 11:15 p.m. UTC 
From: Bjorn Helgaas <bhelgaas@google.com>

Unexport of_pci_parse_bus_range() since it's only used in drivers/pci/of.c.

Drop the "No bus range found" message since host bridges typically lead to
[bus 00-ff], and we already default to that if there is no "bus-range" DT
property, so there's no point in requiring it in DT or complaining if it's
not there.

Drop bus range parameters from devm_of_pci_get_host_bridge_resources()
since they're always the same values.

Update a sparc comment that referred to of_pci_get_host_bridge_resources(),
which no longer exists.

Bjorn Helgaas (4):
  PCI: Unexport of_pci_parse_bus_range()
  PCI: of: Drop 'No bus range found' message
  PCI: of: Simplify devm_of_pci_get_host_bridge_resources() interface
  sparc/PCI: Update reference to devm_of_pci_get_host_bridge_resources()

 arch/sparc/kernel/pci_common.c |  2 +-
 drivers/pci/of.c               | 22 ++++++++++------------
 drivers/pci/pci.h              |  7 -------
 3 files changed, 11 insertions(+), 20 deletions(-)

Changes since v1
(https://lore.kernel.org/r/20250103213129.5182-1-helgaas@kernel.org):
  - Fix compile error
  - Drop 'No bus range found' message
  - Add Ack from Andreas for the sparc/PCI comment update
  - Add Reviewed-by from Rob for the unexport patch

Comments

Bjorn Helgaas Jan. 15, 2025, 9:29 p.m. UTC | #1 
On Mon, Jan 13, 2025 at 05:15:53PM -0600, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Unexport of_pci_parse_bus_range() since it's only used in drivers/pci/of.c.
> 
> Drop the "No bus range found" message since host bridges typically lead to
> [bus 00-ff], and we already default to that if there is no "bus-range" DT
> property, so there's no point in requiring it in DT or complaining if it's
> not there.
> 
> Drop bus range parameters from devm_of_pci_get_host_bridge_resources()
> since they're always the same values.
> 
> Update a sparc comment that referred to of_pci_get_host_bridge_resources(),
> which no longer exists.
> 
> Bjorn Helgaas (4):
>   PCI: Unexport of_pci_parse_bus_range()
>   PCI: of: Drop 'No bus range found' message
>   PCI: of: Simplify devm_of_pci_get_host_bridge_resources() interface
>   sparc/PCI: Update reference to devm_of_pci_get_host_bridge_resources()
> 
>  arch/sparc/kernel/pci_common.c |  2 +-
>  drivers/pci/of.c               | 22 ++++++++++------------
>  drivers/pci/pci.h              |  7 -------
>  3 files changed, 11 insertions(+), 20 deletions(-)

Applied to pci/of for v6.14.

> Changes since v1
> (https://lore.kernel.org/r/20250103213129.5182-1-helgaas@kernel.org):
>   - Fix compile error
>   - Drop 'No bus range found' message
>   - Add Ack from Andreas for the sparc/PCI comment update
>   - Add Reviewed-by from Rob for the unexport patch