From patchwork Thu Nov 30 12:50:51 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Balbir Singh X-Patchwork-Id: 842975 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3yncj743SYz9t3Z for ; Thu, 30 Nov 2017 23:51:23 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="l0C/c0ar"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3yncj72Fk9zDsFR for ; Thu, 30 Nov 2017 23:51:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="l0C/c0ar"; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:400e:c01::244; helo=mail-pl0-x244.google.com; envelope-from=bsingharora@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="l0C/c0ar"; dkim-atps=neutral Received: from mail-pl0-x244.google.com (mail-pl0-x244.google.com [IPv6:2607:f8b0:400e:c01::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3ynchs0WCRzDrqT for ; Thu, 30 Nov 2017 23:51:08 +1100 (AEDT) Received: by mail-pl0-x244.google.com with SMTP id g2so4184848pli.8 for ; Thu, 30 Nov 2017 04:51:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AwHS76baAqLuC757p1Y7sZkAzGHwwaToVM8gIOTo4Ec=; b=l0C/c0arOxv+Yk92QTHuTmGFUxlXndTohgw+NPI4xJTpuCw/Qg3sPqNN0klaFZhgAq W0Ole4WQYZRDN19QXOla5bOieUDDKQEDqjwn8/nOK4WvScIxrpcAB0ehJNgEzbDIERfm 5Gi1IYA7hCdejQpDyijZLMDvlh/tV+PAB3QK1lWmddzCwW+fBKrVvNxedJ/bwMzISCAQ DcuJr31IziE3SKzen93lbaPw2qOrrikTEdF/Defx0tedZvOC25EPtf/o0nQXX6JWy9jh KXOnj9OMV6pn+xJ1PMdi/XuQpMaR58+1S6+4roBOhrIFLZtLSYzvWwjw8BG9U3+Rkh6u 8Kzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AwHS76baAqLuC757p1Y7sZkAzGHwwaToVM8gIOTo4Ec=; b=E+glOanBrn1E2NoZMyt33qWghPRQ4yIwl2lzyD2azJA8tRIYmbiwaL0Aw74J2Qi20x B9PJd8snjPENnlXdy9Gh/meJYUwd76Z/EgR0/vFgDdG0VP1hrlUA5FuA246IOD3/8UH4 OEis8lE0ncKJDG8x7h6hrP3dQGDuYgSCnbsVTn0nR1iz0Mm37upv8Ayy5A8SAcVZtCGv 3j2VPNyezH5dxuwigdCzh0HPu9SbJtIpVXigixj2I70Asf5TCWW/uq4kmVHKdfCTGP67 XIU4lIiUQOJC5A67I+WkWWO02Sa3t4gyD/U5j32v/QYQHoYkiGILATR/e+/h7oYvFHR9 2hKw== X-Gm-Message-State: AJaThX4LdxO9xIk4DRIUbnlClBCrrq24FpTU3jh3Y/rt/PpnUa9cvIbv d6mPdnQ0XpF5G3E6fom23oYfcTbU X-Google-Smtp-Source: AGs4zMaQ3c5/V6omOconWgmg/hXU7Xc+DQ9CtM57bXDZ3CaJwrh6weU+dNhaNLO5DOSnYsSfH0RoLg== X-Received: by 10.159.255.7 with SMTP id bi7mr2484647plb.221.1512046266567; Thu, 30 Nov 2017 04:51:06 -0800 (PST) Received: from localhost.au.ibm.com (14-202-194-140.static.tpgi.com.au. [14.202.194.140]) by smtp.googlemail.com with ESMTPSA id 184sm7692588pfd.78.2017.11.30.04.51.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 Nov 2017 04:51:05 -0800 (PST) From: Balbir Singh To: skiboot@lists.ozlabs.org Date: Thu, 30 Nov 2017 23:50:51 +1100 Message-Id: <20171130125051.1433-2-bsingharora@gmail.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20171130125051.1433-1-bsingharora@gmail.com> References: <20171130125051.1433-1-bsingharora@gmail.com> Subject: [Skiboot] [PATCH 2/2] core/hmi: Do not call find_core_checkstop_reason() unconditionally X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair@popple.id.au MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" We tend to call find_core_checkstop_reason() even if the NPU/NX/CAPI HMI handling paths found and accepted the reason for the local checkstop. We also trash hmi_evt in the call. Signed-off-by: Balbir Singh --- core/hmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/hmi.c b/core/hmi.c index bb144512..62a916ba 100644 --- a/core/hmi.c +++ b/core/hmi.c @@ -697,7 +697,8 @@ static void decode_malfunction(struct OpalHMIEvent *hmi_evt) } } - find_core_checkstop_reason(hmi_evt, &event_generated); + if (!event_generated) + find_core_checkstop_reason(hmi_evt, &event_generated); /* * If we fail to find checkstop reason, send an unknown HMI event.