diff mbox series

R rtc-ab-eoz9.c alarm hours work only between 00:00 - 19:59

Message ID AM8PR07MB74750FE9B3F733C13D3CF9768EEA2@AM8PR07MB7475.eurprd07.prod.outlook.com
State Superseded
Headers show
Series R rtc-ab-eoz9.c alarm hours work only between 00:00 - 19:59 | expand

Commit Message

Erkkilä Taneli May 21, 2024, 7 a.m. UTC
Driver uses only first 4 bits from "alarm hour"(ABEOZ9_BIT_ALARM_HOURS) that makes it work only between 00:00-19:59. Fifth bit tells alarm time between 20:00-23:59 and it is ignored.
diff mbox series

Patch

Index: linux-imx/drivers/rtc/rtc-ab-eoz9.c
===================================================================
--- linux-imx.orig/drivers/rtc/rtc-ab-eoz9.c
+++ linux-imx/drivers/rtc/rtc-ab-eoz9.c
@@ -64,7 +64,7 @@ 
#define ABEOZ9_BIT_ALARM_MIN                                             GENMASK(6, 0)
#define ABEOZ9_REG_ALARM_HOURS                                      0x12
#define ABEOZ9_BIT_ALARM_HOURS_PM  BIT(5)
-#define ABEOZ9_BIT_ALARM_HOURS                                       GENMASK(4, 0)
+#define ABEOZ9_BIT_ALARM_HOURS                                      GENMASK(5, 0)
#define ABEOZ9_REG_ALARM_DAYS                                          0x13
#define ABEOZ9_BIT_ALARM_DAYS                                            GENMASK(5, 0)
#define ABEOZ9_REG_ALARM_WEEKDAYS  0x14