diff mbox series

rtc: RTC_DRV_SPEAR should not default to y when compile-testing

Message ID 7b8eefe3b0150101ba01c3ea55e45aa3134059ba.1733243007.git.geert+renesas@glider.be
State Accepted
Headers show
Series rtc: RTC_DRV_SPEAR should not default to y when compile-testing | expand

Commit Message

Geert Uytterhoeven Dec. 3, 2024, 4:25 p.m. UTC
Merely enabling compile-testing should not enable additional
functionality.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/rtc/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Viresh Kumar Dec. 4, 2024, 3:37 a.m. UTC | #1
On 03-12-24, 17:25, Geert Uytterhoeven wrote:
> Merely enabling compile-testing should not enable additional
> functionality.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/rtc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index a60bcc791a4803b7..0bbbf778ecfa3e4c 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1316,7 +1316,7 @@ config RTC_DRV_SC27XX
>  config RTC_DRV_SPEAR
>  	tristate "SPEAR ST RTC"
>  	depends on PLAT_SPEAR || COMPILE_TEST
> -	default y
> +	default PLAT_SPEAR
>  	help
>  	 If you say Y here you will get support for the RTC found on
>  	 spear

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Alexandre Belloni Jan. 9, 2025, 5:27 p.m. UTC | #2
On Tue, 03 Dec 2024 17:25:05 +0100, Geert Uytterhoeven wrote:
> Merely enabling compile-testing should not enable additional
> functionality.
> 
> 

Applied, thanks!

[1/1] rtc: RTC_DRV_SPEAR should not default to y when compile-testing
      https://git.kernel.org/abelloni/c/7158c61afdcf

Best regards,
diff mbox series

Patch

diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index a60bcc791a4803b7..0bbbf778ecfa3e4c 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1316,7 +1316,7 @@  config RTC_DRV_SC27XX
 config RTC_DRV_SPEAR
 	tristate "SPEAR ST RTC"
 	depends on PLAT_SPEAR || COMPILE_TEST
-	default y
+	default PLAT_SPEAR
 	help
 	 If you say Y here you will get support for the RTC found on
 	 spear