From patchwork Tue Apr 2 14:24:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Patchwork-Id: 1918867 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=HufWAAgk; dkim-atps=neutral Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=patchwork.ozlabs.org) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V89F45MWjz1yZ3 for ; Wed, 3 Apr 2024 01:27:04 +1100 (AEDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rrf6J-0003nX-JL; Tue, 02 Apr 2024 10:26:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrf5N-0002BG-GO for qemu-ppc@nongnu.org; Tue, 02 Apr 2024 10:26:03 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rrf5K-0000KG-Oe for qemu-ppc@nongnu.org; Tue, 02 Apr 2024 10:26:01 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-34372e3db28so358515f8f.2 for ; Tue, 02 Apr 2024 07:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712067954; x=1712672754; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UdHptW6/vmFiZMZ88dmnQIm/hdJiCEdE6JKu99L0Ilk=; b=HufWAAgk8e40SvOjg0tlNYJouxNf/WRJIsa/JTaf7qt1POY5ahqP+yxAKBbfd7wK/c N1XBjAJh2CdA32lcFd6QrR5TZiPFk/veOVV9Ff8hQmpEr7jO2TM7briplrmGo7In2R+j SOncngXqQltxGwHOTkceeVLdSJaJxZ4fJVfPQRhw5FY9S9+Uy4/qOhQZUoSJE/co9MND e51mCiL6I0P2o7PVbJqf3zC7FOhhwotULmpD8T0U61/OasfHFYZLsE7m8Q0joQZeBz+c XcZLrq6aZUhF+uCyoLoDLWbAHsIluooP1WxS5P/weF3s1nEom0MwP/3q9vyTzVveUNob /9Vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712067954; x=1712672754; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UdHptW6/vmFiZMZ88dmnQIm/hdJiCEdE6JKu99L0Ilk=; b=e+BCsixrQ6Zd2Od3XlT9+oJJ/PLuXVQH95TnhBe4xg054wJRr87nlx/sjJ64Qt57Wg a0NXdkfoHtXAYTng63GKAVCLooxxXW4I578LOqZMTxPPo6giAelrMq5+KFaqY7nChV0I 36UHsejHUfO672eM961G92gz55qt/YFkswL9bCqKOzl4j7iHdQxxzE301I/JlLBslYBd +RCMoUK4XCq9687Y9KyAUspR9jweo/RgtI3GTwl9Avwg4Qa4m7ivsBfAyx8KhptS89WM ewDqmYYY21es1hkcBwfF2TnppLDGHuQdjzS/zIeV0SUwi6xx/qTzzTD2SXbyaTECNu4b bVEw== X-Gm-Message-State: AOJu0Yz8ViGCxdRafdgSlsp/6pT05MqDVfrqPlPWz5k4gtds0Rnpl6Tx xdNb59R0WotCSaCy9wb3RCNc53RNYk6RkGYFP926UNu8SkjKw6XgY3L/ILDFcIc= X-Google-Smtp-Source: AGHT+IFiVGIz6hUw63J+oL2x0lH56xk6vCoRVjjs++gnHuYH9IqZW9qRKSwmwiEaIaW8+7hUAoQS0Q== X-Received: by 2002:a5d:6451:0:b0:33d:2775:1e63 with SMTP id d17-20020a5d6451000000b0033d27751e63mr8411023wrw.41.1712067954632; Tue, 02 Apr 2024 07:25:54 -0700 (PDT) Received: from m1x-phil.lan ([176.187.202.91]) by smtp.gmail.com with ESMTPSA id c9-20020a7bc2a9000000b0041552dbc539sm13501997wmk.11.2024.04.02.07.25.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 02 Apr 2024 07:25:54 -0700 (PDT) From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, qemu-block@nongnu.org, qemu-arm@nongnu.org, =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Klaus Jensen , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Keith Busch , Klaus Jensen , Jesper Devantier Subject: [PULL 12/15] hw/nvme: fix -Werror=maybe-uninitialized Date: Tue, 2 Apr 2024 16:24:27 +0200 Message-ID: <20240402142431.70700-13-philmd@linaro.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20240402142431.70700-1-philmd@linaro.org> References: <20240402142431.70700-1-philmd@linaro.org> MIME-Version: 1.0 Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=philmd@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-ppc@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-ppc-bounces+incoming=patchwork.ozlabs.org@nongnu.org From: Marc-André Lureau ../hw/nvme/ctrl.c:6081:21: error: ‘result’ may be used uninitialized [-Werror=maybe-uninitialized] It's not obvious that 'result' is set in all code paths. When &result is a returned argument, it's even less clear. Looking at various assignments, 0 seems to be a suitable default value. Signed-off-by: Marc-André Lureau Reviewed-by: Klaus Jensen Message-ID: <20240328102052.3499331-18-marcandre.lureau@redhat.com> Signed-off-by: Philippe Mathieu-Daudé --- hw/nvme/ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c index c2b17de987..127c3d2383 100644 --- a/hw/nvme/ctrl.c +++ b/hw/nvme/ctrl.c @@ -5894,7 +5894,7 @@ static uint16_t nvme_get_feature(NvmeCtrl *n, NvmeRequest *req) uint32_t dw10 = le32_to_cpu(cmd->cdw10); uint32_t dw11 = le32_to_cpu(cmd->cdw11); uint32_t nsid = le32_to_cpu(cmd->nsid); - uint32_t result; + uint32_t result = 0; uint8_t fid = NVME_GETSETFEAT_FID(dw10); NvmeGetFeatureSelect sel = NVME_GETFEAT_SELECT(dw10); uint16_t iv;