mbox series

[PATCH-for-10.0,v2,00/13] hw/boards: Remove legacy MachineClass::pci_allow_0_address flag

Message ID 20241126112212.64524-1-philmd@linaro.org
Headers show
Series hw/boards: Remove legacy MachineClass::pci_allow_0_address flag | expand

Message

Philippe Mathieu-Daudé Nov. 26, 2024, 11:21 a.m. UTC 
Since v1:
- Looked at previous analysis from Peter [1]
- Invert logic so "allow address 0 accesses" is default

---

This series aims to remove a legacy field from
MachineClass. Why? Because it doesn't scale on
heterogeneous machine where different host bridges
are created.

Rather than a global exposed to all machines,
use a pci-bus specific flag on each machine
requiring it, propagated by the host bridge
device.

No logical change intended, only machines previously
using pci_allow_0_address do not set refuse-bar-at-addr-0.

Presumably various machines neither need to set this
'refuse-bar-at-addr-0' flag, but updating that is
deferred to each machine maintainer since I don't have
the knowledge and sufficient test suite IMHO.

[1] https://lore.kernel.org/qemu-devel/20241125140535.4526-1-philmd@linaro.org/
[2] https://lore.kernel.org/qemu-devel/1444683308-30543-1-git-send-email-agordeev@redhat.com/T/#u

Philippe Mathieu-Daudé (13):
  hw/pci: Do not declare PCIBus::flags mask as enum
  hw/pci-bridge: Initialize bridge with parent bus flags
  hw/pci: Factor machine_refuses_bar_at_addr_0() helper out
  hw/pci: Introduce PCIBusFlag::PCI_BUS_BAR_AT_ADDR0_REFUSED
  hw/pci: Propagate bar_at_addr_0_refused to
    pci_root_bus_internal_init()
  hw/pci: Propagate bar_at_addr_0_refused to pci_root_bus_init()
  hw/pci: Propagate bar_at_addr_0_refused to pci_root_bus_new()
  hw/pci: Propagate bar_at_addr_0_refused to pci_register_root_bus()
  hw/ppc/spapr: Create host bridge setting bar_at_addr_0_refused=false
  hw/pci-host/gpex: Expose 'refuse-bar-at-addr-0' property
  hw/arm/virt: Create GPEX host bridge without refuse-bar-at-addr-0
  hw/riscv/virt: Create GPEX host bridge without refuse-bar-at-addr-0
  hw/pci/pci: Remove legacy MachineClass::pci_allow_0_address flag

 include/hw/boards.h                 |  1 -
 include/hw/pci-host/gpex.h          |  1 +
 include/hw/pci/pci.h                |  8 +++++---
 include/hw/pci/pci_bus.h            | 10 ++++++++--
 hw/alpha/typhoon.c                  |  2 +-
 hw/arm/sbsa-ref.c                   |  1 -
 hw/arm/virt.c                       |  1 -
 hw/i386/microvm.c                   |  2 ++
 hw/loongarch/virt.c                 |  2 ++
 hw/mips/loongson3_virt.c            |  2 ++
 hw/openrisc/virt.c                  |  2 ++
 hw/pci-bridge/pci_expander_bridge.c | 17 +++++++++++-----
 hw/pci-host/articia.c               |  3 ++-
 hw/pci-host/astro.c                 |  3 ++-
 hw/pci-host/bonito.c                |  2 +-
 hw/pci-host/designware.c            |  2 +-
 hw/pci-host/dino.c                  |  2 +-
 hw/pci-host/gpex.c                  |  5 ++++-
 hw/pci-host/grackle.c               |  2 +-
 hw/pci-host/gt64120.c               |  2 +-
 hw/pci-host/i440fx.c                |  2 +-
 hw/pci-host/mv64361.c               |  2 +-
 hw/pci-host/pnv_phb3.c              |  2 +-
 hw/pci-host/pnv_phb4.c              |  2 +-
 hw/pci-host/ppc440_pcix.c           |  2 +-
 hw/pci-host/ppc4xx_pci.c            |  2 +-
 hw/pci-host/ppce500.c               |  3 ++-
 hw/pci-host/q35.c                   |  2 +-
 hw/pci-host/raven.c                 |  2 +-
 hw/pci-host/remote.c                |  2 +-
 hw/pci-host/sabre.c                 |  2 +-
 hw/pci-host/sh_pci.c                |  2 +-
 hw/pci-host/uninorth.c              |  8 ++++----
 hw/pci-host/versatile.c             |  2 +-
 hw/pci-host/xilinx-pcie.c           |  2 +-
 hw/pci/pci.c                        | 31 ++++++++++++++++++-----------
 hw/pci/pci_bridge.c                 |  1 +
 hw/ppc/ppc440_uc.c                  |  2 +-
 hw/ppc/spapr.c                      |  1 -
 hw/ppc/spapr_pci.c                  |  2 +-
 hw/riscv/virt.c                     |  1 -
 hw/s390x/s390-pci-bus.c             |  2 +-
 hw/xen/xen-pvh-common.c             |  2 ++
 hw/xtensa/virt.c                    |  2 ++
 44 files changed, 94 insertions(+), 57 deletions(-)