From patchwork Tue Feb 11 07:07:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hu Tao X-Patchwork-Id: 319160 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id DF67B2C00BA for ; Tue, 11 Feb 2014 18:09:50 +1100 (EST) Received: from localhost ([::1]:59942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WD7TY-0006uU-2E for incoming@patchwork.ozlabs.org; Tue, 11 Feb 2014 02:09:48 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WD7Sy-0006sl-LF for qemu-devel@nongnu.org; Tue, 11 Feb 2014 02:09:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WD7Sr-0003hn-4f for qemu-devel@nongnu.org; Tue, 11 Feb 2014 02:09:12 -0500 Received: from [222.73.24.84] (port=40244 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WD7Sq-0003fp-Mo for qemu-devel@nongnu.org; Tue, 11 Feb 2014 02:09:05 -0500 X-IronPort-AV: E=Sophos;i="4.95,824,1384272000"; d="scan'208";a="9505135" Received: from unknown (HELO tang.cn.fujitsu.com) ([10.167.250.3]) by song.cn.fujitsu.com with ESMTP; 11 Feb 2014 15:05:11 +0800 Received: from fnstmail02.fnst.cn.fujitsu.com (tang.cn.fujitsu.com [127.0.0.1]) by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id s1B78uX6026070; Tue, 11 Feb 2014 15:08:57 +0800 Received: from G08FNSTD100614.fnst.cn.fujitsu.com ([10.167.226.102]) by fnstmail02.fnst.cn.fujitsu.com (Lotus Domino Release 8.5.3) with ESMTP id 2014021115070070-1728896 ; Tue, 11 Feb 2014 15:07:00 +0800 From: Hu Tao To: qemu-devel@nongnu.org Date: Tue, 11 Feb 2014 15:07:07 +0800 Message-Id: X-Mailer: git-send-email 1.8.5.2.229.g4448466 In-Reply-To: References: X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2014/02/11 15:07:00, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2014/02/11 15:07:03, Serialize complete at 2014/02/11 15:07:03 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 222.73.24.84 Cc: Kevin Wolf , Stefan Hajnoczi , Fam Zheng , Peter Lieven Subject: [Qemu-devel] [PATCH v5 RESEND 1/4] qapi: introduce PreallocMode and a new PreallocMode full. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org This patch prepares for the subsequent patches. Signed-off-by: Hu Tao Reviewed-by: Fam Zheng Reviewed-by: Eric Blake --- block/qcow2.c | 8 ++++---- qapi-schema.json | 12 ++++++++++++ 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 99a1ad1..30e36bc 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1452,7 +1452,7 @@ static int preallocate(BlockDriverState *bs) static int qcow2_create2(const char *filename, int64_t total_size, const char *backing_file, const char *backing_format, - int flags, size_t cluster_size, int prealloc, + int flags, size_t cluster_size, PreallocMode prealloc, QEMUOptionParameter *options, int version, Error **errp) { @@ -1622,7 +1622,7 @@ static int qcow2_create(const char *filename, QEMUOptionParameter *options, uint64_t sectors = 0; int flags = 0; size_t cluster_size = DEFAULT_CLUSTER_SIZE; - int prealloc = 0; + PreallocMode prealloc = PREALLOC_MODE_OFF; int version = 3; Error *local_err = NULL; int ret; @@ -1643,9 +1643,9 @@ static int qcow2_create(const char *filename, QEMUOptionParameter *options, } } else if (!strcmp(options->name, BLOCK_OPT_PREALLOC)) { if (!options->value.s || !strcmp(options->value.s, "off")) { - prealloc = 0; + prealloc = PREALLOC_MODE_OFF; } else if (!strcmp(options->value.s, "metadata")) { - prealloc = 1; + prealloc = PREALLOC_MODE_METADATA; } else { error_setg(errp, "Invalid preallocation mode: '%s'", options->value.s); diff --git a/qapi-schema.json b/qapi-schema.json index 05ced9d..f86068c 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -4419,3 +4419,15 @@ # Since: 1.7 ## { 'command': 'blockdev-add', 'data': { 'options': 'BlockdevOptions' } } + +## +# @PreallocMode +# +# Preallocation mode of QEMU image file +# +# @off: no preallocation +# @metadata: preallocate only for metadata +# @full: preallocate all data, including metadata +## +{ 'enum': 'PreallocMode', + 'data': [ 'off', 'metadata', 'full' ] }