Message ID | fba8112ca7b01efd72553332b8045ecf107b7662.1448021100.git.alistair.francis@xilinx.com |
---|---|
State | New |
Headers | show |
On 20 November 2015 at 12:09, Alistair Francis <alistair.francis@xilinx.com> wrote: > The minimum RAM check logic for the Xiilnx EP108 was off by one, > which caused a false positive. Correct the logic to only print > warnings when the RAM is below 0x8000000. > > Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> > --- > > hw/arm/xlnx-ep108.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c > index 2899698..85b978f 100644 > --- a/hw/arm/xlnx-ep108.c > +++ b/hw/arm/xlnx-ep108.c > @@ -51,7 +51,7 @@ static void xlnx_ep108_init(MachineState *machine) > machine->ram_size = EP108_MAX_RAM_SIZE; > } > > - if (machine->ram_size <= 0x08000000) { > + if (machine->ram_size < 0x08000000) { > qemu_log("WARNING: RAM size " RAM_ADDR_FMT " is small for EP108", > machine->ram_size); > } > -- > 2.5.0 Applied, thanks. -- PMM
diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c index 2899698..85b978f 100644 --- a/hw/arm/xlnx-ep108.c +++ b/hw/arm/xlnx-ep108.c @@ -51,7 +51,7 @@ static void xlnx_ep108_init(MachineState *machine) machine->ram_size = EP108_MAX_RAM_SIZE; } - if (machine->ram_size <= 0x08000000) { + if (machine->ram_size < 0x08000000) { qemu_log("WARNING: RAM size " RAM_ADDR_FMT " is small for EP108", machine->ram_size); }
The minimum RAM check logic for the Xiilnx EP108 was off by one, which caused a false positive. Correct the logic to only print warnings when the RAM is below 0x8000000. Signed-off-by: Alistair Francis <alistair.francis@xilinx.com> --- hw/arm/xlnx-ep108.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)