From patchwork Fri Jun 24 09:53:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Riku Voipio X-Patchwork-Id: 640112 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rbYbQ5rV2z9sC4 for ; Fri, 24 Jun 2016 19:54:58 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b=KrKIg2fe; dkim-atps=neutral Received: from localhost ([::1]:42248 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGNpA-0002LY-NF for incoming@patchwork.ozlabs.org; Fri, 24 Jun 2016 05:54:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58777) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGNno-0000ev-AO for qemu-devel@nongnu.org; Fri, 24 Jun 2016 05:53:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGNnm-0003GR-G1 for qemu-devel@nongnu.org; Fri, 24 Jun 2016 05:53:31 -0400 Received: from mail-lf0-x22a.google.com ([2a00:1450:4010:c07::22a]:34723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGNnm-0003G1-82 for qemu-devel@nongnu.org; Fri, 24 Jun 2016 05:53:30 -0400 Received: by mail-lf0-x22a.google.com with SMTP id h129so112854201lfh.1 for ; Fri, 24 Jun 2016 02:53:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=N9tTYj+bXvpAnB/2l0KnYAv5wpiIVkYGoFtZN7M9Dxc=; b=KrKIg2feFQP39g3nkmUJVDfeOI5Wf+WuzaFippmkKpn7uNnkUn02X9EFspEh7u+BmB mQPFVwg/jAKhuefOdpHrN3qEteHWEOvsZoQWycXZSEFAoFJCSdhmMkJAX9tY1WHIbnYU QuM6hckPezL2J3uFIKjv1kTnQz3/1h7+V4kOU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=N9tTYj+bXvpAnB/2l0KnYAv5wpiIVkYGoFtZN7M9Dxc=; b=Cmzvz+rY2Jf7UX9JigtYgrHWooUOkYhgrbjG0vv+cnZZc+dqIbOx4O3pGDzfpf/g4s MYmFC0A0uPMz3F1F+wwf2dQ+4w7b9W8km9q4wJbMMdHD9KwDO/nRCjC+mDvNhzcs5hVN VF8S/3SZFKJ2c5fibceYLWqKzc76Y81dF+PBF8ZglniYo4PQCVH7IAfgzlAEc7B2rqHG CmZy5miROwMW2ebsp8hIKgIewVUUysJ6GJB3YZwJwtfy6yZFVT79HYHqfsauG22bhWZQ 3GaLoiKLdhrJShyP2OTAyBDdqHUIe/2g6dKgDBDQUM9ACUfYc3GMseJfnYOT1WVyNgt0 BzHg== X-Gm-Message-State: ALyK8tJ0/wSbrtxNN6jWYrm14bFdtFW/gtWiJHQP62/CSpE/D1NOzmnWqmrXRx8OFSFcoHG8 X-Received: by 10.25.149.13 with SMTP id x13mr1014941lfd.199.1466762009419; Fri, 24 Jun 2016 02:53:29 -0700 (PDT) Received: from beaming.home (85-76-80-69-nat.elisa-mobile.fi. [85.76.80.69]) by smtp.gmail.com with ESMTPSA id o137sm798203lfe.2.2016.06.24.02.53.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 24 Jun 2016 02:53:28 -0700 (PDT) From: riku.voipio@linaro.org To: qemu-devel@nongnu.org Date: Fri, 24 Jun 2016 12:53:00 +0300 Message-Id: X-Mailer: git-send-email 2.1.4 In-Reply-To: References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::22a Subject: [Qemu-devel] [PULL 05/24] configure: Don't override ARCH=unknown if enabling TCI X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" From: Peter Maydell At the moment if configure finds an unknown CPU it will set ARCH to 'unknown', and then later either bail out or set it to 'tci' (depending on whether the user passed configure the --enable-tcg-interpreter switch). This is unnecessarily confusing, because we could be using TCI in two cases: * a known host architecture (in which case ARCH is set to the actual host architecture, like 'i386') * an unknown host architecture (in which case ARCH is set to 'tci') so nothing can rely on ARCH=tci to mean "using TCI". Remove the line setting ARCH, so we leave it as "unknown", which is what the actual situation is. Signed-off-by: Peter Maydell Reviewed-by: Laurent Vivier Reviewed-by: Richard Henderson Signed-off-by: Riku Voipio --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index 5929aba..6696316 100755 --- a/configure +++ b/configure @@ -1380,7 +1380,6 @@ fi if test "$ARCH" = "unknown"; then if test "$tcg_interpreter" = "yes" ; then echo "Unsupported CPU = $cpu, will use TCG with TCI (experimental)" - ARCH=tci else error_exit "Unsupported CPU = $cpu, try --enable-tcg-interpreter" fi