From patchwork Thu Jan 20 07:21:39 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Isaku Yamahata X-Patchwork-Id: 79644 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E7B77B70B3 for ; Thu, 20 Jan 2011 18:23:50 +1100 (EST) Received: from localhost ([127.0.0.1]:36614 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pforz-0001WF-Rk for incoming@patchwork.ozlabs.org; Thu, 20 Jan 2011 02:23:47 -0500 Received: from [140.186.70.92] (port=52757 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pfoq2-0001Nt-0A for qemu-devel@nongnu.org; Thu, 20 Jan 2011 02:21:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pfoq0-00017N-GL for qemu-devel@nongnu.org; Thu, 20 Jan 2011 02:21:45 -0500 Received: from mail.valinux.co.jp ([210.128.90.3]:55285) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pfoq0-00016Z-6u for qemu-devel@nongnu.org; Thu, 20 Jan 2011 02:21:44 -0500 Received: from ps.local.valinux.co.jp (vagw.valinux.co.jp [210.128.90.14]) by mail.valinux.co.jp (Postfix) with SMTP id 2E42C874A6; Thu, 20 Jan 2011 16:21:42 +0900 (JST) Received: (nullmailer pid 30589 invoked by uid 1000); Thu, 20 Jan 2011 07:21:40 -0000 From: Isaku Yamahata To: qemu-devel@nongnu.org Date: Thu, 20 Jan 2011 16:21:39 +0900 Message-Id: X-Mailer: git-send-email 1.7.1.1 In-Reply-To: References: In-Reply-To: References: X-Virus-Scanned: clamav-milter 0.95.2 at va-mail.local.valinux.co.jp X-Virus-Status: Clean X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: yamahata@valinux.co.jp, mst@redhat.com Subject: [Qemu-devel] [PATCH 2/3] msi: simply write config a bit. X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org use pci_device_deassert_intx(). Signed-off-by: Isaku Yamahata --- hw/msi.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index f03f519..3dc3a24 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -255,7 +255,6 @@ void msi_write_config(PCIDevice *dev, uint32_t addr, uint32_t val, int len) uint8_t log_max_vecs; unsigned int vector; uint32_t pending; - int i; if (!ranges_overlap(addr, len, dev->msi_cap, msi_cap_sizeof(flags))) { return; @@ -296,9 +295,7 @@ void msi_write_config(PCIDevice *dev, uint32_t addr, uint32_t val, int len) * from using its INTx# pin (if implemented) to request * service (MSI, MSI-X, and INTx# are mutually exclusive). */ - for (i = 0; i < PCI_NUM_PINS; ++i) { - qemu_set_irq(dev->irq[i], 0); - } + pci_device_deassert_intx(dev); /* * nr_vectors might be set bigger than capable. So clamp it.