| Message ID | ecd34e4b62c86b01df6e271d599f8361e2cad7fd.1397097046.git.jcody@redhat.com |
|---|---|
| State | New |
| Headers | show |
On Wed, 04/09 22:41, Jeff Cody wrote: > Both tests 019 and 086 need proper quotations to work with pathnames > that contain spaces. > > Signed-off-by: Jeff Cody <jcody@redhat.com> > --- > tests/qemu-iotests/019 | 2 +- > tests/qemu-iotests/086 | 8 ++++---- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tests/qemu-iotests/019 b/tests/qemu-iotests/019 > index e67445c..f5ecbf5 100755 > --- a/tests/qemu-iotests/019 > +++ b/tests/qemu-iotests/019 > @@ -96,7 +96,7 @@ mv "$TEST_IMG" "$TEST_IMG.orig" > for backing_option in "-B " "-o backing_file="; do > > echo > - echo Testing conversion with $backing_option$TEST_IMG.base | _filter_testdir | _filter_imgfmt > + echo Testing conversion with $backing_option"$TEST_IMG.base" | _filter_testdir | _filter_imgfmt > echo > $QEMU_IMG convert -O $IMGFMT $backing_option"$TEST_IMG.base" "$TEST_IMG.orig" "$TEST_IMG" > > diff --git a/tests/qemu-iotests/086 b/tests/qemu-iotests/086 > index 48fe85b..d9a80cf 100755 > --- a/tests/qemu-iotests/086 > +++ b/tests/qemu-iotests/086 > @@ -51,10 +51,10 @@ function run_qemu_img() > size=128M > > _make_test_img $size > -$QEMU_IO -c 'write 0 1M' $TEST_IMG | _filter_qemu_io > -$QEMU_IO -c 'write 2M 1M' $TEST_IMG | _filter_qemu_io > -$QEMU_IO -c 'write 4M 1M' $TEST_IMG | _filter_qemu_io > -$QEMU_IO -c 'write 32M 1M' $TEST_IMG | _filter_qemu_io > +$QEMU_IO -c 'write 0 1M' "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c 'write 2M 1M' "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c 'write 4M 1M' "$TEST_IMG" | _filter_qemu_io > +$QEMU_IO -c 'write 32M 1M' "$TEST_IMG" | _filter_qemu_io > > $QEMU_IMG convert -p -O $IMGFMT -f $IMGFMT "$TEST_IMG" "$TEST_IMG".base 2>&1 |\ > _filter_testdir | sed -e 's/\r/\n/g' > -- > 1.8.3.1 > > Reviewed-by: Fam Zheng <famz@redhat.com>
diff --git a/tests/qemu-iotests/019 b/tests/qemu-iotests/019 index e67445c..f5ecbf5 100755 --- a/tests/qemu-iotests/019 +++ b/tests/qemu-iotests/019 @@ -96,7 +96,7 @@ mv "$TEST_IMG" "$TEST_IMG.orig" for backing_option in "-B " "-o backing_file="; do echo - echo Testing conversion with $backing_option$TEST_IMG.base | _filter_testdir | _filter_imgfmt + echo Testing conversion with $backing_option"$TEST_IMG.base" | _filter_testdir | _filter_imgfmt echo $QEMU_IMG convert -O $IMGFMT $backing_option"$TEST_IMG.base" "$TEST_IMG.orig" "$TEST_IMG" diff --git a/tests/qemu-iotests/086 b/tests/qemu-iotests/086 index 48fe85b..d9a80cf 100755 --- a/tests/qemu-iotests/086 +++ b/tests/qemu-iotests/086 @@ -51,10 +51,10 @@ function run_qemu_img() size=128M _make_test_img $size -$QEMU_IO -c 'write 0 1M' $TEST_IMG | _filter_qemu_io -$QEMU_IO -c 'write 2M 1M' $TEST_IMG | _filter_qemu_io -$QEMU_IO -c 'write 4M 1M' $TEST_IMG | _filter_qemu_io -$QEMU_IO -c 'write 32M 1M' $TEST_IMG | _filter_qemu_io +$QEMU_IO -c 'write 0 1M' "$TEST_IMG" | _filter_qemu_io +$QEMU_IO -c 'write 2M 1M' "$TEST_IMG" | _filter_qemu_io +$QEMU_IO -c 'write 4M 1M' "$TEST_IMG" | _filter_qemu_io +$QEMU_IO -c 'write 32M 1M' "$TEST_IMG" | _filter_qemu_io $QEMU_IMG convert -p -O $IMGFMT -f $IMGFMT "$TEST_IMG" "$TEST_IMG".base 2>&1 |\ _filter_testdir | sed -e 's/\r/\n/g'
Both tests 019 and 086 need proper quotations to work with pathnames that contain spaces. Signed-off-by: Jeff Cody <jcody@redhat.com> --- tests/qemu-iotests/019 | 2 +- tests/qemu-iotests/086 | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-)